From: Andrew Morton <akpm@linux-foundation.org>
To: Oscar Salvador <osalvador@suse.de>
Cc: Dave Hansen <dave.hansen@linux.intel.com>,
Karsten Desler <kdesler@soohrt.org>,
Muchun Song <muchun.song@linux.dev>,
David Hildenbrand <david@kernel.org>,
Lorenzo Stoakes <ljs@kernel.org>,
Vlastimil Babka <vbabka@kernel.org>,
"Liam R . Howlett" <liam@infradead.org>,
Andreas Larsson <andreas@gaisler.com>,
"David S . Miller" <davem@davemloft.net>,
Huacai Chen <chenhuacai@kernel.org>,
Alexander Gordeev <agordeev@linux.ibm.com>,
Gerald Schaefer <gerald.schaefer@linux.ibm.com>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [PATCH 0/8] Stop special-casing hugetlb mappings in get_unmapped_area
Date: Sat, 27 Jun 2026 23:55:12 -0700 [thread overview]
Message-ID: <20260627235512.787d09b15b3d2ff9441e604a@linux-foundation.org> (raw)
In-Reply-To: <20260606035003.529685-1-osalvador@suse.de>
On Sat, 6 Jun 2026 05:49:55 +0200 Oscar Salvador <osalvador@suse.de> wrote:
> A regression was reported on AMD 15h Family for hugetlb mappings when 'align_va_addr'
> is set [1].
It would be helpful to say right here that this regression results in a
runtime BUG(). Helps get attention ;)
> Historically, for hugetlb mappings we always ignored 'align_offset' in get_unmapped_area
> functions, but after commit 7bd3f1e1a9ae ("mm: make hugetlb mappings go through
> mm_get_unmapped_area_vmflags") that was no longer the case for x86.
>
> While we could fix that by work it around in x86 code, the truth is that the current
> functioning of hugetlb mappings with get_unmapped_area functions is a bit clumsy, and
> we can do better.
> This patchset aims at two things:
>
> 1) Fix regression reported in [1]
> 2) Stop special-casing hugetlb mappings in get_unmapped_area functions
OK, so the offending commit was about 1.5 years ago.
Do we want to fix -stable kernels? If so, can we start out with
something minimal for backporting? And narrow down its Fixes:?
The series was sent at an awkward time in the -rc cycle, which perhaps
explains the lack of feedback. I suggest a refresh/retest/resend to
help bring people up to speed.
Sashiko has quite a lot to say - I hope some of it is useful?
https://sashiko.dev/#/patchset/20260606035003.529685-1-osalvador@suse.de
next prev parent reply other threads:[~2026-06-28 6:55 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-06 3:49 [PATCH 0/8] Stop special-casing hugetlb mappings in get_unmapped_area Oscar Salvador
2026-06-06 3:49 ` [PATCH 1/8] mm,hugetlb: Encode extra padding for aligning directly in hugetlb_get_unmapped_area Oscar Salvador
2026-06-06 3:49 ` [PATCH 2/8] mm/mmap: Stop special-casing hugetlb in generic_get_unmapped_area path Oscar Salvador
2026-06-06 3:49 ` [PATCH 3/8] arch/x86: Stop special-casing hugetlb mappings in arch_get_unmapped_area Oscar Salvador
2026-06-06 3:49 ` [PATCH 4/8] arch/s390: " Oscar Salvador
2026-06-30 17:10 ` Gerald Schaefer
2026-06-06 3:50 ` [PATCH 5/8] arch/loongarch: Stop special-casing hugetlb in arch_get_unmapped_area_common Oscar Salvador
2026-06-06 3:50 ` [PATCH 6/8] arch/sparc64: Stop special-casing hugetlb mappings in arch_get_unmapped_area Oscar Salvador
2026-06-06 3:50 ` [PATCH 7/8] arch/sparc32: Rip out hugetlb from sys_sparc_32.c Oscar Salvador
2026-06-06 3:50 ` [PATCH 8/8] mm,hugetlb: Kill huge_page_mask_align Oscar Salvador
2026-06-28 6:55 ` Andrew Morton [this message]
2026-06-29 10:21 ` [PATCH 0/8] Stop special-casing hugetlb mappings in get_unmapped_area Lorenzo Stoakes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260627235512.787d09b15b3d2ff9441e604a@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=agordeev@linux.ibm.com \
--cc=andreas@gaisler.com \
--cc=chenhuacai@kernel.org \
--cc=dave.hansen@linux.intel.com \
--cc=davem@davemloft.net \
--cc=david@kernel.org \
--cc=gerald.schaefer@linux.ibm.com \
--cc=kdesler@soohrt.org \
--cc=liam@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=ljs@kernel.org \
--cc=muchun.song@linux.dev \
--cc=osalvador@suse.de \
--cc=vbabka@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.