All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@linux-foundation.org>
To: Ren Wei <n05ec@lzu.edu.cn>
Cc: linux-kernel@vger.kernel.org,
	OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>,
	Yuan Tan <yuantan098@gmail.com>, Yifan Wu <yifanwucs@gmail.com>,
	Juefei Pu <tomapufckgml@gmail.com>, Xin Liu <bird@lzu.edu.cn>,
	Yemu Lu <prcups@krgm.moe>,
	linux-fsdevel@vger.kernel.org,
	Christian Brauner <brauner@kernel.org>
Subject: Re: [PATCH 1/1] fat: restore original value when fat_ent_write failed
Date: Sun, 28 Jun 2026 13:27:10 -0700	[thread overview]
Message-ID: <20260628132710.61ba480f961e8b87f02f80a2@linux-foundation.org> (raw)
In-Reply-To: <20260525085649.781643-1-n05ec@lzu.edu.cn>

On Mon, 25 May 2026 16:56:49 +0800 Ren Wei <n05ec@lzu.edu.cn> wrote:

> From: Yemu Lu <prcups@krgm.moe>
> 
> fat_ent_write() may have committed the new link to the primary FAT
> but then failed on the mirror copy, leaving the chain pointing to
> new_dclus even though the caller will free it. Restore the original
> value to keep the chain consistent.

Thanks.

When fixing bugs, please be careful to describe the userspace-visible
effects of that bug.  Here I'm assuming "dereferences freed pointer,
kernel crashes"?

> Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")
> Cc: stable@kernel.org


      parent reply	other threads:[~2026-06-28 20:27 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-25  8:56 [PATCH 1/1] fat: restore original value when fat_ent_write failed Ren Wei
2026-06-03  6:20 ` OGAWA Hirofumi
2026-06-28 20:27 ` Andrew Morton [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260628132710.61ba480f961e8b87f02f80a2@linux-foundation.org \
    --to=akpm@linux-foundation.org \
    --cc=bird@lzu.edu.cn \
    --cc=brauner@kernel.org \
    --cc=hirofumi@mail.parknet.co.jp \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=n05ec@lzu.edu.cn \
    --cc=prcups@krgm.moe \
    --cc=tomapufckgml@gmail.com \
    --cc=yifanwucs@gmail.com \
    --cc=yuantan098@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.