From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-dl1-f44.google.com (mail-dl1-f44.google.com [74.125.82.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EDAD33B0AD7 for ; Sun, 28 Jun 2026 14:58:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.44 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782658718; cv=none; b=c5SAAX4bq/EFAn3S7n3anZB4tv+8x+uKvAyolgpI/IDXpW6tgAKNYpYIlWZoQihYDXdtKiIQb5UcnyjmCA4MMc4TYmaaStoDkCcyxCCochTzv8du1ZL/5iwD9x+sIe4IUl8kNBgxQaeYBhbXucEOtwG2iewZNxUA8NmX3F2XxHg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782658718; c=relaxed/simple; bh=6KwVdXym8m9VmBu/yZDbGr4sR4go0nT/ImlSsY/m7K0=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=am9fQay4LmumpvFbNJ1/kvA/zUuMOld5FFBcv0G8hWRdSoid0e/YHpKhJG9sGV2dpAP8z1ZL0bClPqCPVMojpCGD4vKCcb11kYKAh1FL83K3c3aBcuxkxddMblU/cEVvuMTi+URwKu4wbewHMNuEC/PFiaDPNbaC3EnqY3Dl5NA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=IOiB8jv3; arc=none smtp.client-ip=74.125.82.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="IOiB8jv3" Received: by mail-dl1-f44.google.com with SMTP id a92af1059eb24-13810b63a1aso5829481c88.1 for ; Sun, 28 Jun 2026 07:58:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1782658716; x=1783263516; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=EJM+v6mJ9RBfgqnA3JaL3CQXECHO5LJ7tpDsIB136Js=; b=IOiB8jv3r1VcSv9aA/I7bv3fdnU6zrpdOKYS5nSK8ztFvZTqplBG2PQT4hIggSwXTM b/XhzdCVOq73SVWjOld8m0jGjfvjRlBIV3rtFkjM9SJZmmDVGex+Z0/pj/h7YSIU7vWv ZOKSsETiit4QBYqC8orVtmXW9se1lAGT/VH91rcD+WIQ4nP8i8ICOHiGe22nC8jeTk7c +1gQNLFF16a2Mb+lEEvJtzbMY0NaUTOnhMSdUVjquLPzc6mLmCSHe/rMjRvo5A2fnUVA yF+tdnE9d8zBh27UuP1An1+irceahpxuzr8ddkPKOmeoZlleVGvf0qQBkwETYasdWNQV Yvlg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782658716; x=1783263516; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=EJM+v6mJ9RBfgqnA3JaL3CQXECHO5LJ7tpDsIB136Js=; b=XPus3lDXw1TQcvwgr+B3SjngU7eYfKEEmOA0u6JPs/i7cU5X0mYPz9JStsKuz5Cgrg tZLchEXUBv+h7MC3tFMUErLM8bnWfhq+984HsIzGnfAjxTJKP7rlLRfBXLnuG7Xgg44J mRV6l5gv36SjWDjv4GUsqv/vwIiuu/I4TUOkG88DK9Bp38UVqxb1cDulfTCRj6bKQbKt 45CO4UkknJ3sb+XLMFAFnIaaOZqKAnhbLT3NNGf0BSshQPhThX3RHzhiFtXeHCsfIUN1 RR7R+Pk3CwJO/P+mrMtZpmVgXEYItWc2CBjTYDVwg0U6UZz5PlfDYXbHGhWObhL3Tdt7 0Y4g== X-Forwarded-Encrypted: i=1; AHgh+RqmUeXcjvc0f7UEZIeOQU/A5k8vdYAeh12OgsnUQJsIozRGwbJIwopCbYkKA8/4MCgEKeqXpBZ0c9OQYWQ=@vger.kernel.org X-Gm-Message-State: AOJu0YwfPL/o8k9gHToJ+3XF6CIBaUWzCGxGqqH8osXs0tPNS0XND704 89j6PVF9cdFzEjVUqogaOXyFphNAkYl8VvkYrHo88fvh6YRJFEd1sEse X-Gm-Gg: AfdE7clN31vCiHGYtuZ6cB43U/zO6EWG+gefi/Srm9Pto7SbI+XkNv8yvDvmRuq8sxf vmit11Mest2JDLz6RI92jmJhkPBf7sEV+/VwvQBEBA9zyiZ63JTNH9+LcQZ7xHYbkbecibJu2CJ i3zc+I4hBZyo1azgAYaNQjRhkxlEvqCze6F0OCuc0cnaqqaMmri353P7iBq47h3RCVaffUddAqQ JA1rY3gv99GZuzGxVSxRCHcC5+lPA7lNDOc0nKIc9gIZOUaxOSjMtIeqEDEGciOOpJk3j6dctmM Q78zUV0dxbhbfz5ClwqsAFdzEIZgeMIc0eUBHSlwmdoVLxiUYLerHSsomfz2Nghcw8rttczeO25 yDN1O/OqYe6YeaTZy16+cqkGZUCsP4aSnnfZLUMQvAQ9hpq3NazWt+k0bDgpjbkYMixyPHLR+v/ oCAQtx0VbY89nP2JZyZmFE8ecsbClOVOC43rhGoeJbdge2zdTYBxQUcJo6olAwou8d9nKma1hkO h/e X-Received: by 2002:a05:7301:3f0f:b0:30e:c32a:ec84 with SMTP id 5a478bee46e88-30ec32aee3dmr1786836eec.30.1782658716032; Sun, 28 Jun 2026 07:58:36 -0700 (PDT) Received: from moksh-Nitro-ANV15-51.. ([45.118.104.214]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-30c944999adsm31307072eec.24.2026.06.28.07.58.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 28 Jun 2026 07:58:35 -0700 (PDT) From: Moksh Panicker To: jic23@kernel.org Cc: nuno.sa@analog.com, Michael.Hennerich@analog.com, dlechner@baylibre.com, joshua.crofts1@gmail.com, linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, skhan@linuxfoundation.org, Moksh Panicker Subject: [PATCH v2 2/2] iio: adc: ad7779: Remove redundant dev_err_probe() after devm_request_irq() Date: Sun, 28 Jun 2026 14:57:34 +0000 Message-Id: <20260628145734.77191-3-mokshpanicker.7@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260628145734.77191-1-mokshpanicker.7@gmail.com> References: <20260628145734.77191-1-mokshpanicker.7@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit devm_request_irq() already prints an error message on failure via the IRQ core, so wrapping its return value in dev_err_probe() results in a duplicate error message. Return the error directly instead. Suggested-by: Joshua Crofts Signed-off-by: Moksh Panicker --- drivers/iio/adc/ad7779.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/iio/adc/ad7779.c b/drivers/iio/adc/ad7779.c index c1a99b4c1256..a5b8bfa99a74 100644 --- a/drivers/iio/adc/ad7779.c +++ b/drivers/iio/adc/ad7779.c @@ -842,8 +842,7 @@ static int ad7779_setup_without_backend(struct ad7779_state *st, struct iio_dev IRQF_NO_THREAD | IRQF_NO_AUTOEN, indio_dev->name, st->trig); if (ret) - return dev_err_probe(dev, ret, "request IRQ %d failed\n", - st->spi->irq); + return ret; ret = devm_iio_trigger_register(dev, st->trig); if (ret) -- 2.34.1