From: SJ Park <sj@kernel.org>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: SJ Park <sj@kernel.org>,
damon@lists.linux.dev, linux-kernel@vger.kernel.org,
linux-mm@kvack.org
Subject: [PATCH 11/11] mm/damon/sysfs-schemes: kobject_del() region for populate_region error
Date: Sun, 28 Jun 2026 15:01:20 -0700 [thread overview]
Message-ID: <20260628220121.97360-12-sj@kernel.org> (raw)
In-Reply-To: <20260628220121.97360-1-sj@kernel.org>
On CONFIG_DEBUG_KOBJECT_RELEASE enabled kernel, lack of kobject_del()
could cause directories creation failures due to the name conflicts.
Fix the issue for tried region directories in the error handling path of
damon_sysfs_populate_region_dir() by adding a kobject_del() call.
Fixes: b574a82d10de ("mm/damon/sysfs-schemes: implement tried_regions/<r>/probes/")
Signed-off-by: SJ Park <sj@kernel.org>
---
mm/damon/sysfs-schemes.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/mm/damon/sysfs-schemes.c b/mm/damon/sysfs-schemes.c
index e2c8716be6c9c..41f93a1823bf1 100644
--- a/mm/damon/sysfs-schemes.c
+++ b/mm/damon/sysfs-schemes.c
@@ -3132,12 +3132,14 @@ void damos_sysfs_populate_region_dir(struct damon_sysfs_schemes *sysfs_schemes,
sysfs_regions->nr_regions))
goto out;
if (damos_sysfs_region_add_dirs(region, ctx, r))
- goto out;
+ goto del_out;
list_add_tail(®ion->list, &sysfs_regions->regions_list);
sysfs_regions->nr_regions++;
return;
+del_out:
+ kobject_del(®ion->kobj);
out:
kobject_put(®ion->kobj);
}
--
2.47.3
prev parent reply other threads:[~2026-06-28 22:01 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-28 22:01 [PATCH 00/11] mm/damon/sysfs: kobject_del() directories that users can create/remove SJ Park
2026-06-28 22:01 ` [PATCH 01/11] mm/damon/sysfs: kobject_del() target (normal), context and kdamond dirs SJ Park
2026-06-28 22:01 ` [PATCH 02/11] mm/damon/sysfs: kobject_del() region and target (error) dirs SJ Park
2026-06-28 22:01 ` [PATCH 03/11] mm/damon/sysfs-schemes: kobject_del() scheme dirs SJ Park
2026-06-28 22:01 ` [PATCH 04/11] mm/damon/sysfs-schemes: kobject_del() scheme region dirs SJ Park
2026-06-28 22:01 ` [PATCH 05/11] mm/damon/sysfs-schemes: kobject_del() scheme filter dirs SJ Park
2026-06-28 22:01 ` [PATCH 06/11] mm/damon/sysfs-schemes: kobject_del() scheme quota goal dirs SJ Park
2026-06-28 22:01 ` [PATCH 07/11] mm/damon/sysfs-schemes: kobject_del() scheme action destination dirs SJ Park
2026-06-28 22:01 ` [PATCH 08/11] mm/damon/sysfs: kobject_del() probe dirs SJ Park
2026-06-28 22:01 ` [PATCH 09/11] mm/damon/sysfs: kobject_del() probe filter dirs SJ Park
2026-06-28 22:01 ` [PATCH 10/11] mm/damon/sysfs: kobject_del() probe dirs in probes_addd_dir error path SJ Park
2026-06-28 22:01 ` SJ Park [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260628220121.97360-12-sj@kernel.org \
--to=sj@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=damon@lists.linux.dev \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.