Re: [PATCH 2/2] clk: qcom: apss-ipq-pll: Add IPQ5210 support

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The struct `ipq5210_pll_data` is missing the `const` modifier.
--

commit 4658d262070dd0e2697e2fa6367ab1728d04bbf2
Author: Varadarajan Narayanan <varadarajan.narayanan@oss.qualcomm.com>

clk: qcom: apss-ipq-pll: Add IPQ5210 support

The Application Processor Subsystem on the IPQ5210 platform sources
its clock from the Huayra PLL. Add the configuration data necessary
to set it up.

> diff --git a/drivers/clk/qcom/apss-ipq-pll.c b/drivers/clk/qcom/apss-ipq-pll.c
> index 3a8987fe7008a..569ac76c75dc3 100644
> --- a/drivers/clk/qcom/apss-ipq-pll.c
> +++ b/drivers/clk/qcom/apss-ipq-pll.c
[ ... ]
> @@ -140,6 +152,12 @@ static const struct apss_pll_data ipq5018_pll_data = {
>  	.pll_config = &ipq5018_pll_config,
>  };
>  
> +static struct apss_pll_data ipq5210_pll_data = {

[Severity: Low]
This isn't a bug, but is it intentional that ipq5210_pll_data is missing
the const modifier here?

The other apss_pll_data structures (like ipq5018_pll_data and
ipq5332_pll_data) are declared as const, which allows them to be placed
in the read-only .rodata section.

> +	.pll_type = CLK_ALPHA_PLL_TYPE_HUAYRA,
> +	.pll = &ipq_pll_huayra,
> +	.pll_config = &ipq5210_pll_config,
> +};
> +
>  static const struct apss_pll_data ipq5332_pll_data = {

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260629-apss-clk-v1-0-8c92fe118ce4@oss.qualcomm.com?part=2