All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Krzysztof Wilczyński" <kwilczynski@kernel.org>
To: Christian Brauner <brauner@kernel.org>
Cc: Alexey Dobriyan <adobriyan@gmail.com>, Jan Kara <jack@suse.cz>,
	 Wei Yang <albinwyang@tencent.com>,
	Zijie Wang <wangzijie1@honor.com>,
	linux-fsdevel@vger.kernel.org,  linux-kernel@vger.kernel.org,
	Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH v2] proc: only bump parent nlink when registering directories
Date: Mon, 29 Jun 2026 14:42:17 +0900	[thread overview]
Message-ID: <20260629054007.GA2410937@rocinante> (raw)
In-Reply-To: <20260617-zeitig-umlagen-ortseinfahrt-1389d7457b0f@brauner>

Hello,

> > proc_register() increments the parent directory's link count for every
> > entry it registers, while remove_proc_entry() and remove_proc_subtree()
> > decrement it only when the removed entry is a directory.  Regular files
> > thus inflate the parent's count while they exist, and leak one link
> > permanently on every create and remove cycle.
> > 
> > For example, /proc/bus/pci/00 with twenty-two device files and no
> > subdirectories reports nlink 24 instead of 2, and SR-IOV VF enable
> > and disable cycles, each creating and removing the VF config space
> > entries under /proc/bus/pci/<bus>, inflate the link count of that
> > directory without bound.
> > 
> > [...]
> 
> Applied to the vfs.fixes branch of the vfs/vfs.git tree.
> Patches in the vfs.fixes branch should appear in linux-next soon.
[...] 
> [1/1] proc: only bump parent nlink when registering directories
>       https://git.kernel.org/vfs/vfs/c/552864f6ac8f

I assume this got lost?  Seems its missing from 7.2-rc1, sadly.

Thank you!

	Krzysztof

  reply	other threads:[~2026-06-29  5:42 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-13 21:10 [PATCH v2] proc: only bump parent nlink when registering directories Krzysztof Wilczyński
2026-06-17 13:21 ` Christian Brauner
2026-06-29  5:42   ` Krzysztof Wilczyński [this message]
2026-06-29  9:17     ` Jan Kara

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260629054007.GA2410937@rocinante \
    --to=kwilczynski@kernel.org \
    --cc=adobriyan@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=albinwyang@tencent.com \
    --cc=brauner@kernel.org \
    --cc=jack@suse.cz \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=wangzijie1@honor.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.