From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtpbgjp3.qq.com (smtpbgjp3.qq.com [54.92.39.34]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BB911389107 for ; Mon, 29 Jun 2026 06:26:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=54.92.39.34 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782714413; cv=none; b=AlMDR7U0X+ID60wAQ1v4aEEpljDjnpm6Kth9V68TsG3xHzVF01Nk+m6j666/u68ZQgSjIQ0fvSrkiPzIazaAJ9UsQsHbITgmvEZJe5EgO+we729GPwrdJY8idM4ixK7dV0ONAH/q818IPvJ1FywytTR0Q4+/M+JxXVrHis51DSs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782714413; c=relaxed/simple; bh=BglcD4/vcdg9tA42mTSW0VuqWiM38EodDCNxkPnFIro=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=duUnYvwd+KRmDdIgB2MjnC35ri+FKzkZS6GcSDNF6GY0cIY5gw+yrpVuLvk5aFNj5ntj7T3thsNzvzz5c8VEIpiNShIjuVoMASKZEmGC+Fi67UZGAB3qkOsxKWy779b4lBxthOIpdUC310uIJSPerv4FcuMmzmQpHfD53dsXASU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=uniontech.com; spf=pass smtp.mailfrom=uniontech.com; dkim=pass (1024-bit key) header.d=uniontech.com header.i=@uniontech.com header.b=NTEXyNwe; arc=none smtp.client-ip=54.92.39.34 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=uniontech.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=uniontech.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=uniontech.com header.i=@uniontech.com header.b="NTEXyNwe" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=uniontech.com; s=onoh2408; t=1782714355; bh=+tFQHxLTX0dibmKmXtrX097ixCjWL7DKuT31ZrIFN/s=; h=From:To:Subject:Date:Message-Id:MIME-Version; b=NTEXyNwet072lcuW5q7uW6OgKKQF/NhEXXMqLwvn6q3bV05rWc/bE+D22fwniv9yS PSxEFeBlQ3h5VPreUpJYHKYMnlJEiDBojpdxITT7EYNgOWfqfiSKGAFRUtpuZjas70 77zM4aLzeBWIi6EDf1kmRliewwbNhx99bGuFyMWM= X-QQ-mid: zesmtpsz2t1782714349tdc5bc9ee X-QQ-Originating-IP: MRRqws0X96a5pIiP0c4tXkNysJJ4vv85m6zaQ3EDsy8= Received: from uniontech.com ( [113.57.152.160]) by bizesmtp.qq.com (ESMTP) with id ; Mon, 29 Jun 2026 14:25:47 +0800 (CST) X-QQ-SSF: 0000000000000000000000000000000 X-QQ-GoodBg: 1 X-BIZMAIL-ID: 17589445697565877377 EX-QQ-RecipientCnt: 8 From: Yichong Chen To: akpm@linux-foundation.org Cc: vishal.moola@gmail.com, ye.liu@linux.dev, zhen.ni@easystack.cn, ziy@nvidia.com, chenyichong@uniontech.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: [PATCH] tools/mm/page_owner_sort: report get_comm failures at source Date: Mon, 29 Jun 2026 14:25:46 +0800 Message-Id: <20260629062546.141659-1-chenyichong@uniontech.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20260629014316.130307-1-chenyichong@uniontech.com> References: <20260629014316.130307-1-chenyichong@uniontech.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-QQ-SENDSIZE: 520 Feedback-ID: zesmtpsz:uniontech.com:qybglogicsvrgz:qybglogicsvrgz3a-0 X-QQ-XMAILINFO: MQPu5pFEJFN4PqAee0Zw3s0tAxG2u5g1WI6+c0n7O5JbW7gO+fodbZ78 PHTH2blyLm1WUpp1kL+i272HX5NWoNXG4wzS9mKq/hYeUFhAhvq2g5KgBle3X5BDEEcoETY vuLsPsEOWmFpZCttiZ09ui8fXiT2pac27rR0FQHR7ULY4vu9O32LHNwUh39MEODam0jOhhQ pyiPZNaRBeZqJRR7xOYv0fGB16z2sy7m8GmthR3Dzolbr58/EklBQo4N16RJ8R5gl8ExG+p WwZH2mat5CYiLHW1nEdzX1GEyw+oiH/17COP3qeHnUu8Hmws44ngxvD94AVkFtSxkrF6MKp VuifyB52DoUe6zJrlnHd3whhZbLKtGb7CWiBNWHtVmMrMf51D7j7LYvQmKYrmVmJNjeM74X nugmkfNebNUMAMNY7KUCLSQ3z5WwElj6u7Vyw2XwCeFAGgoXCF5wezlNZ2VZJW25E9DSw3q jqZXAS3sY7akTGEUgT1fFKdjNDnxknk5Y0kHyIi4JrmtUkaQDnywG/Z+VD4zO8DxDVa3bNy GHa9uxo2gkJefbSODBOA5qZKMO3SfneRcusvhyMBtTrBwhNfjB1PQz8bRAVoRQ8PwiYOvaa 9xBz8zw6y0pxwosYNo5DkNdk1xaIAc78U9bACpB8qd6ZzXh/dhiUgqecv2OVp/Qt21evtS3 3yW6G/qJKyDITQVG47f/YWFG5fkKvmH8T0pwRmZRyM8YzYyznQZVS0aBW6+6a112v9elO+X F7Mn4v2gqRI/gAwb73EKHjyOXm2w8/AW95kjkpWH0tNKZWeNwZNBPYhxmp5lF7WE4AUva9y ny7X9BqHebN6iBe1H0qlKGvL7xHGGYCTTnT1f/EGJyGtuHNWgPwaVX2993nMaIlSsZApb9c kR2d7lMiCoxV0nxFl4jethygkrlBoy9Um8WqRArk17qjRRcpiANNPeN7xpZGGs2YOZ8kSJr d5Hsy384TqyovHReiN5gDkKBiOVFoi7Og4FLKVKko8/kShelHlGO3r7C+n53ec/LeTgXaA9 wKg3Mcxnsz9pywBAbKExFVEoknzHBgXIF8NF4iXv/F1ENqVnjy X-QQ-XMRINFO: MSVp+SPm3vtSI1QTLgDHQqIV1w2oNKDqfg== X-QQ-RECHKSPAM: 0 get_comm() clears errno and checks it immediately, without any operation that can set errno in between. The check can never be true. Print the concrete get_comm() failure reason where it is detected, and let callers handle a NULL return without guessing the error cause. Signed-off-by: Yichong Chen --- tools/mm/page_owner_sort.c | 17 +++++------------ 1 file changed, 5 insertions(+), 12 deletions(-) diff --git a/tools/mm/page_owner_sort.c b/tools/mm/page_owner_sort.c index 35d3d254941c..30b3cfc7eeab 100644 --- a/tools/mm/page_owner_sort.c +++ b/tools/mm/page_owner_sort.c @@ -391,17 +391,14 @@ static char *get_comm(char *buf) { char *comm_str = malloc(TASK_COMM_LEN); - if (!comm_str) + if (!comm_str) { + fprintf(stderr, "Out of memory\n"); return NULL; + } memset(comm_str, 0, TASK_COMM_LEN); if (search_pattern(&comm_pattern, comm_str, TASK_COMM_LEN, buf) < 0) { - free(comm_str); - return NULL; - } - errno = 0; - if (errno != 0) { if (debug_on) fprintf(stderr, "wrong comm in follow buf:\n%s\n", buf); free(comm_str); @@ -514,19 +511,15 @@ static bool add_list(char *buf, int len, char *ext_buf) return false; } filter_result = filter_record(buf); - if (filter_result == FILTER_ERROR) { - fprintf(stderr, "Out of memory\n"); + if (filter_result == FILTER_ERROR) return false; - } if (filter_result == FILTER_SKIP) return true; list[list_size].pid = get_pid(buf); list[list_size].tgid = get_tgid(buf); list[list_size].comm = get_comm(buf); - if (!list[list_size].comm) { - fprintf(stderr, "Out of memory\n"); + if (!list[list_size].comm) return false; - } list[list_size].txt = malloc(len + 1); if (!list[list_size].txt) { fprintf(stderr, "Out of memory\n"); -- 2.51.0