From: sashiko-bot@kernel.org
To: "Santhosh Kumar K" <s-k6@ti.com>
Cc: robh@kernel.org, devicetree@vger.kernel.org, conor+dt@kernel.org
Subject: Re: [RESEND PATCH 1/2] dt-bindings: memory: Add TI FSS_FSAS binding
Date: Mon, 29 Jun 2026 06:58:18 +0000 [thread overview]
Message-ID: <20260629065819.3B3281F000E9@smtp.kernel.org> (raw)
In-Reply-To: <20260629065517.868418-2-s-k6@ti.com>
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The `$id` field in the YAML binding does not match the file's path relative to `Documentation/devicetree/bindings/`.
--
commit e6d297ef6febec50bca3376d0c0b57a9ece18a98
Author: Santhosh Kumar K <s-k6@ti.com>
dt-bindings: memory: Add TI FSS_FSAS binding
Add DT binding for the TI Flash Subsystem Application Subsystem
(FSS_FSAS_GENREGS) wrapper present in TI K3 SoCs. This block controls
XIP read prefetch for the OSPI controller.
> diff --git a/Documentation/devicetree/bindings/memory-controllers/ti,am62a-fsas.yaml b/Documentation/devicetree/bindings/memory-controllers/ti,am62a-fsas.yaml
> new file mode 100644
> index 0000000000000..81c71ebfb7e13
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/memory-controllers/ti,am62a-fsas.yaml
> @@ -0,0 +1,39 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +# Copyright (C) 2025 Texas Instruments Incorporated
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/soc/ti/ti,am62a-fsas.yaml#
[Severity: Low]
Does this $id field path match the actual file location?
The schema specifies the path as soc/ti/ti,am62a-fsas.yaml, but the patch
places the new file in memory-controllers/. Mismatched paths can break the
schema cross-reference system and cause dt_binding_check to report
misleading errors or silently skip validation.
[ ... ]
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260629065517.868418-1-s-k6@ti.com?part=1
next prev parent reply other threads:[~2026-06-29 6:58 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-29 6:55 [RESEND PATCH 0/2] Fix OSPI DMA corruption via FSS_FSAS driver Santhosh Kumar K
2026-06-29 6:55 ` [RESEND PATCH 1/2] dt-bindings: memory: Add TI FSS_FSAS binding Santhosh Kumar K
2026-06-29 6:58 ` sashiko-bot [this message]
2026-06-29 6:55 ` [RESEND PATCH 2/2] memory: ti-k3-fsas: Add TI FSS_FSAS driver Santhosh Kumar K
2026-06-29 7:07 ` sashiko-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260629065819.3B3281F000E9@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=robh@kernel.org \
--cc=s-k6@ti.com \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.