Re: [PATCH v4 4/7] riscv: stacktrace: introduce stack-bound tracking helpers

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Linker error for `irq_stack_ptr` when `CONFIG_IRQ_STACKS` is disabled.
--

commit 77c89ba9a3694750005502f08315093729bc5952
Author: Wang Han <wanghan@linux.alibaba.com>

riscv: stacktrace: introduce stack-bound tracking helpers

This commit introduces common stack unwinder types and helpers for RISC-V,
modeled after the arm64 implementation. It adds struct stack_info and accessors
for different stack types like IRQ, task, and overflow stacks. The unwinder
switch to use these helpers is planned for a follow-up commit.

> diff --git a/arch/riscv/include/asm/stacktrace.h b/arch/riscv/include/asm/stacktrace.h
> index b1495a7e06ce6..bc87c49403798 100644
> --- a/arch/riscv/include/asm/stacktrace.h
> +++ b/arch/riscv/include/asm/stacktrace.h

[ ... ]

> @@ -16,14 +21,70 @@ extern void notrace walk_stackframe(struct task_struct *task, struct pt_regs *re
>  extern void dump_backtrace(struct pt_regs *regs, struct task_struct *task,
>  			   const char *loglvl);
>  
> -static inline bool on_thread_stack(void)
> +/*
> + * IRQ stack accessors
> + */
> +static inline struct stack_info stackinfo_get_irq(void)
> +{
> +	unsigned long low = (unsigned long)raw_cpu_read(irq_stack_ptr);

[Severity: Low]
Will this cause a linker error when CONFIG_IRQ_STACKS is disabled?

This unconditionally references irq_stack_ptr, which lacks a definition when
CONFIG_IRQ_STACKS is disabled. While these helpers aren't wired up to callers
in this commit, when they are used in the follow-up commit, could this break
the build for configurations with CONFIG_FRAME_POINTER=y and
CONFIG_IRQ_STACKS=n?

> +	unsigned long high = low + IRQ_STACK_SIZE;
> +
> +	return (struct stack_info) {
> +		.low = low,
> +		.high = high,
> +	};
> +}

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260629064228.3195856-1-wanghan@linux.alibaba.com?part=4