Re: [PATCH v2 1/4] dt-bindings: connector: Add fsl,aud-io-slot binding

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The device tree binding defines clock and interrupt provider capabilities but omits the corresponding standard properties (`#clock-cells`, `interrupt-controller`, `#interrupt-cells`) from the `required` list.
--

commit 600c9389f32346f471a54074928953574a215cfc
Author: Chancel Liu <chancel.liu@nxp.com>

dt-bindings: connector: Add fsl,aud-io-slot binding

This commit introduces the NXP AUD-IO slot device tree binding. It acts as
a nexus exposing GPIOs, clocks, and interrupts from the base board for
attached expansion cards.

> diff --git a/Documentation/devicetree/bindings/connector/fsl,aud-io-slot.yaml b/Documentation/devicetree/bindings/connector/fsl,aud-io-slot.yaml
> new file mode 100644
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/connector/fsl,aud-io-slot.yaml

[ ... ]

> +allOf:
> +  - $ref: /schemas/gpio/gpio-nexus-node.yaml#
> +  - $ref: /schemas/clock/clock-nexus-node.yaml#
> +
> +required:
> +  - compatible
> +  - gpio-controller
> +  - '#gpio-cells'
> +  - gpio-map
> +  - gpio-map-mask
> +  - gpio-map-pass-thru

[Severity: Low]
Does this required block miss the standard properties for the clock and
interrupt providers defined earlier in the schema? Should `#clock-cells`,
`interrupt-controller`, and `#interrupt-cells` be included here?

> +
> +additionalProperties: false

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260629074734.3643227-1-chancel.liu@oss.nxp.com?part=1