From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out30-99.freemail.mail.aliyun.com (out30-99.freemail.mail.aliyun.com [115.124.30.99]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 580F93B42F2 for ; Mon, 29 Jun 2026 09:10:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=115.124.30.99 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782724231; cv=none; b=eQbSkdrMFOuEcYBL2FJLKInUaAAgja2UOsGVQqWnNn11nM3sSxMBFiP+qY4iFKIA71NafRVcltc9yQx57yR3RR6Ug6vqNmWkYL4yzkvDoessxb3XJpHfRrQY/mXaNVF7H81w1zVUKByN3L6wLCBvawrpWcv28Gpl0p89eYf0fbQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782724231; c=relaxed/simple; bh=cWSTOqfNKFUiiCcPmBA38s9HF/7AxHSB7v6e87yRM0Q=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=rmQOujKz0UfADQCnfJNCizLnLqtBanBkmUFMixIYceA8kwWYfcivxMiXmhQ1l072wUsM1Ljjyx+7WyYovkHp1wSoo3x/EtQPVU7lwvIQ4AiJ0Hg2URWu/34JZUOnqvoDDK5EIEixY2/NCD9TwiY05/DzNI+zDpHh2TVL5syxJNk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.alibaba.com; spf=pass smtp.mailfrom=linux.alibaba.com; dkim=pass (1024-bit key) header.d=linux.alibaba.com header.i=@linux.alibaba.com header.b=fXPUczre; arc=none smtp.client-ip=115.124.30.99 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.alibaba.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.alibaba.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.alibaba.com header.i=@linux.alibaba.com header.b="fXPUczre" DKIM-Signature:v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.alibaba.com; s=default; t=1782724226; h=From:To:Subject:Date:Message-ID:MIME-Version; bh=cWSTOqfNKFUiiCcPmBA38s9HF/7AxHSB7v6e87yRM0Q=; b=fXPUczreWQmI7lNDtECCbvecftnG/FgPuRNKbhnu3NektzmEN/L5lfO3QKjSGICYSza2FnrV5Yx/R6rA0CUV5oGigq/RscIrJN7dBDRTkaf4A1io88xsgVALa/ZUr8nKtiYnfbmEj8aLIf9C0gDXeHpZZ9QTqI0GTK1BMqjIXmw= X-Alimail-AntiSpam:AC=PASS;BC=-1|-1;BR=01201311R441e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=maildocker-contentspam033045133197;MF=cp0613@linux.alibaba.com;NM=1;PH=DS;RN=17;SR=0;TI=SMTPD_---0X5qxXep_1782724221; Received: from DESKTOP-S9E58SO.localdomain(mailfrom:cp0613@linux.alibaba.com fp:SMTPD_---0X5qxXep_1782724221 cluster:ay36) by smtp.aliyun-inc.com; Mon, 29 Jun 2026 17:10:25 +0800 From: Chen Pei To: Daniel Henrique Barboza Cc: jic23@kernel.org, pbonzini@redhat.com, palmer@dabbelt.com, alistair.francis@wdc.com, liwei1518@gmail.com, zhiwei_liu@linux.alibaba.com, chao.liu.zevorn@gmail.com, sunilvl@ventanamicro.com, dave.jiang@intel.com, alison.schofield@intel.com, imammedo@redhat.com, mst@redhat.com, guoren@kernel.org, qemu-riscv@nongnu.org, qemu-devel@nongnu.org, linux-cxl@vger.kernel.org Subject: Re: [PATCH v2 3/4] hw/riscv/virt,gpex: Provide 32-bit MMIO window for CXL host bridges Date: Mon, 29 Jun 2026 17:10:17 +0800 Message-ID: <20260629091019.71770-1-cp0613@linux.alibaba.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <79017627-4888-415a-9686-16367490b5b5@oss.qualcomm.com> References: <20260618093827.3507-1-cp0613@linux.alibaba.com> <20260618093827.3507-4-cp0613@linux.alibaba.com> <79017627-4888-415a-9686-16367490b5b5@oss.qualcomm.com> Precedence: bulk X-Mailing-List: linux-cxl@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Hi Daniel, On 6/24/2026 2:21 PM, Daniel Henrique Barboza wrote: > We can get rid of the braces - it's just adding an extra identation level while > not doing anything special. 'mmio32_size' can be declared at the start > of create_fdt_pcie(). Makes sense. I'll move mmio32_size to the top of create_fdt_pcie() and remove the extra braces in v3. Thanks, Pei From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id DB09AC43602 for ; Mon, 29 Jun 2026 09:11:01 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1we80m-0006fm-OK; Mon, 29 Jun 2026 05:10:40 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1we80k-0006fR-JT; Mon, 29 Jun 2026 05:10:39 -0400 Received: from [115.124.30.110] (helo=out30-110.freemail.mail.aliyun.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1we80i-0005ag-LJ; Mon, 29 Jun 2026 05:10:38 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.alibaba.com; s=default; t=1782724227; h=From:To:Subject:Date:Message-ID:MIME-Version; bh=cWSTOqfNKFUiiCcPmBA38s9HF/7AxHSB7v6e87yRM0Q=; b=gxJhYQzySN93TMpejx7u5fb3bfdh+9WpaDYu2OfJt6dopB5SHwLinSWS47KCBuQloaFV85XzrIypyMEpJ1pNWVXlFBVw+e7WwGQoHbdopgqQkQs/VUEP6+Us3a/qmJpkKi3iI12nyB/oPbmaeKEhgBYrjBc2PnxOhGQ3p1YcY0Q= X-Alimail-AntiSpam: AC=PASS; BC=-1|-1; BR=01201311R441e4; CH=green; DM=||false|; DS=||; FP=0|-1|-1|-1|0|-1|-1|-1; HT=maildocker-contentspam033045133197; MF=cp0613@linux.alibaba.com; NM=1; PH=DS; RN=17; SR=0; TI=SMTPD_---0X5qxXep_1782724221; Received: from DESKTOP-S9E58SO.localdomain(mailfrom:cp0613@linux.alibaba.com fp:SMTPD_---0X5qxXep_1782724221 cluster:ay36) by smtp.aliyun-inc.com; Mon, 29 Jun 2026 17:10:25 +0800 From: Chen Pei To: Daniel Henrique Barboza Cc: jic23@kernel.org, pbonzini@redhat.com, palmer@dabbelt.com, alistair.francis@wdc.com, liwei1518@gmail.com, zhiwei_liu@linux.alibaba.com, chao.liu.zevorn@gmail.com, sunilvl@ventanamicro.com, dave.jiang@intel.com, alison.schofield@intel.com, imammedo@redhat.com, mst@redhat.com, guoren@kernel.org, qemu-riscv@nongnu.org, qemu-devel@nongnu.org, linux-cxl@vger.kernel.org Subject: Re: [PATCH v2 3/4] hw/riscv/virt, gpex: Provide 32-bit MMIO window for CXL host bridges Date: Mon, 29 Jun 2026 17:10:17 +0800 Message-ID: <20260629091019.71770-1-cp0613@linux.alibaba.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <79017627-4888-415a-9686-16367490b5b5@oss.qualcomm.com> References: <20260618093827.3507-1-cp0613@linux.alibaba.com> <20260618093827.3507-4-cp0613@linux.alibaba.com> <79017627-4888-415a-9686-16367490b5b5@oss.qualcomm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Host-Lookup-Failed: Reverse DNS lookup failed for 115.124.30.110 (deferred) Received-SPF: pass client-ip=115.124.30.110; envelope-from=cp0613@linux.alibaba.com; helo=out30-110.freemail.mail.aliyun.com X-Spam_score_int: -166 X-Spam_score: -16.7 X-Spam_bar: ---------------- X-Spam_report: (-16.7 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, ENV_AND_HDR_SPF_MATCH=-0.5, RCVD_IN_DNSWL_NONE=-0.0001, RDNS_NONE=0.793, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, UNPARSEABLE_RELAY=0.001, USER_IN_DEF_DKIM_WL=-7.5, USER_IN_DEF_SPF_WL=-7.5 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-riscv@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-riscv-bounces+qemu-riscv=archiver.kernel.org@nongnu.org Sender: qemu-riscv-bounces+qemu-riscv=archiver.kernel.org@nongnu.org Hi Daniel, On 6/24/2026 2:21 PM, Daniel Henrique Barboza wrote: > We can get rid of the braces - it's just adding an extra identation level while > not doing anything special. 'mmio32_size' can be declared at the start > of create_fdt_pcie(). Makes sense. I'll move mmio32_size to the top of create_fdt_pcie() and remove the extra braces in v3. Thanks, Pei