From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 80659C43458 for ; Mon, 29 Jun 2026 09:45:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Reply-To:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:Message-Id:Date: References:In-Reply-To:Cc:To:Subject:From:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=S/l/Mvgb/hLm5cxuH+WwHWO0uvzNdPz2TMcVD7Djl6U=; b=CFdP9xOq/PoyDy qIridvqYT7YSycV+HBhQdVKw7C0FDiJeiLLEeHUx/tdkULUjuUvEgm7rojU6FjMJ4NfGqGqIBghIA w1BQj4ObwRJgz0tL0UdBLa6jqNtuXA5qzHTDZ63mQuyflyum+73qUXiEsPSjaN8kCeBXnboO6CIqp Xl9PrSBmjxqRVY2xGVtF3uosdr/9fd84e0nR4Mp2OnLuuXnLXNEnj07fXad6gO2F+Aj62Vgy6nYmf hFeemASKQjUBbQii5RxDcnAjzF5+gBBUCEoBDrO4Bx8cL5wal7GzCXAqFVTJOrguvu3MtK1I0J3E2 atE1CvVev9L83mnp/B9g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1we8YT-0000000EDpO-0wyn; Mon, 29 Jun 2026 09:45:29 +0000 Received: from tor.source.kernel.org ([172.105.4.254]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1we8YR-0000000EDoB-0ZuO for linux-phy@lists.infradead.org; Mon, 29 Jun 2026 09:45:27 +0000 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by tor.source.kernel.org (Postfix) with ESMTP id 92E01600DA; Mon, 29 Jun 2026 09:45:26 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D07981F000E9; Mon, 29 Jun 2026 09:45:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1782726326; bh=E7gPGaM9RQeO3jkA4ZoBpPSkAnV3cLriNrHnyZMMg9k=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=S1Ov1fTaqr9KWXr8gCRZGKtMtdK8Ro5YRdeW9JDyOeJwIZ72xJ9L31y7SgZd5shGE cPs6pcYZhB3I+RLvcJYclwmLJ/0RQrk9GXjHQILJxw4aukRuRQm3FcPS6Q004wYvpU JJZghO7SAjnb3oa7k0vNtScZ5MPdN5bcBN2k1YGZ+ymNrvo2VM8kC6/TSN4nUCIxWF 9Fr2Rj6BUfZWX53P3OrmJE+WW8vTeSiQ25gdhdWK7fK6PtPn7ihEK8zsi9EfatpaEJ XMP1LCrmHtwn9KKsBrtweIJDFt+zBb7Ltz0X3cby3ieeBUXI+ZuL1DkFZpXXIS78cf 8hvXologSynaw== From: sashiko-bot@kernel.org Subject: Re: [PATCH 6/8] phy: tegra: xusb: Add Tegra264 support To: "Wayne Chang" Cc: olteanv@gmail.com, vkoul@kernel.org, conor+dt@kernel.org, neil.armstrong@linaro.org, linux-phy@lists.infradead.org, robh@kernel.org, devicetree@vger.kernel.org In-Reply-To: <20260629093406.1118594-7-waynec@nvidia.com> References: <20260629093406.1118594-1-waynec@nvidia.com> <20260629093406.1118594-7-waynec@nvidia.com> Date: Mon, 29 Jun 2026 09:45:25 +0000 Message-Id: <20260629094525.D07981F000E9@smtp.kernel.org> X-BeenThere: linux-phy@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux Phy Mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: sashiko-reviews@lists.linux.dev MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-phy" Errors-To: linux-phy-bounces+linux-phy=archiver.kernel.org@lists.infradead.org VGhhbmsgeW91IGZvciB5b3VyIGNvbnRyaWJ1dGlvbiEgU2FzaGlrbyBBSSByZXZpZXcgZm91bmQg MiBwb3RlbnRpYWwgaXNzdWUocykgdG8gY29uc2lkZXI6Ci0gW01lZGl1bV0gTWlzc2luZyBgLmhh c19wZXJfcGFkX3Rlcm0gPSB0cnVlYCBmb3IgYHRlZ3JhMjY0X3h1c2JfcGFkY3RsX3NvY2AgbGVh ZHMgdG8gaW5jb3JyZWN0IFVTQjIgUEhZIHRlcm1pbmF0aW9uIGNhbGlicmF0aW9uLgotIFtMb3dd IE1pc3NpbmcgcHJvdG90eXBlIGNvbXBpbGVyIHdhcm5pbmcgZm9yIGB0ZWdyYTI2NF94dXNiX3Bh ZGN0bF9zb2NgIHdoZW4gaXRzIHNwZWNpZmljIGNvbmZpZyBpcyBkaXNhYmxlZC4KLS0KCmNvbW1p dCAyMmIwZmQyOGFhOTRhNTUyMzE2MDZjOGNiYmYyOGVmZmU1MGYzZjM1CkF1dGhvcjogV2F5bmUg Q2hhbmcgPHdheW5lY0BudmlkaWEuY29tPgoKcGh5OiB0ZWdyYTogeHVzYjogQWRkIFRlZ3JhMjY0 IHN1cHBvcnQKICAgIApBZGQgc3VwcG9ydCBmb3IgdGhlIFhVU0IgcGFkIGNvbnRyb2xsZXIgZm9y IFRlZ3JhMjY0LiBNb3N0IG9mIHRoZSBUZWdyYTI2NApYVVNCIFBBRENUTCByZWdpc3RlcnMgZGVm aW5pdGlvbiBhbmQgcHJvZ3JhbW1pbmcgc2VxdWVuY2UgYXJlIHRoZSBzYW1lIGFzClRlZ3JhMjM0 LCBhbmQgdGhleSBjYW4gc2hhcmUgdGhlIHNhbWUgZHJpdmVyLgoKPiBkaWZmIC0tZ2l0IGEvZHJp dmVycy9waHkvdGVncmEveHVzYi10ZWdyYTE4Ni5jIGIvZHJpdmVycy9waHkvdGVncmEveHVzYi10 ZWdyYTE4Ni5jCj4gaW5kZXggOWMxYmNkNGE3MmFjNi4uM2ViNjBlZDA5YjY4NyAxMDA2NDQKPiAt LS0gYS9kcml2ZXJzL3BoeS90ZWdyYS94dXNiLXRlZ3JhMTg2LmMKPiArKysgYi9kcml2ZXJzL3Bo eS90ZWdyYS94dXNiLXRlZ3JhMTg2LmMKWyAuLi4gXQo+IEBAIC0xNzUzLDYgKzE3NTQsMjkgQEAg Y29uc3Qgc3RydWN0IHRlZ3JhX3h1c2JfcGFkY3RsX3NvYyB0ZWdyYTIzNF94dXNiX3BhZGN0bF9z b2MgPSB7Cj4gIAkuaGFzX3Blcl9wYWRfdGVybSA9IHRydWUsCj4gIH07Cj4gIEVYUE9SVF9TWU1C T0xfR1BMKHRlZ3JhMjM0X3h1c2JfcGFkY3RsX3NvYyk7Cj4gKwo+ICtjb25zdCBzdHJ1Y3QgdGVn cmFfeHVzYl9wYWRjdGxfc29jIHRlZ3JhMjY0X3h1c2JfcGFkY3RsX3NvYyA9IHsKPiArCS5udW1f cGFkcyA9IEFSUkFZX1NJWkUodGVncmExOTRfcGFkcyksCj4gKwkucGFkcyA9IHRlZ3JhMTk0X3Bh ZHMsCj4gKwkucG9ydHMgPSB7Cj4gKwkJLnVzYjIgPSB7Cj4gKwkJCS5vcHMgPSAmdGVncmExODZf dXNiMl9wb3J0X29wcywKPiArCQkJLmNvdW50ID0gNCwKPiArCQl9LAo+ICsJCS51c2IzID0gewo+ ICsJCQkub3BzID0gJnRlZ3JhMTg2X3VzYjNfcG9ydF9vcHMsCj4gKwkJCS5jb3VudCA9IDQsCj4g KwkJfSwKPiArCX0sCj4gKwkub3BzID0gJnRlZ3JhMTg2X3h1c2JfcGFkY3RsX29wcywKPiArCS5z dXBwbHlfbmFtZXMgPSB0ZWdyYTE5NF94dXNiX3BhZGN0bF9zdXBwbHlfbmFtZXMsCj4gKwkubnVt X3N1cHBsaWVzID0gQVJSQVlfU0laRSh0ZWdyYTE5NF94dXNiX3BhZGN0bF9zdXBwbHlfbmFtZXMp LAo+ICsJLnN1cHBvcnRzX2dlbjIgPSB0cnVlLAo+ICsJLnBvbGxfdHJrX2NvbXBsZXRlZCA9IHRy dWUsCj4gKwkudHJrX2h3X21vZGUgPSB0cnVlLAo+ICsJLnN1cHBvcnRzX2xwX2NmZ19lbiA9IHRy dWUsCj4gK307CgpbU2V2ZXJpdHk6IE1lZGl1bV0KU2luY2UgdGhlIGNvbW1pdCBtZXNzYWdlIHN0 YXRlcyBUZWdyYTI2NCBzaGFyZXMgdGhlIHNhbWUgcHJvZ3JhbW1pbmcgc2VxdWVuY2UKYXMgVGVn cmEyMzQsIHNob3VsZCB0aGlzIHN0cnVjdCBhbHNvIGluY2x1ZGUgLmhhc19wZXJfcGFkX3Rlcm0g PSB0cnVlPwoKV2l0aG91dCB0aGlzIGZsYWcsIHRlZ3JhMTg2X3h1c2JfcmVhZF9mdXNlX2NhbGli cmF0aW9uKCkgd2lsbCBkZWZhdWx0IHRvCmNvcHlpbmcgcGFkIDAncyBjYWxpYnJhdGlvbiB0byBw YWRzIDEtMyBpbnN0ZWFkIG9mIHJlYWRpbmcgdGhlaXIgc3BlY2lmaWMKaGFyZHdhcmUgdmFsdWVz LgoKPiArRVhQT1JUX1NZTUJPTF9HUEwodGVncmEyNjRfeHVzYl9wYWRjdGxfc29jKTsKPiAgI2Vu ZGlmCj4gIAo+ICBNT0RVTEVfQVVUSE9SKCJKQyBLdW8gPGpja3VvQG52aWRpYS5jb20+Iik7Cgpb IC4uLiBdCgo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL3BoeS90ZWdyYS94dXNiLmggYi9kcml2ZXJz L3BoeS90ZWdyYS94dXNiLmgKPiBpbmRleCA3NzYwOWU1NGRlNjZhLi5kOGQ3OTlkOWU3NTIyIDEw MDY0NAo+IC0tLSBhL2RyaXZlcnMvcGh5L3RlZ3JhL3h1c2IuaAo+ICsrKyBiL2RyaXZlcnMvcGh5 L3RlZ3JhL3h1c2IuaAo+IEBAIC01MTQsNSArNTE0LDggQEAgZXh0ZXJuIGNvbnN0IHN0cnVjdCB0 ZWdyYV94dXNiX3BhZGN0bF9zb2MgdGVncmExOTRfeHVzYl9wYWRjdGxfc29jOwo+ICAjaWYgZGVm aW5lZChDT05GSUdfQVJDSF9URUdSQV8yMzRfU09DKQo+ICBleHRlcm4gY29uc3Qgc3RydWN0IHRl Z3JhX3h1c2JfcGFkY3RsX3NvYyB0ZWdyYTIzNF94dXNiX3BhZGN0bF9zb2M7Cj4gICNlbmRpZgo+ ICsjaWYgZGVmaW5lZChDT05GSUdfQVJDSF9URUdSQV8yNjRfU09DKQo+ICtleHRlcm4gY29uc3Qg c3RydWN0IHRlZ3JhX3h1c2JfcGFkY3RsX3NvYyB0ZWdyYTI2NF94dXNiX3BhZGN0bF9zb2M7Cj4g KyNlbmRpZgoKW1NldmVyaXR5OiBMb3ddCkRvZXMgdGhpcyBjcmVhdGUgYSBtaXNzaW5nIHByb3Rv dHlwZSB3YXJuaW5nICgtV21pc3NpbmctcHJvdG90eXBlcykgd2hlbgpidWlsZGluZyB3aXRoIENP TkZJR19BUkNIX1RFR1JBXzE5NF9TT0M9eSBidXQgQ09ORklHX0FSQ0hfVEVHUkFfMjY0X1NPQz1u PwoKSW4geHVzYi10ZWdyYTE4Ni5jLCB0ZWdyYTI2NF94dXNiX3BhZGN0bF9zb2MgaXMgZGVmaW5l ZCB1bmNvbmRpdGlvbmFsbHkgaWYKYW55IG9mIHRoZSAxOTQsIDIzNCwgb3IgMjY0IGNvbmZpZ3Mg YXJlIGVuYWJsZWQuIEhvd2V2ZXIsIHRoZSBleHRlcm4KZGVjbGFyYXRpb24gaGVyZSBpbiB4dXNi LmggaXMgb25seSB2aXNpYmxlIGlmIENPTkZJR19BUkNIX1RFR1JBXzI2NF9TT0MgaXMgc2V0LgoK LS0gClNhc2hpa28gQUkgcmV2aWV3IMK3IGh0dHBzOi8vc2FzaGlrby5kZXYvIy9wYXRjaHNldC8y MDI2MDYyOTA5MzQwNi4xMTE4NTk0LTEtd2F5bmVjQG52aWRpYS5jb20/cGFydD02CgotLSAKbGlu dXgtcGh5IG1haWxpbmcgbGlzdApsaW51eC1waHlAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwczov L2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1waHkK From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A00653B71B5 for ; Mon, 29 Jun 2026 09:45:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782726331; cv=none; b=N6z2cCesQV9aV30p2sKXbj+aIL/NtUbp4NBrZDpVcfjGrDd5hWPdl9VWtIHbrNb8XX9Ssb+2t3dK5gp3QjQ3e/N0OcP118NDyJs7zrPw/V/P7TvLI5FDK41qRKsP7MAc1wcGo3j/BZbbvzmNRADLdmvItkKbJA5Sx4QujhzuUOM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782726331; c=relaxed/simple; bh=MBQGPy5IWAkdF4aC66BC9lwMVhy2Aabk32/ei903M18=; h=From:Subject:To:Cc:In-Reply-To:References:Content-Type:Date: Message-Id; b=V+r7E3gRQm7Tbxp3M140AmjpjDIEv+PcP3+C0ZXOLc6wquz7XPDyDWxXlSV200VWFT28pvtKIEvCbh504L+A2qAcI/pC/05wCnXuKT6igxUP9zPO9s5950iQMCdth5Bpx38PqKLHWB+bePIUWi2FutuDZlLQlBvylA8SUshzK5E= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=S1Ov1fTa; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="S1Ov1fTa" Received: by smtp.kernel.org (Postfix) with ESMTPSA id D07981F000E9; Mon, 29 Jun 2026 09:45:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1782726326; bh=E7gPGaM9RQeO3jkA4ZoBpPSkAnV3cLriNrHnyZMMg9k=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=S1Ov1fTaqr9KWXr8gCRZGKtMtdK8Ro5YRdeW9JDyOeJwIZ72xJ9L31y7SgZd5shGE cPs6pcYZhB3I+RLvcJYclwmLJ/0RQrk9GXjHQILJxw4aukRuRQm3FcPS6Q004wYvpU JJZghO7SAjnb3oa7k0vNtScZ5MPdN5bcBN2k1YGZ+ymNrvo2VM8kC6/TSN4nUCIxWF 9Fr2Rj6BUfZWX53P3OrmJE+WW8vTeSiQ25gdhdWK7fK6PtPn7ihEK8zsi9EfatpaEJ XMP1LCrmHtwn9KKsBrtweIJDFt+zBb7Ltz0X3cby3ieeBUXI+ZuL1DkFZpXXIS78cf 8hvXologSynaw== From: sashiko-bot@kernel.org Subject: Re: [PATCH 6/8] phy: tegra: xusb: Add Tegra264 support Reply-To: sashiko-reviews@lists.linux.dev To: "Wayne Chang" Cc: olteanv@gmail.com, vkoul@kernel.org, conor+dt@kernel.org, neil.armstrong@linaro.org, linux-phy@lists.infradead.org, robh@kernel.org, devicetree@vger.kernel.org In-Reply-To: <20260629093406.1118594-7-waynec@nvidia.com> References: <20260629093406.1118594-1-waynec@nvidia.com> <20260629093406.1118594-7-waynec@nvidia.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Mon, 29 Jun 2026 09:45:25 +0000 Message-Id: <20260629094525.D07981F000E9@smtp.kernel.org> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Thank you for your contribution! Sashiko AI review found 2 potential issue(= s) to consider: - [Medium] Missing `.has_per_pad_term =3D true` for `tegra264_xusb_padctl_s= oc` leads to incorrect USB2 PHY termination calibration. - [Low] Missing prototype compiler warning for `tegra264_xusb_padctl_soc` w= hen its specific config is disabled. -- commit 22b0fd28aa94a55231606c8cbbf28effe50f3f35 Author: Wayne Chang phy: tegra: xusb: Add Tegra264 support =20 Add support for the XUSB pad controller for Tegra264. Most of the Tegra264 XUSB PADCTL registers definition and programming sequence are the same as Tegra234, and they can share the same driver. > diff --git a/drivers/phy/tegra/xusb-tegra186.c b/drivers/phy/tegra/xusb-t= egra186.c > index 9c1bcd4a72ac6..3eb60ed09b687 100644 > --- a/drivers/phy/tegra/xusb-tegra186.c > +++ b/drivers/phy/tegra/xusb-tegra186.c [ ... ] > @@ -1753,6 +1754,29 @@ const struct tegra_xusb_padctl_soc tegra234_xusb_p= adctl_soc =3D { > .has_per_pad_term =3D true, > }; > EXPORT_SYMBOL_GPL(tegra234_xusb_padctl_soc); > + > +const struct tegra_xusb_padctl_soc tegra264_xusb_padctl_soc =3D { > + .num_pads =3D ARRAY_SIZE(tegra194_pads), > + .pads =3D tegra194_pads, > + .ports =3D { > + .usb2 =3D { > + .ops =3D &tegra186_usb2_port_ops, > + .count =3D 4, > + }, > + .usb3 =3D { > + .ops =3D &tegra186_usb3_port_ops, > + .count =3D 4, > + }, > + }, > + .ops =3D &tegra186_xusb_padctl_ops, > + .supply_names =3D tegra194_xusb_padctl_supply_names, > + .num_supplies =3D ARRAY_SIZE(tegra194_xusb_padctl_supply_names), > + .supports_gen2 =3D true, > + .poll_trk_completed =3D true, > + .trk_hw_mode =3D true, > + .supports_lp_cfg_en =3D true, > +}; [Severity: Medium] Since the commit message states Tegra264 shares the same programming sequen= ce as Tegra234, should this struct also include .has_per_pad_term =3D true? Without this flag, tegra186_xusb_read_fuse_calibration() will default to copying pad 0's calibration to pads 1-3 instead of reading their specific hardware values. > +EXPORT_SYMBOL_GPL(tegra264_xusb_padctl_soc); > #endif > =20 > MODULE_AUTHOR("JC Kuo "); [ ... ] > diff --git a/drivers/phy/tegra/xusb.h b/drivers/phy/tegra/xusb.h > index 77609e54de66a..d8d799d9e7522 100644 > --- a/drivers/phy/tegra/xusb.h > +++ b/drivers/phy/tegra/xusb.h > @@ -514,5 +514,8 @@ extern const struct tegra_xusb_padctl_soc tegra194_xu= sb_padctl_soc; > #if defined(CONFIG_ARCH_TEGRA_234_SOC) > extern const struct tegra_xusb_padctl_soc tegra234_xusb_padctl_soc; > #endif > +#if defined(CONFIG_ARCH_TEGRA_264_SOC) > +extern const struct tegra_xusb_padctl_soc tegra264_xusb_padctl_soc; > +#endif [Severity: Low] Does this create a missing prototype warning (-Wmissing-prototypes) when building with CONFIG_ARCH_TEGRA_194_SOC=3Dy but CONFIG_ARCH_TEGRA_264_SOC= =3Dn? In xusb-tegra186.c, tegra264_xusb_padctl_soc is defined unconditionally if any of the 194, 234, or 264 configs are enabled. However, the extern declaration here in xusb.h is only visible if CONFIG_ARCH_TEGRA_264_SOC is = set. --=20 Sashiko AI review =C2=B7 https://sashiko.dev/#/patchset/20260629093406.1118= 594-1-waynec@nvidia.com?part=3D6