From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E4424C43602 for ; Mon, 29 Jun 2026 09:47:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Reply-To:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:Message-Id:Date: References:In-Reply-To:Cc:To:Subject:From:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=2PurfBqQcVcV6Ou1ng47+sxGAKZckjhZtag2laWcVNQ=; b=DINr6BPZFnlBtF trIIVv7z9DOChAyJmQDjpha0mEjV6rVqVp1CYVk7rQL2OYKIAPYigwYu+RGtSSJXq4k2bF3eHbtzv nyXm3KwrHyT6OJJGmO/EXs1iX9v3kt4Yhw/fp4rrYPCwko5QvxpMIMGZr0b5aol2r8jYUpY+hXHv9 YtzIUA4lmj9OccTj7uJynqn0BVFH9p1tEIiCHgkgj56iT/wl0NdBf9/e3cXCuzA+gTro1yLL2Qs/m SIDOOPksKIB8A4oW1kgW1IdYMKC85gtRubjdmWswkyRIKn/zdLXmcCcK4C+M6pDPy1zPVCN3X9MBI T8UNebOrvUdmgRdrwvvw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1we8a5-0000000EECx-2rl5; Mon, 29 Jun 2026 09:47:09 +0000 Received: from sea.source.kernel.org ([2600:3c0a:e001:78e:0:1991:8:25]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1we8a5-0000000EECq-0YOp for linux-phy@lists.infradead.org; Mon, 29 Jun 2026 09:47:09 +0000 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by sea.source.kernel.org (Postfix) with ESMTP id B251043AF7; Mon, 29 Jun 2026 09:47:08 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2FDA91F000E9; Mon, 29 Jun 2026 09:47:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1782726428; bh=25uXwRoYK3zia5mE2CwImEPPHOYkn1v2Gf8xHF2A5EU=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=kiU5h7UuokUwdlANijWDCOFklNPHwIplMIg1gGtb+SGyteXwi0kcYjAYUeq2d2Twa OjxNOBDh42f22WGoRCO5XEn8ui0oZCRkkGYIhiOFsxHRf1VVC2xqCMe1W3xHKS9T0r +hdqwiwkX+kiAymgEzL11wOzOaAcQQjl9qmA0CUAKhiH2ualkKS0x4mNRdI76tXNTY YWTXNyPwFEv8AjlJ8UHCVcb1fQTGpOYwEBEI8H42stlEba5xMkWHcyyDD0eUbsC4Hi Bypi1JlLUsYZACNBJqo9qKUo8cqTeQ6I4G+DhlEIdPOtAuwoOxBEnJSgTjzMQ1/stI 37QCtYU6bXROQ== From: sashiko-bot@kernel.org Subject: Re: [PATCH 8/8] usb: host: xhci-tegra: Add Tegra264 XHCI support To: "Wayne Chang" Cc: olteanv@gmail.com, vkoul@kernel.org, robh@kernel.org, neil.armstrong@linaro.org, devicetree@vger.kernel.org, linux-phy@lists.infradead.org, conor+dt@kernel.org In-Reply-To: <20260629093406.1118594-9-waynec@nvidia.com> References: <20260629093406.1118594-1-waynec@nvidia.com> <20260629093406.1118594-9-waynec@nvidia.com> Date: Mon, 29 Jun 2026 09:47:07 +0000 Message-Id: <20260629094708.2FDA91F000E9@smtp.kernel.org> X-BeenThere: linux-phy@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux Phy Mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: sashiko-reviews@lists.linux.dev MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-phy" Errors-To: linux-phy-bounces+linux-phy=archiver.kernel.org@lists.infradead.org VGhhbmsgeW91IGZvciB5b3VyIGNvbnRyaWJ1dGlvbiEgU2FzaGlrbyBBSSByZXZpZXcgZm91bmQg MSBwb3RlbnRpYWwgaXNzdWUocykgdG8gY29uc2lkZXI6Ci0gW01lZGl1bV0gVGhlIGB0ZWdyYTI2 NF9zb2NgIHN0cnVjdCBleHBsaWNpdGx5IHNldHMgYGVuYWJsZV9maXJtd2FyZV9tZXNzYWdlc2Ag dG8gYGZhbHNlYCwgY29udHJhZGljdGluZyB0aGUgY29tbWl0IG1lc3NhZ2UgdGhhdCBjbGFpbXMg dGhlIG9ubHkgZGlmZmVyZW5jZSBmcm9tIGB0ZWdyYTIzNF9zb2NgIGlzIGBtYXhfbnVtX3dha2Vz YC4KLS0KCmNvbW1pdCBmMzhjOTFlYTc0MzZiY2NhZTI2OGU2NjExZTE5MzFjZmYwMmYwN2VjCkF1 dGhvcjogV2F5bmUgQ2hhbmcgPHdheW5lY0BudmlkaWEuY29tPgoKdXNiOiBob3N0OiB4aGNpLXRl Z3JhOiBBZGQgVGVncmEyNjQgWEhDSSBzdXBwb3J0CgpUaGlzIGNvbW1pdCBhZGRzIFhVU0IgaG9z dCBtb2RlIGNvbnRyb2xsZXIgc3VwcG9ydCBmb3IgdGhlIFRlZ3JhMjY0IFNvQy4KSXQgZGVmaW5l cyBhIG5ldyB0ZWdyYV94dXNiX3NvYyBzdHJ1Y3QgZm9yIFRlZ3JhMjY0IGFuZCBhZGRzIGl0IHRv IHRoZQpPRiBtYXRjaCB0YWJsZS4KCj4gICAgIFRoZSBob3N0IGNvbnRyb2xsZXIgaXMgdmVyeSBz aW1pbGFyIHRvIHRoZSBleGlzdGluZyBUZWdyYTIzNCBYSENJLAo+ICAgICBleGNlcHQgdGhlIG51 bWJlciBvZiBtYXhfbnVtX3dha2VzLgoKWyAuLi4gXQoKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy91 c2IvaG9zdC94aGNpLXRlZ3JhLmMgYi9kcml2ZXJzL3VzYi9ob3N0L3hoY2ktdGVncmEuYwo+IGlu ZGV4IDdkNTZmMzVlYzllNzEuLjlhNTVkNTgxOGVmYjAgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy91 c2IvaG9zdC94aGNpLXRlZ3JhLmMKPiArKysgYi9kcml2ZXJzL3VzYi9ob3N0L3hoY2ktdGVncmEu YwpbIC4uLiBdCj4gQEAgLTI3NTIsMTIgKzI3NTIsNDAgQEAgc3RhdGljIGNvbnN0IHN0cnVjdCB0 ZWdyYV94dXNiX3NvYyB0ZWdyYTIzNF9zb2MgPSB7ClsgLi4uIF0KPiArc3RhdGljIGNvbnN0IHN0 cnVjdCB0ZWdyYV94dXNiX3NvYyB0ZWdyYTI2NF9zb2MgPSB7ClsgLi4uIF0KPiArCS5scG1fc3Vw cG9ydCA9IHRydWUsCj4gKwkuaGFzX2JhcjIgPSB0cnVlLAo+ICsJLmVuYWJsZV9maXJtd2FyZV9t ZXNzYWdlcyA9IGZhbHNlLAoKW1NldmVyaXR5OiBNZWRpdW1dCklzIHRoaXMgdmFsdWUgaW50ZW50 aW9uYWw/CgpUaGUgY29tbWl0IG1lc3NhZ2Ugc3RhdGVzIHRoYXQgdGhlIG9ubHkgZGlmZmVyZW5j ZSBmcm9tIFRlZ3JhMjM0IGlzCm1heF9udW1fd2FrZXMsIGJ1dCB0ZWdyYTIzNF9zb2Mgc2V0cyBl bmFibGVfZmlybXdhcmVfbWVzc2FnZXMgdG8gdHJ1ZS4KClNldHRpbmcgdGhpcyB0byBmYWxzZSBt ZWFucyB0aGUgZHJpdmVyIHdpbGwgc2tpcCBzZW5kaW5nIHRoZQpNQk9YX0NNRF9NU0dfRU5BQkxF RCBjb21tYW5kIHRvIHRoZSBjb250cm9sbGVyIHZpYQpfX3RlZ3JhX3h1c2JfZW5hYmxlX2Zpcm13 YXJlX21lc3NhZ2VzKCkgZHVyaW5nIGluaXRpYWxpemF0aW9uLgoKSWYgVGVncmEyNjQgcmVxdWly ZXMgdGhlc2UgbWVzc2FnZXMgZm9yIGNsb2NrIHNjYWxpbmcgb3IgcG93ZXIgbWFuYWdlbWVudAps aWtlIFRlZ3JhMjM0IGRvZXMsIHRoaXMgb21pc3Npb24gbWlnaHQgbGVhZCB0byBwZXJmb3JtYW5j ZSBvciBwb3dlcgptYW5hZ2VtZW50IGlzc3Vlcy4gQ291bGQgeW91IGNsYXJpZnkgaWYgdGhpcyBz aG91bGQgYmUgdHJ1ZSwgb3IgdXBkYXRlIHRoZQpjb21taXQgbWVzc2FnZSB0byByZWZsZWN0IHRo aXMgZGlmZmVyZW5jZT8KCi0tIApTYXNoaWtvIEFJIHJldmlldyDCtyBodHRwczovL3Nhc2hpa28u ZGV2LyMvcGF0Y2hzZXQvMjAyNjA2MjkwOTM0MDYuMTExODU5NC0xLXdheW5lY0BudmlkaWEuY29t P3BhcnQ9OAoKLS0gCmxpbnV4LXBoeSBtYWlsaW5nIGxpc3QKbGludXgtcGh5QGxpc3RzLmluZnJh ZGVhZC5vcmcKaHR0cHM6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGlu dXgtcGh5Cg== From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E65582D8378 for ; Mon, 29 Jun 2026 09:47:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782726429; cv=none; b=EQHOgQKtcfSbJDWvdkEktyvw7NoUA4imz9KYX7G/33r9YtjSmGsc8PAPvUi/nlMJFaaBC0liIgwbbmvPq+FwDFnF8DUDoZzQOb/jbsBPQycXl+Ea90lrbDBcUF98YxXqiOhbT/gUaVd2glfPmqVZpnRVvoYvYkcwUVQpM1IYak8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782726429; c=relaxed/simple; bh=vLnYfNt6wVJu2MbZFCkgeAoDnbnq7YgKlxy1niSnaRE=; h=From:Subject:To:Cc:In-Reply-To:References:Content-Type:Date: Message-Id; b=M7Mg6TX9Xz0Zn0pgjHlGtiaxLAKRDXWIQh0Hb8lJimHEXM5OeGiRrLFwrTSbOJagcYBbScZ3LnvX89+UKxpQfz3TZQLd9TzQvo5EDyDdoZa9H6OKWHJYYGXSsziZeiyj5FJxda6Z1qLY2pvECwrcOYCNe+xsXqcvpNep2RLPWaw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=kiU5h7Uu; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="kiU5h7Uu" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2FDA91F000E9; Mon, 29 Jun 2026 09:47:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1782726428; bh=25uXwRoYK3zia5mE2CwImEPPHOYkn1v2Gf8xHF2A5EU=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=kiU5h7UuokUwdlANijWDCOFklNPHwIplMIg1gGtb+SGyteXwi0kcYjAYUeq2d2Twa OjxNOBDh42f22WGoRCO5XEn8ui0oZCRkkGYIhiOFsxHRf1VVC2xqCMe1W3xHKS9T0r +hdqwiwkX+kiAymgEzL11wOzOaAcQQjl9qmA0CUAKhiH2ualkKS0x4mNRdI76tXNTY YWTXNyPwFEv8AjlJ8UHCVcb1fQTGpOYwEBEI8H42stlEba5xMkWHcyyDD0eUbsC4Hi Bypi1JlLUsYZACNBJqo9qKUo8cqTeQ6I4G+DhlEIdPOtAuwoOxBEnJSgTjzMQ1/stI 37QCtYU6bXROQ== From: sashiko-bot@kernel.org Subject: Re: [PATCH 8/8] usb: host: xhci-tegra: Add Tegra264 XHCI support Reply-To: sashiko-reviews@lists.linux.dev To: "Wayne Chang" Cc: olteanv@gmail.com, vkoul@kernel.org, robh@kernel.org, neil.armstrong@linaro.org, devicetree@vger.kernel.org, linux-phy@lists.infradead.org, conor+dt@kernel.org In-Reply-To: <20260629093406.1118594-9-waynec@nvidia.com> References: <20260629093406.1118594-1-waynec@nvidia.com> <20260629093406.1118594-9-waynec@nvidia.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Mon, 29 Jun 2026 09:47:07 +0000 Message-Id: <20260629094708.2FDA91F000E9@smtp.kernel.org> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Thank you for your contribution! Sashiko AI review found 1 potential issue(= s) to consider: - [Medium] The `tegra264_soc` struct explicitly sets `enable_firmware_messa= ges` to `false`, contradicting the commit message that claims the only diff= erence from `tegra234_soc` is `max_num_wakes`. -- commit f38c91ea7436bccae268e6611e1931cff02f07ec Author: Wayne Chang usb: host: xhci-tegra: Add Tegra264 XHCI support This commit adds XUSB host mode controller support for the Tegra264 SoC. It defines a new tegra_xusb_soc struct for Tegra264 and adds it to the OF match table. > The host controller is very similar to the existing Tegra234 XHCI, > except the number of max_num_wakes. [ ... ] > diff --git a/drivers/usb/host/xhci-tegra.c b/drivers/usb/host/xhci-tegra.c > index 7d56f35ec9e71..9a55d5818efb0 100644 > --- a/drivers/usb/host/xhci-tegra.c > +++ b/drivers/usb/host/xhci-tegra.c [ ... ] > @@ -2752,12 +2752,40 @@ static const struct tegra_xusb_soc tegra234_soc = =3D { [ ... ] > +static const struct tegra_xusb_soc tegra264_soc =3D { [ ... ] > + .lpm_support =3D true, > + .has_bar2 =3D true, > + .enable_firmware_messages =3D false, [Severity: Medium] Is this value intentional? The commit message states that the only difference from Tegra234 is max_num_wakes, but tegra234_soc sets enable_firmware_messages to true. Setting this to false means the driver will skip sending the MBOX_CMD_MSG_ENABLED command to the controller via __tegra_xusb_enable_firmware_messages() during initialization. If Tegra264 requires these messages for clock scaling or power management like Tegra234 does, this omission might lead to performance or power management issues. Could you clarify if this should be true, or update the commit message to reflect this difference? --=20 Sashiko AI review =C2=B7 https://sashiko.dev/#/patchset/20260629093406.1118= 594-1-waynec@nvidia.com?part=3D8