Re: [PATCH v3 7/7] mmc: sdhci-esdhc-imx: fix resume error handling

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [High] Early return on `pm_runtime_force_resume()` failure in `sdhci_esdhc_resume()` skips necessary software state cleanups, causing a PM runtime usage counter leak and leaving IRQs unbalanced.
--

commit 007c15943feda7e921c0c9613b702cc8b9ee7f97
Author: Luke Wang <ziniu.wang_1@nxp.com>

mmc: sdhci-esdhc-imx: fix resume error handling

This commit updates the resume function to check the return value of
pm_runtime_force_resume. If it fails, the function now returns immediately
to avoid hardware panics.

> diff --git a/drivers/mmc/host/sdhci-esdhc-imx.c b/drivers/mmc/host/sdhci-esdhc-imx.c
> --- a/drivers/mmc/host/sdhci-esdhc-imx.c
> +++ b/drivers/mmc/host/sdhci-esdhc-imx.c
> @@ -2125,12 +2125,12 @@ static int sdhci_esdhc_resume(struct device *dev)
>  			dev_warn(dev, "Failed to restore pinctrl state\n");
>  	}
>  
> -	pm_runtime_force_resume(dev);
> -
> -	ret = mmc_gpio_set_cd_wake(host->mmc, false);
> +	ret = pm_runtime_force_resume(dev);
>  	if (ret)
>  		return ret;

[Severity: High]
If pm_runtime_force_resume fails and we return early here, does this skip
necessary software state cleanups?

It looks like returning early bypasses the enable_irq() and
sdhci_disable_irq_wakeups() calls later in sdhci_esdhc_resume, which might
leave the IRQ descriptor depth and wakeup sources incorrectly configured.

[ ... ]

> @@ -2157,7 +2157,7 @@ static int sdhci_esdhc_resume(struct device *dev)
>  
>  	pm_runtime_put_autosuspend(dev);

[Severity: High]
If the early return is taken above, this PM usage count decrement is bypassed.

Will this permanently leave the device's PM runtime usage counter elevated,
preventing both the device and its parent power domains from ever runtime
suspending again?

>  
> -	return ret;
> +	return 0;
>  }

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260629091954.3227151-1-ziniu.wang_1@oss.nxp.com?part=7