Re: [PATCH v3 2/4] iio: ABI: add DAC 10kohm_to_gnd powerdown mode

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The patch fails to implement the spi_device_id named initializers change promised in the commit message.
--

commit 54fc2d1026683255f5c87f5095c8f2ddef61fbf3
Author: Kim Seer Paller <kimseer.paller@analog.com>

iio: dac: ad3530r: Refactor setup to table-driven register bank approach

This commit replaces direct register calls in ad3530r_setup() with per-chip
register address arrays and bank helpers. It also converts sw_ldac_trig_reg
to a function pointer for per-bank LDAC trigger register selection, and states
that it switches spi_device_id to named initializers.

> Replace direct register calls in ad3530r_setup() with per-chip register
> address arrays and bank helpers (ad3530r_set_reg_bank_bits,
> ad3530r_write_reg_banks). Convert sw_ldac_trig_reg from a static
> register address to a function pointer for per-bank LDAC trigger
> register selection. Switch spi_device_id to named initializers.

[Severity: Medium]
This isn't a bug, but the commit message states it switches spi_device_id to
named initializers, yet this patch doesn't appear to change ad3530r_id[] in
drivers/iio/dac/ad3530r.c. The array still uses positional initializers:

static const struct spi_device_id ad3530r_id[] = {
	{ "ad3530", (kernel_ulong_t)&ad3530_chip },
	{ "ad3530r", (kernel_ulong_t)&ad3530r_chip },
	...
};

Was this change accidentally omitted from this patch?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260629-iio-ad3532r-support-v3-0-f6e4f4abebbe@analog.com?part=2