From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 650DA334374 for ; Mon, 29 Jun 2026 12:50:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=213.95.11.211 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782737414; cv=none; b=ZN/ogOTVwwRzk36sHSckEm4uMVcdiJqvhwlncMkx/A4rG6J3CU3EFVnTcnRPMdN1DPubpmi+1OSKYyK8X0IwWpWmrCC8NaGkRcj8x1F8GH3gMl1RBIzyXSsGjUvwV7DbKCsEzdMMQnMIt2gOXfvHhHrEQKhGLm6urcXvWP8Mx/w= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782737414; c=relaxed/simple; bh=MkYOV2N+ye3AtTyhlMzZdDY3MG/RoGZzI6V5GzXN5tA=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=K0FkBzK5M+NuARmYDg8wflF5HztGELeASNf7gftPmCwS1cWDtqA+cIZDUIPgqimz1LnKSj6Mv+Onyrk3CeJ41vGbVJsM9DnEUbVFLRk+xk7So0foUmLkuoQ+fFWr5B13XJG+xiRJvkA2OFuk9DYU/dbj24lC9xtFDlNhooLymag= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lst.de; spf=pass smtp.mailfrom=lst.de; arc=none smtp.client-ip=213.95.11.211 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lst.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=lst.de Received: by verein.lst.de (Postfix, from userid 2407) id 170EE68CFE; Mon, 29 Jun 2026 14:50:11 +0200 (CEST) Date: Mon, 29 Jun 2026 14:50:10 +0200 From: Christoph Hellwig To: Nilay Shroff Cc: Christoph Hellwig , linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org, kbusch@kernel.org, sagi@grimberg.me, axboe@fb.com, bvanassche@acm.org, elver@google.com, gjoyce@linux.ibm.com Subject: Re: [PATCHv2 12/17] nvme: add Clang context annotations for nvme_queue::cq_poll_lock Message-ID: <20260629125010.GB23695@lst.de> References: <20260614131541.2017845-1-nilay@linux.ibm.com> <20260614131541.2017845-13-nilay@linux.ibm.com> <20260626064816.GB11106@lst.de> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.17 (2007-11-01) On Fri, Jun 26, 2026 at 08:52:36PM +0530, Nilay Shroff wrote: > > That's because nvme_poll() and nvme_irq() both reuse nvme_poll_cq() to > process completions, but they rely on different synchronization mechanisms. Well, we could split the function easily, but it still uses the same data structure and thus annotations.