Re: [PATCH 1/2] KVM: nSVM: Virtualize DecodeAssists for nested guests

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [High] The patch completely fails to propagate DecodeAssist information for hardware-generated #NPF exits, breaking its primary stated goal.
--

commit 25d49971bfa61318056a7a414a7878b30f3a2e0d
Author: Tina Zhang <zhang_wei@open-hieco.net>

KVM: nSVM: Virtualize DecodeAssists for nested guests

This commit advertises DecodeAssists to L1 nested guests and copies
instruction length and bytes from VMCB02 to VMCB12 for nested VM-Exits.
It introduces the decode_assists_valid flag to track real hardware exits
and prevent KVM from exposing stale bytes for KVM-synthesized exits.

> diff --git a/arch/x86/kvm/svm/nested.c b/arch/x86/kvm/svm/nested.c
> index 961804df5f451..86b5cd45a52fe 100644
> --- a/arch/x86/kvm/svm/nested.c
> +++ b/arch/x86/kvm/svm/nested.c

[ ... ]

> @@ -1608,8 +1650,11 @@ int nested_svm_exit_handled(struct vcpu_svm *svm)
>  
>  	vmexit = nested_svm_intercept(svm);
>  
> -	if (vmexit == NESTED_EXIT_DONE)
> +	if (vmexit == NESTED_EXIT_DONE) {
> +		/* This path reflects a real VMCB02 exit directly to L1. */
> +		svm->nested.decode_assists_valid = true;
>  		nested_svm_vmexit(svm);
> +	}
>  
>  	return vmexit;
>  }

[Severity: High]
Does this patch actually propagate DecodeAssist information for #NPF exits?

Looking at nested_svm_exit_special(), SVM_EXIT_NPF unconditionally returns
NESTED_EXIT_HOST. This bypasses nested_svm_exit_handled() entirely, meaning
svm->nested.decode_assists_valid is never set to true for nested page faults.

When KVM later reflects the fault to L1 via nested_svm_inject_npf_exit():

arch/x86/kvm/svm/nested.c:nested_svm_inject_npf_exit() {
        ...
        nested_svm_vmexit(svm);
}

The decode_assists_valid flag will still be false. Won't this cause
nested_svm_vmexit_update_vmcb12() to unconditionally clear the decode
fields, silently discarding the valid hardware DecodeAssist data in VMCB02
that the commit message mentions?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260629125205.52394-1-zhang_wei@open-hieco.net?part=1