Re: [PATCH 3/6] [v5] Input: soc_button_array - select CONFIG_GPIOLIB_LEGACY

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Duplicate inclusion of `<linux/gpio/consumer.h>`.
--

commit 2bb9f5b4a775c5b3c871a4230ef5de7eb9ac7ae6
Author: Arnd Bergmann <arnd@arndb.de>

Input: soc_button_array - select CONFIG_GPIOLIB_LEGACY

This commit adds dependencies and selects CONFIG_GPIOLIB_LEGACY for the
soc_button_array driver since it uses obsolete gpio interfaces. It also
replaces linux/gpio.h with linux/gpio/consumer.h in the driver source.

Link: https://lore.kernel.org/all/ah-1z9LhVG0wtfBw@google.com/

[ ... ]

> diff --git a/drivers/input/misc/soc_button_array.c b/drivers/input/misc/soc_button_array.c
> index b8cad415c62ca..eb11bf2e94362 100644
> --- a/drivers/input/misc/soc_button_array.c
> +++ b/drivers/input/misc/soc_button_array.c
> @@ -15,7 +15,7 @@
>  #include <linux/dmi.h>
>  #include <linux/gpio/consumer.h>
>  #include <linux/gpio_keys.h>
> -#include <linux/gpio.h>
> +#include <linux/gpio/consumer.h>

[Severity: Low]
This isn't a bug, but is it intentional to include <linux/gpio/consumer.h>
twice here?

>  #include <linux/platform_device.h>

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260629130329.1291953-1-arnd@kernel.org?part=3