From: Jakub Kicinski <kuba@kernel.org>
To: Xiang Mei <xmei5@asu.edu>
Cc: Andrew Lunn <andrew+netdev@lunn.ch>,
"David S . Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>,
netdev@vger.kernel.org, linux-usb@vger.kernel.org,
linux-kernel@vger.kernel.org, Weiming Shi <bestswngs@gmail.com>
Subject: Re: [PATCH net] net: usb: net1080: validate packet_len before pad-byte access in rx_fixup
Date: Mon, 29 Jun 2026 18:54:15 -0700 [thread overview]
Message-ID: <20260629185415.56ec8b67@kernel.org> (raw)
In-Reply-To: <20260627212854.4025016-1-xmei5@asu.edu>
On Sat, 27 Jun 2026 14:28:54 -0700 Xiang Mei wrote:
> if ((packet_len & 0x01) == 0) {
just add "skb->len &&" to this condition?
> + if (packet_len >= skb->len) {
> + dev->net->stats.rx_frame_errors++;
> + netdev_dbg(dev->net, "bad packet len %d (expected %d)\n",
> + skb->len, packet_len);
> + nc_ensure_sync(dev);
> + return 0;
> + }
--
pw-bot: cr
next prev parent reply other threads:[~2026-06-30 1:54 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-27 21:28 [PATCH net] net: usb: net1080: validate packet_len before pad-byte access in rx_fixup Xiang Mei
2026-06-30 1:54 ` Jakub Kicinski [this message]
2026-06-30 4:51 ` Xiang Mei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260629185415.56ec8b67@kernel.org \
--to=kuba@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=bestswngs@gmail.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=xmei5@asu.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.