[koverstreet-bcachefs:bcachefs-rebalance_v2 480/799] fs/bcachefs/alloc/background.c:210:5-8: Unneeded variable: "ret". Return "0" on line 218

[kernel test robot <lkp@intel.com>]

Hi Kent,

First bad commit (maybe != root cause):

tree:   https://github.com/koverstreet/bcachefs bcachefs-rebalance_v2
head:   d4b3d00447faf8d4d95db47e3902e4ca4db8fbdc
commit: 1793cc6db8c9956fee64b427113359b3a2df7678 [480/799] bcachefs: errptr_try()
config: arc-randconfig-r061-20260629 (https://download.01.org/0day-ci/archive/20260629/202606292212.55YVp6MG-lkp@intel.com/config)
compiler: arc-linux-gcc (GCC) 8.5.0

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202606292212.55YVp6MG-lkp@intel.com/

cocci warnings: (new ones prefixed by >>)
>> fs/bcachefs/alloc/background.c:210:5-8: Unneeded variable: "ret". Return "0" on line 218
   fs/bcachefs/alloc/background.c:225:5-8: Unneeded variable: "ret". Return "0" on line 231
   fs/bcachefs/alloc/background.c:238:5-8: Unneeded variable: "ret". Return "0" on line 244
   fs/bcachefs/alloc/background.c:527:5-8: Unneeded variable: "ret". Return "0" on line 534
--
>> fs/bcachefs/data/extents.c:531:5-8: Unneeded variable: "ret". Return "0" on line 537
   fs/bcachefs/data/extents.c:1460:5-8: Unneeded variable: "ret". Return "0" on line 1584
--
>> fs/bcachefs/alloc/lru.c:23:5-8: Unneeded variable: "ret". Return "0" on line 29
   fs/bcachefs/alloc/lru.c:86:5-8: Unneeded variable: "ret". Return "0" on line 104

vim +210 fs/bcachefs/alloc/background.c

1c6fdbd8f2465d fs/bcachefs/alloc.c            Kent Overstreet 2017-03-16  205  
d97de0d017cde0 fs/bcachefs/alloc_background.c Kent Overstreet 2024-08-12  206  int bch2_alloc_v1_validate(struct bch_fs *c, struct bkey_s_c k,
a6f4794fcd8627 fs/bcachefs/alloc_background.c Kent Overstreet 2024-11-27  207  			   struct bkey_validate_context from)
1c6fdbd8f2465d fs/bcachefs/alloc.c            Kent Overstreet 2017-03-16  208  {
26609b619fa230 fs/bcachefs/alloc_background.c Kent Overstreet 2018-11-01  209  	struct bkey_s_c_alloc a = bkey_s_c_to_alloc(k);
b65db750e2bb92 fs/bcachefs/alloc_background.c Kent Overstreet 2023-10-24 @210  	int ret = 0;
26609b619fa230 fs/bcachefs/alloc_background.c Kent Overstreet 2018-11-01  211  
e88973373aaabe fs/bcachefs/alloc_background.c Kent Overstreet 2018-11-22  212  	/* allow for unknown fields */
d97de0d017cde0 fs/bcachefs/alloc_background.c Kent Overstreet 2024-08-12  213  	bkey_fsck_err_on(bkey_val_u64s(a.k) < bch_alloc_v1_val_u64s(a.v),
d97de0d017cde0 fs/bcachefs/alloc_background.c Kent Overstreet 2024-08-12  214  			 c, alloc_v1_val_size_bad,
b65db750e2bb92 fs/bcachefs/alloc_background.c Kent Overstreet 2023-10-24  215  			 "incorrect value size (%zu < %u)",
f0ac7df23d04f3 fs/bcachefs/alloc_background.c Kent Overstreet 2022-04-03  216  			 bkey_val_u64s(a.k), bch_alloc_v1_val_u64s(a.v));
b65db750e2bb92 fs/bcachefs/alloc_background.c Kent Overstreet 2023-10-24  217  fsck_err:
b65db750e2bb92 fs/bcachefs/alloc_background.c Kent Overstreet 2023-10-24 @218  	return ret;
1c6fdbd8f2465d fs/bcachefs/alloc.c            Kent Overstreet 2017-03-16  219  }
1c6fdbd8f2465d fs/bcachefs/alloc.c            Kent Overstreet 2017-03-16  220  

:::::: The code at line 210 was first introduced by commit
:::::: b65db750e2bb9252321fd54c284edd73c1595a09 bcachefs: Enumerate fsck errors

:::::: TO: Kent Overstreet <kent.overstreet@linux.dev>
:::::: CC: Kent Overstreet <kent.overstreet@linux.dev>

--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki