From: Christoph Hellwig <hch@lst.de>
To: Damien Le Moal <dlemoal@kernel.org>
Cc: Christoph Hellwig <hch@lst.de>, Jens Axboe <axboe@kernel.dk>,
linux-block@vger.kernel.org
Subject: Re: [PATCH] block: avoid potential deadlock on zone revalidation failure
Date: Tue, 30 Jun 2026 07:12:35 +0200 [thread overview]
Message-ID: <20260630051235.GA20771@lst.de> (raw)
In-Reply-To: <535959f9-b6fc-475e-b5e7-99b0dae839a4@kernel.org>
> I checked and this is not simple to do because most drivers (null_blk, zloop,
> ublk, virtio_blk, DM and nvme) call blk_revalidate_disk_zones() *before* calling
> add_disk(). Which makes sense as we really want to check everything before the
> disk is visible to the user. SCSI sd is an exception here.
>
> And I do not see a better way without the addition of something like a new
> disk_create_one_resources() that all drivers would need to call.
Ok, then let's do this simple version:
Reviewed-by: Christoph Hellwig <hch@lst.de>
next prev parent reply other threads:[~2026-06-30 5:12 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-25 6:28 [PATCH] block: avoid potential deadlock on zone revalidation failure Damien Le Moal
2026-06-25 11:52 ` Christoph Hellwig
2026-06-26 5:40 ` Damien Le Moal
2026-06-26 22:42 ` Damien Le Moal
2026-06-30 5:12 ` Christoph Hellwig [this message]
2026-07-01 6:52 ` Hannes Reinecke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260630051235.GA20771@lst.de \
--to=hch@lst.de \
--cc=axboe@kernel.dk \
--cc=dlemoal@kernel.org \
--cc=linux-block@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.