Re: [PATCH 2/7] pwm: th1520: use vertical import style

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Incomplete conversion to vertical import style; missed multiple imports.
--

commit 6d048655750f08bf1b238e917a37ca506f11dd45
Author: Guru Das Srinagesh <linux@gurudas.dev>

pwm: th1520: use vertical import style

This commit converts use imports to a vertical layout for improved readability
and maintainability.

> diff --git a/drivers/pwm/pwm_th1520.rs b/drivers/pwm/pwm_th1520.rs
> index 3e3fa51ccef91..3e4524a1910bc 100644
> --- a/drivers/pwm/pwm_th1520.rs
> +++ b/drivers/pwm/pwm_th1520.rs
> @@ -23,12 +23,16 @@
>  use core::ops::Deref;
>  use kernel::{
>      clk::Clk,
> -    device::{Bound, Core, Device},
> +    device::{
> +        Bound,
> +        Core,
> +        Device, //
> +    },
>      devres,
>      io::{
>          mem::IoMem,
>          Io, //
>      },
>      of, platform,
>      prelude::*,
>      pwm, time,

[Severity: Low]
Are some modules still grouped horizontally here?

The commit message states the goal is to convert imports to a vertical layout.
However, the use kernel::{ ... } block still contains horizontal imports for
of, platform, pwm, and time.

Could these remaining imports be split onto their own lines to fully implement
the vertical style?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260628-b4-rust-vertical-imports-v1-0-98bc71d4810b@gurudas.dev?part=2