From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 83257368D4B; Tue, 30 Jun 2026 14:23:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782829426; cv=none; b=DEY9ZpmRXpSjLEkul+FfIF/e09r893yXMr2obifP1Gv9Mkp9ODYMkELQhRXTK68gWhFpEsSt4F89m60yyqPH375a24kevQ6eSIf9sEqCUbu6ZAuQ3447qAlbqea6moVc2NUxjGLyRCc0nGHhIk4xc6UUPiF2Gtl8Ae782gp4lqM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782829426; c=relaxed/simple; bh=3O5OEYtoiC/BcR7MNSFFY3fLzuzy0V5o6unbzI7k44Q=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=pKObPROSD0CxKSzqLh//LOaUZJhG9DFtGEvtBWAkEGhNhXhQHGaRu00wd6z0Lv11HUGc9yot4a+LcTwU6S3Wo8jye0OXP5IDCCh4/SbxNHZYkgReVa2cP8XEnuxFegIr7BUlzuHSMffhFDBROvaft7TvHhEWceEGSKkN3uLk/fo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=FAKx/t6u; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="FAKx/t6u" Received: by smtp.kernel.org (Postfix) with ESMTPSA id DE4E91F000E9; Tue, 30 Jun 2026 14:23:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1782829425; bh=4Hhhr2XcfubTUcrvTbwWhwLy7CUCWTZEVOLPtuGC1E4=; h=Date:From:To:Cc:Subject:In-Reply-To:References; b=FAKx/t6uR6e0YnXhUD4OAIvzCSGSFQqB0vFZUhEgy2dgiJnluy0duaFK6NLRYiwtu fVDfi6acLZR+l3CUXlY5hftQWt/eE24AJXi/lvEcSdMFqXuJ4frYnZ0itSCqWXgRpl NkxGX/Z1g2YgctN43YDAMXODPkhFFnXpPr67j43JUyr96RZ4YBioADsYLsm1iFUxvL kodoBEkjnvidKLPf8W0IWgLBeeikaJ/MwZ32d9NW2RcMvE5Z8DmTV/IfxrRD1LrLCw CIGyHDS/uvzs9a2YLUoQJ/+oG9AWfESzK2/RaL5bmBD/3DuJWQPM2GV+9y8JozF2SR aMsyqYRgaYGUQ== Date: Tue, 30 Jun 2026 07:23:44 -0700 From: Jakub Kicinski To: "Mike Rapoport (Microsoft)" Cc: Andrew Lunn , "David S. Miller" , Eric Dumazet , Paolo Abeni , Brian Norris , Edward Cree , Francesco Dolcini , Manish Chopra , Przemek Kitszel , Sudarsana Kalluru , Tony Nguyen , b43-dev@lists.infradead.org, intel-wired-lan@lists.osuosl.org, libertas-dev@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-net-drivers@amd.com, linux-wireless@vger.kernel.org, netdev@vger.kernel.org Subject: Re: [PATCH net-next 0/8] drivers/net: replace __get_free_pages() with kmalloc() Message-ID: <20260630072344.159b5d99@kernel.org> In-Reply-To: <20260630-b4-drivers-net-v1-0-672162a91f37@kernel.org> References: <20260630-b4-drivers-net-v1-0-672162a91f37@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Tue, 30 Jun 2026 13:59:19 +0300 Mike Rapoport (Microsoft) wrote: > drivers/net/ethernet/broadcom/bnx2x/bnx2x_sp.c | 6 +-- > drivers/net/ethernet/intel/ice/ice_gnss.c | 5 +- > drivers/net/ethernet/sfc/mcdi.c | 7 +-- > drivers/net/ethernet/sfc/siena/mcdi.c | 7 +-- > drivers/net/wireless/broadcom/b43/debugfs.c | 12 ++--- > drivers/net/wireless/broadcom/b43legacy/debugfs.c | 11 ++-- > drivers/net/wireless/marvell/libertas/debugfs.c | 39 ++++++-------- > drivers/net/wireless/marvell/mwifiex/debugfs.c | 62 ++++++++++------------- > drivers/net/wireless/ti/wlcore/main.c | 14 +++-- You gotta split this, wireless and ethernet go via separate trees. BTW cocci also suggests folding in a memset, IDK if it's worth it. drivers/net/wireless/broadcom/b43legacy/debugfs.c:217:8-15: WARNING: kzalloc should be used for buf, instead of kmalloc/memset -- pw-bot: cr From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 37551C43458 for ; Tue, 30 Jun 2026 14:23:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=jM157rjQdlR1RsB7AH22fxfvhfHr/LQO9dQ4Nkt+gvo=; b=WWzbTTONUyANMW qpxi1nCEZIfk6G8FlC8hcKXieprm85FNFfmnql5y3yhXhMoCExA653nTcAeLsgrXkXlFBxNGdvJuk cokl+B+dses7zv5eLP7rmbkIZINuj2Wv0haHj6j33r93oKsE5pW9EMzOr4oLtskY+LkUqPgf6UuQo eLxA2/I4eKUvhlqeFrIoNJmpqhqfBglms+Fv9gHwDVrvbAkNoN7k1KUvaacQ9n25GOaH7+2Ta4bYn 1RNUuP4riruenW7+myebxn8AImThnXRBE2axmIUrbRmFdRNctYogdx71nIH2f7WuDkelk4ORAqPP6 rrTaydcYmb1PKt4RYbLg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1weZNM-0000000HH5D-3AGL; Tue, 30 Jun 2026 14:23:48 +0000 Received: from tor.source.kernel.org ([172.105.4.254]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1weZNK-0000000HH4v-2BDX; Tue, 30 Jun 2026 14:23:46 +0000 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by tor.source.kernel.org (Postfix) with ESMTP id B217B601DC; Tue, 30 Jun 2026 14:23:45 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id DE4E91F000E9; Tue, 30 Jun 2026 14:23:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1782829425; bh=4Hhhr2XcfubTUcrvTbwWhwLy7CUCWTZEVOLPtuGC1E4=; h=Date:From:To:Cc:Subject:In-Reply-To:References; b=FAKx/t6uR6e0YnXhUD4OAIvzCSGSFQqB0vFZUhEgy2dgiJnluy0duaFK6NLRYiwtu fVDfi6acLZR+l3CUXlY5hftQWt/eE24AJXi/lvEcSdMFqXuJ4frYnZ0itSCqWXgRpl NkxGX/Z1g2YgctN43YDAMXODPkhFFnXpPr67j43JUyr96RZ4YBioADsYLsm1iFUxvL kodoBEkjnvidKLPf8W0IWgLBeeikaJ/MwZ32d9NW2RcMvE5Z8DmTV/IfxrRD1LrLCw CIGyHDS/uvzs9a2YLUoQJ/+oG9AWfESzK2/RaL5bmBD/3DuJWQPM2GV+9y8JozF2SR aMsyqYRgaYGUQ== Date: Tue, 30 Jun 2026 07:23:44 -0700 From: Jakub Kicinski To: "Mike Rapoport (Microsoft)" Cc: Andrew Lunn , "David S. Miller" , Eric Dumazet , Paolo Abeni , Brian Norris , Edward Cree , Francesco Dolcini , Manish Chopra , Przemek Kitszel , Sudarsana Kalluru , Tony Nguyen , b43-dev@lists.infradead.org, intel-wired-lan@lists.osuosl.org, libertas-dev@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-net-drivers@amd.com, linux-wireless@vger.kernel.org, netdev@vger.kernel.org Subject: Re: [PATCH net-next 0/8] drivers/net: replace __get_free_pages() with kmalloc() Message-ID: <20260630072344.159b5d99@kernel.org> In-Reply-To: <20260630-b4-drivers-net-v1-0-672162a91f37@kernel.org> References: <20260630-b4-drivers-net-v1-0-672162a91f37@kernel.org> MIME-Version: 1.0 X-BeenThere: b43-dev@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: b43/b43legacy Linux driver discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "b43-dev" Errors-To: b43-dev-bounces+b43-dev=archiver.kernel.org@lists.infradead.org On Tue, 30 Jun 2026 13:59:19 +0300 Mike Rapoport (Microsoft) wrote: > drivers/net/ethernet/broadcom/bnx2x/bnx2x_sp.c | 6 +-- > drivers/net/ethernet/intel/ice/ice_gnss.c | 5 +- > drivers/net/ethernet/sfc/mcdi.c | 7 +-- > drivers/net/ethernet/sfc/siena/mcdi.c | 7 +-- > drivers/net/wireless/broadcom/b43/debugfs.c | 12 ++--- > drivers/net/wireless/broadcom/b43legacy/debugfs.c | 11 ++-- > drivers/net/wireless/marvell/libertas/debugfs.c | 39 ++++++-------- > drivers/net/wireless/marvell/mwifiex/debugfs.c | 62 ++++++++++------------- > drivers/net/wireless/ti/wlcore/main.c | 14 +++-- You gotta split this, wireless and ethernet go via separate trees. BTW cocci also suggests folding in a memset, IDK if it's worth it. drivers/net/wireless/broadcom/b43legacy/debugfs.c:217:8-15: WARNING: kzalloc should be used for buf, instead of kmalloc/memset -- pw-bot: cr _______________________________________________ b43-dev mailing list b43-dev@lists.infradead.org http://lists.infradead.org/mailman/listinfo/b43-dev From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp1.osuosl.org (smtp1.osuosl.org [140.211.166.138]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 003B7C43458 for ; Tue, 30 Jun 2026 14:23:50 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id A5094826FF; Tue, 30 Jun 2026 14:23:50 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id JVj9-u-JHESn; Tue, 30 Jun 2026 14:23:50 +0000 (UTC) X-Comment: SPF check N/A for local connections - client-ip=140.211.166.142; helo=lists1.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org; receiver= DKIM-Filter: OpenDKIM Filter v2.11.0 smtp1.osuosl.org 28C9F827C5 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org; s=default; t=1782829430; bh=4Hhhr2XcfubTUcrvTbwWhwLy7CUCWTZEVOLPtuGC1E4=; h=Date:From:To:Cc:In-Reply-To:References:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=4Kkxd/Cxfipy0JWT57muylmo3F3QctH7+fhegBjrYqal68OoLACmg/bFe6wD7Ji5m XPYEr05xhDQpVmTTx878Iqq6To0RJVvhYng2jZ8cIxJDHqM45aaGjmvbrXeeiZPLHD gCVi3tjz5lKd0CAsHCWI6h1GKys0jnV0+nIAARpAogUmbTvEj1YYcWLQg3WINMHq3E YHm7Wl//+d8eAT8GmnnHSzFVgfRJ0oyknnIk6Mp3NNFt3lQcnURWCMt5n1p4QQWikg 2Yx2TelrMXF1a+lDGGwhJ99PD/hdCnG7anwehS5lGBqzx5X/g8TDA4ufJ0c+rkyX7g icD4lhlSnD9aQ== Received: from lists1.osuosl.org (lists1.osuosl.org [140.211.166.142]) by smtp1.osuosl.org (Postfix) with ESMTP id 28C9F827C5; Tue, 30 Jun 2026 14:23:50 +0000 (UTC) Received: from smtp1.osuosl.org (smtp1.osuosl.org [IPv6:2605:bc80:3010::138]) by lists1.osuosl.org (Postfix) with ESMTP id 4E945149 for ; Tue, 30 Jun 2026 14:23:48 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id 34458827C5 for ; Tue, 30 Jun 2026 14:23:48 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id NBw5PzDIwEqP for ; Tue, 30 Jun 2026 14:23:47 +0000 (UTC) Received-SPF: Pass (mailfrom) identity=mailfrom; client-ip=2600:3c04:e001:324:0:1991:8:25; helo=tor.source.kernel.org; envelope-from=kuba@kernel.org; receiver= DMARC-Filter: OpenDMARC Filter v1.4.2 smtp1.osuosl.org 8ECEB826FF DKIM-Filter: OpenDKIM Filter v2.11.0 smtp1.osuosl.org 8ECEB826FF Received: from tor.source.kernel.org (tor.source.kernel.org [IPv6:2600:3c04:e001:324:0:1991:8:25]) by smtp1.osuosl.org (Postfix) with ESMTPS id 8ECEB826FF for ; Tue, 30 Jun 2026 14:23:47 +0000 (UTC) Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by tor.source.kernel.org (Postfix) with ESMTP id B217B601DC; Tue, 30 Jun 2026 14:23:45 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id DE4E91F000E9; Tue, 30 Jun 2026 14:23:44 +0000 (UTC) Date: Tue, 30 Jun 2026 07:23:44 -0700 From: Jakub Kicinski To: "Mike Rapoport (Microsoft)" Cc: Andrew Lunn , "David S. Miller" , Eric Dumazet , Paolo Abeni , Brian Norris , Edward Cree , Francesco Dolcini , Manish Chopra , Przemek Kitszel , Sudarsana Kalluru , Tony Nguyen , b43-dev@lists.infradead.org, intel-wired-lan@lists.osuosl.org, libertas-dev@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-net-drivers@amd.com, linux-wireless@vger.kernel.org, netdev@vger.kernel.org Message-ID: <20260630072344.159b5d99@kernel.org> In-Reply-To: <20260630-b4-drivers-net-v1-0-672162a91f37@kernel.org> References: <20260630-b4-drivers-net-v1-0-672162a91f37@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1782829425; bh=4Hhhr2XcfubTUcrvTbwWhwLy7CUCWTZEVOLPtuGC1E4=; h=Date:From:To:Cc:Subject:In-Reply-To:References; b=FAKx/t6uR6e0YnXhUD4OAIvzCSGSFQqB0vFZUhEgy2dgiJnluy0duaFK6NLRYiwtu fVDfi6acLZR+l3CUXlY5hftQWt/eE24AJXi/lvEcSdMFqXuJ4frYnZ0itSCqWXgRpl NkxGX/Z1g2YgctN43YDAMXODPkhFFnXpPr67j43JUyr96RZ4YBioADsYLsm1iFUxvL kodoBEkjnvidKLPf8W0IWgLBeeikaJ/MwZ32d9NW2RcMvE5Z8DmTV/IfxrRD1LrLCw CIGyHDS/uvzs9a2YLUoQJ/+oG9AWfESzK2/RaL5bmBD/3DuJWQPM2GV+9y8JozF2SR aMsyqYRgaYGUQ== X-Mailman-Original-Authentication-Results: smtp1.osuosl.org; dmarc=pass (p=quarantine dis=none) header.from=kernel.org X-Mailman-Original-Authentication-Results: smtp1.osuosl.org; dkim=pass (2048-bit key, unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=FAKx/t6u Subject: Re: [Intel-wired-lan] [PATCH net-next 0/8] drivers/net: replace __get_free_pages() with kmalloc() X-BeenThere: intel-wired-lan@osuosl.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Intel Wired Ethernet Linux Kernel Driver Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-wired-lan-bounces@osuosl.org Sender: "Intel-wired-lan" On Tue, 30 Jun 2026 13:59:19 +0300 Mike Rapoport (Microsoft) wrote: > drivers/net/ethernet/broadcom/bnx2x/bnx2x_sp.c | 6 +-- > drivers/net/ethernet/intel/ice/ice_gnss.c | 5 +- > drivers/net/ethernet/sfc/mcdi.c | 7 +-- > drivers/net/ethernet/sfc/siena/mcdi.c | 7 +-- > drivers/net/wireless/broadcom/b43/debugfs.c | 12 ++--- > drivers/net/wireless/broadcom/b43legacy/debugfs.c | 11 ++-- > drivers/net/wireless/marvell/libertas/debugfs.c | 39 ++++++-------- > drivers/net/wireless/marvell/mwifiex/debugfs.c | 62 ++++++++++------------- > drivers/net/wireless/ti/wlcore/main.c | 14 +++-- You gotta split this, wireless and ethernet go via separate trees. BTW cocci also suggests folding in a memset, IDK if it's worth it. drivers/net/wireless/broadcom/b43legacy/debugfs.c:217:8-15: WARNING: kzalloc should be used for buf, instead of kmalloc/memset -- pw-bot: cr