From: David Laight <david.laight.linux@gmail.com>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: "Masami Hiramatsu" <mhiramat@kernel.org>,
"Mathieu Desnoyers" <mathieu.desnoyers@efficios.com>,
linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org,
"Michal Koutný" <mkoutny@suse.com>
Subject: Re: [PATCH 1/2] tracing: Embed 'char comm[16]' in a structure
Date: Tue, 30 Jun 2026 10:26:45 +0100 [thread overview]
Message-ID: <20260630102645.4457e47e@pumpkin> (raw)
In-Reply-To: <20260629162634.0327fa25@robin>
On Mon, 29 Jun 2026 16:26:34 -0400
Steven Rostedt <rostedt@goodmis.org> wrote:
> On Fri, 26 Jun 2026 22:23:55 +0100
> David Laight <david.laight.linux@gmail.com> wrote:
>
> \> --- a/kernel/trace/trace.c
> > +++ b/kernel/trace/trace.c
> > @@ -52,6 +52,7 @@
> > #include <linux/sort.h>
> > #include <linux/io.h> /* vmap_page_range() */
> > #include <linux/fs_context.h>
> > +#include <linux/trace_printk.h>
>
> Left over debugging? ;-)
Possibly from a build where I'd taken it out of kernel.h.
I think this file needs that header from somewhere.
Probably for the prototypes for tracing_on() etc.
It really ought to have an explicit include rather than relying on
a 'proxy' include.
I did resolve a lot of those include issues by putting it into the
main trace headers (which is big an non-trivial).
David
>
> -- Steve
next prev parent reply other threads:[~2026-06-30 9:26 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-26 21:23 [PATCH rfc 0/2] Improvements to ftrace comm[] handling David Laight
2026-06-26 21:23 ` [PATCH 1/2] tracing: Embed 'char comm[16]' in a structure David Laight
2026-06-29 20:26 ` Steven Rostedt
2026-06-30 9:26 ` David Laight [this message]
2026-06-26 21:23 ` [PATCH 2/2] tracing: Keep pid and comm[] in the same structure David Laight
2026-06-29 20:49 ` Steven Rostedt
2026-06-30 10:01 ` David Laight
2026-06-30 19:03 ` Steven Rostedt
2026-07-01 10:04 ` David Laight
2026-07-01 10:38 ` Steven Rostedt
2026-07-01 12:04 ` David Laight
2026-07-01 12:23 ` Steven Rostedt
2026-07-01 16:52 ` David Laight
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260630102645.4457e47e@pumpkin \
--to=david.laight.linux@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=mathieu.desnoyers@efficios.com \
--cc=mhiramat@kernel.org \
--cc=mkoutny@suse.com \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.