From: Huiwen He <huiwen.he@linux.dev>
To: smfrench@gmail.com, linkinjeon@kernel.org, pc@manguebit.org,
ronniesahlberg@gmail.com, sprasad@microsoft.com, tom@talpey.com,
bharathsm@microsoft.com, senozhatsky@chromium.org,
dhowells@redhat.com, metze@samba.org, chenxiaosong@kylinos.cn
Cc: linux-cifs@vger.kernel.org
Subject: [PATCH v5 0/4] smb/client: fix fallocate and allocation accounting
Date: Tue, 30 Jun 2026 18:40:06 +0800 [thread overview]
Message-ID: <20260630104010.571140-1-huiwen.he@linux.dev> (raw)
From: Huiwen He <hehuiwen@kylinos.cn>
Changes in v5:
- Update patch 1 commit message to mention the generic/370 regression fix.
- Update patch 3 commit message to clarify the small EOF-extending mode 0
fallocate case.
- Rework patch 4 to refresh AllocationSize after SetEOF instead of failing
when AllocationSize does not grow, preserving compatibility with Samba
"strict allocate = no" for requests such as "falloc 0 5M". This makes
generic/496 and generic/701 pass on ksmbd.
- Drop the overlapping allocated ranges patch. It was a Sashiko review
cleanup suggestion, not a fix for a reproducible Samba or ksmbd failure.
The following patches from v4 are dropped in v5:
- smb/client: handle smb2_set_sparse() failure in EOF-extending fallocate
- smb/client: handle smb2_set_sparse() failure in non-extending fallocate
- smb/client: handle overlapping allocated ranges in fallocate
The following patches are already in upstream and are not resent:
- smb/client: name the default fallocate mode
- smb/client: preserve errors from smb2_set_sparse()
- smb/client: do not account EOF extension as allocation
Link to v4:
https://lore.kernel.org/linux-cifs/20260626134719.158270-1-huiwen.he@linux.dev
Thanks,
Huiwen
Huiwen He (4):
smb/client: refresh allocation size after duplicate extents
smb/client: reduce fallocate zero buffer allocation
smb/client: emulate small EOF-extending mode 0 fallocate ranges
smb/client: refresh allocation after EOF-extending fallocate
fs/smb/client/smb2ops.c | 128 +++++++++++++++++++++++++++++++++++---
fs/smb/client/smb2pdu.c | 19 ++++++
fs/smb/client/smb2proto.h | 3 +
fs/smb/common/fscc.h | 5 ++
fs/smb/server/smb2pdu.h | 4 --
5 files changed, 146 insertions(+), 13 deletions(-)
--
2.43.0
next reply other threads:[~2026-06-30 10:41 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-30 10:40 Huiwen He [this message]
2026-06-30 10:40 ` [PATCH v5 1/4] smb/client: refresh allocation size after duplicate extents Huiwen He
2026-06-30 10:40 ` [PATCH v5 2/4] smb/client: reduce fallocate zero buffer allocation Huiwen He
2026-06-30 10:40 ` [PATCH v5 3/4] smb/client: emulate small EOF-extending mode 0 fallocate ranges Huiwen He
2026-06-30 10:40 ` [PATCH v5 4/4] smb/client: refresh allocation after EOF-extending fallocate Huiwen He
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260630104010.571140-1-huiwen.he@linux.dev \
--to=huiwen.he@linux.dev \
--cc=bharathsm@microsoft.com \
--cc=chenxiaosong@kylinos.cn \
--cc=dhowells@redhat.com \
--cc=linkinjeon@kernel.org \
--cc=linux-cifs@vger.kernel.org \
--cc=metze@samba.org \
--cc=pc@manguebit.org \
--cc=ronniesahlberg@gmail.com \
--cc=senozhatsky@chromium.org \
--cc=smfrench@gmail.com \
--cc=sprasad@microsoft.com \
--cc=tom@talpey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.