From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F337141C2F0; Tue, 30 Jun 2026 13:28:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782826115; cv=none; b=tEEcrbiAOE9KGSdONPbkNgVZAO+ZS3hfm63b7L5sWot7+DwM8DDsLcND29E1/lv1o9qRtMAlhlOXceyCaICV1d3I2RxH3n6qnJDN1ToQjPcr9+EChEEO77vGgJ9ORKTE7aM+mz6oYGJfA6JF0iwH7CIzpX2N6TEnk9egf+J/dSg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782826115; c=relaxed/simple; bh=e50i/t+otz1MUxjpLg0k+QVIsU/EiHcY8BOMbSdt3oM=; h=From:Subject:To:Cc:In-Reply-To:References:Content-Type:Date: Message-Id; b=evbG2Qoc/c6Q63RRa4RcT+94r+E9LT1jpk4Z7L+JJ0Gug3rM4aU9Ltv2yqPTjeTpTZqqFrkUDB2enofkIqEm0Ql/FgJv6cBgLKD6vfZ+6VJi7ZVIoM9eXoiUff2OVNh7u7qVDElKtkBUcbdZIVfiXe+qZ01q6RsCQ7fhIexpabk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=Gb3wrXA1; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="Gb3wrXA1" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 450051F00A3A; Tue, 30 Jun 2026 13:28:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1782826113; bh=+FAD0oKS3SeQ82yLrtXGWjS6Gjvd3EoOnAU9Vn3DKCA=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=Gb3wrXA1wKlOsU4o5YpskKf7EaW/7Z5k4ogtGGTCHbKvSWIXMdTWcQ47xRXvmAuSV ekA7zkyWW3SYG9AWBvQ0lL8tIAvV3r5t00rg95fP6gXHpoSPh8s6UiAIxJAgkHk59q furj2i8HbcsnchP5GMCI+RxfNR3SrJUUF6oArUfYjFaWgoyL00Aad9wd582f9AY1vO IxTj3TLbFkvdB+432Xbn2vr3xf4klRgcrVletBnYDj7dHdXtQIUq+iXwlpnuK2PYuz 6mLzSBSukM8pXEveX79W+u6HVQFoc6Tg3/OaCYPmlyZ1GJ4HwKnE0VYM+OZ2PmOzEP sW4009xsEb+7A== From: sashiko-bot@kernel.org Subject: Re: [PATCH 08/13] pcmcia: replace linux/gpio.h inclusions Reply-To: sashiko-reviews@lists.linux.dev To: "Arnd Bergmann" Cc: olteanv@gmail.com, linux-phy@lists.infradead.org, linux-sunxi@lists.linux.dev, vkoul@kernel.org, dmitry.torokhov@gmail.com, linux-input@vger.kernel.org, neil.armstrong@linaro.org In-Reply-To: <20260629132633.1300009-9-arnd@kernel.org> References: <20260629132633.1300009-1-arnd@kernel.org> <20260629132633.1300009-9-arnd@kernel.org> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Tue, 30 Jun 2026 13:28:32 +0000 Message-Id: <20260630132833.450051F00A3A@smtp.kernel.org> Precedence: bulk X-Mailing-List: linux-sunxi@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: Thank you for your contribution! Sashiko AI review found 1 potential issue(= s) to consider: Pre-existing issues: - [High] Invalid resource cleanup on error path leading to potential double= -free of a devres-managed GPIO descriptor. -- commit a1a20647914d78d6a15655dea889e9d53c734136 Author: Arnd Bergmann pcmcia: replace linux/gpio.h inclusions The pcmcia drivers all use the legacy interfaces, so convert to include linux/gpio/legacy.h instead. Signed-off-by: Arnd Bergmann [ ... ] > diff --git a/drivers/pcmcia/sa1100_h3600.c b/drivers/pcmcia/sa1100_h3600.c > index 10cb99c20a7f5..6c52d90795eb4 100644 > --- a/drivers/pcmcia/sa1100_h3600.c > +++ b/drivers/pcmcia/sa1100_h3600.c > @@ -11,7 +11,7 @@ > #include > #include > #include > -#include > +#include [Severity: High] This isn't a bug introduced by this patch, but I noticed a pre-existing issue while reviewing the GPIO include changes. Does the error path in h3600_pcmcia_hw_init() cause a double-free of a devres-managed GPIO descriptor? If gpio_request(H3XXX_EGPIO_OPT_NVRAM_ON) or subsequent legacy GPIO requests fail, the code jumps to or falls through to the err01 label: drivers/pcmcia/sa1100_h3600.c:h3600_pcmcia_hw_init() { ... err06: gpio_free(H3XXX_EGPIO_CARD_RESET); err05: gpio_free(H3XXX_EGPIO_OPT_RESET); err04: gpio_free(H3XXX_EGPIO_OPT_ON); err03: gpio_free(H3XXX_EGPIO_OPT_NVRAM_ON); err01: gpio_free(H3XXX_GPIO_PCMCIA_IRQ0); return err; } The err01 label incorrectly frees H3XXX_GPIO_PCMCIA_IRQ0. This GPIO is managed by devres and was not explicitly requested using gpio_request() in this function.=20 When devres cleans up the failed probe, it will attempt to free the GPIO again. This could lead to a double-free, gpiolib state corruption, kernel warnings, or accidentally freeing a GPIO acquired by a concurrent driver. --=20 Sashiko AI review =C2=B7 https://sashiko.dev/#/patchset/20260629132633.1300= 009-1-arnd@kernel.org?part=3D8 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6FEEEC43458 for ; Tue, 30 Jun 2026 13:28:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Reply-To:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:Message-Id:Date: References:In-Reply-To:Cc:To:Subject:From:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=1vohUaOuJ5zb53HYWZCkjOQBJfzPchITjekMS5qYOqA=; b=tLb2Qh9rxRn+o1 dDeI+74rkTwOdtjo3vfU0yrAIlKpxFRO+wA4rjdb84LOkXAkqGY9xQ4x/836dpMpADBOyTx6nmtrv bO07wk9z2B4zPQ/fImWGPkpE/DSNwlaor99dmqmuj7acpUVHg1PV6DUQ5pQi2MOlDwvt5VtpUKiHK PjjV3Ak+pAB5mG9XtalwUpyl0AyoVPK5lY+5489iwwhKvgUy4R5QOCXohV3m58/X8u2p7RGLMilP3 9Gwah+CWlr9FXNEfdti37fy6XhKvIn17jHpqH92akoinD+W19a1J7606G3OSELCtsqNhWc9ziEqI9 w4GHbvqqmDxvy2zn7x/w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1weYVx-0000000HA91-0b5C; Tue, 30 Jun 2026 13:28:37 +0000 Received: from tor.source.kernel.org ([172.105.4.254]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1weYVu-0000000HA7s-28pu for linux-phy@lists.infradead.org; Tue, 30 Jun 2026 13:28:34 +0000 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by tor.source.kernel.org (Postfix) with ESMTP id EE6EB601DC; Tue, 30 Jun 2026 13:28:33 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 450051F00A3A; Tue, 30 Jun 2026 13:28:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1782826113; bh=+FAD0oKS3SeQ82yLrtXGWjS6Gjvd3EoOnAU9Vn3DKCA=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=Gb3wrXA1wKlOsU4o5YpskKf7EaW/7Z5k4ogtGGTCHbKvSWIXMdTWcQ47xRXvmAuSV ekA7zkyWW3SYG9AWBvQ0lL8tIAvV3r5t00rg95fP6gXHpoSPh8s6UiAIxJAgkHk59q furj2i8HbcsnchP5GMCI+RxfNR3SrJUUF6oArUfYjFaWgoyL00Aad9wd582f9AY1vO IxTj3TLbFkvdB+432Xbn2vr3xf4klRgcrVletBnYDj7dHdXtQIUq+iXwlpnuK2PYuz 6mLzSBSukM8pXEveX79W+u6HVQFoc6Tg3/OaCYPmlyZ1GJ4HwKnE0VYM+OZ2PmOzEP sW4009xsEb+7A== From: sashiko-bot@kernel.org Subject: Re: [PATCH 08/13] pcmcia: replace linux/gpio.h inclusions To: "Arnd Bergmann" Cc: olteanv@gmail.com, linux-phy@lists.infradead.org, linux-sunxi@lists.linux.dev, vkoul@kernel.org, dmitry.torokhov@gmail.com, linux-input@vger.kernel.org, neil.armstrong@linaro.org In-Reply-To: <20260629132633.1300009-9-arnd@kernel.org> References: <20260629132633.1300009-1-arnd@kernel.org> <20260629132633.1300009-9-arnd@kernel.org> Date: Tue, 30 Jun 2026 13:28:32 +0000 Message-Id: <20260630132833.450051F00A3A@smtp.kernel.org> X-BeenThere: linux-phy@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux Phy Mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: sashiko-reviews@lists.linux.dev MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-phy" Errors-To: linux-phy-bounces+linux-phy=archiver.kernel.org@lists.infradead.org VGhhbmsgeW91IGZvciB5b3VyIGNvbnRyaWJ1dGlvbiEgU2FzaGlrbyBBSSByZXZpZXcgZm91bmQg MSBwb3RlbnRpYWwgaXNzdWUocykgdG8gY29uc2lkZXI6CgpQcmUtZXhpc3RpbmcgaXNzdWVzOgot IFtIaWdoXSBJbnZhbGlkIHJlc291cmNlIGNsZWFudXAgb24gZXJyb3IgcGF0aCBsZWFkaW5nIHRv IHBvdGVudGlhbCBkb3VibGUtZnJlZSBvZiBhIGRldnJlcy1tYW5hZ2VkIEdQSU8gZGVzY3JpcHRv ci4KLS0KCmNvbW1pdCBhMWEyMDY0NzkxNGQ3OGQ2YTE1NjU1ZGVhODg5ZTlkNTNjNzM0MTM2CkF1 dGhvcjogQXJuZCBCZXJnbWFubiA8YXJuZEBhcm5kYi5kZT4KCnBjbWNpYTogcmVwbGFjZSBsaW51 eC9ncGlvLmggaW5jbHVzaW9ucwoKVGhlIHBjbWNpYSBkcml2ZXJzIGFsbCB1c2UgdGhlIGxlZ2Fj eSBpbnRlcmZhY2VzLCBzbyBjb252ZXJ0IHRvCmluY2x1ZGUgbGludXgvZ3Bpby9sZWdhY3kuaCBp bnN0ZWFkLgoKU2lnbmVkLW9mZi1ieTogQXJuZCBCZXJnbWFubiA8YXJuZEBhcm5kYi5kZT4KClsg Li4uIF0KCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvcGNtY2lhL3NhMTEwMF9oMzYwMC5jIGIvZHJp dmVycy9wY21jaWEvc2ExMTAwX2gzNjAwLmMKPiBpbmRleCAxMGNiOTljMjBhN2Y1Li42YzUyZDkw Nzk1ZWI0IDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvcGNtY2lhL3NhMTEwMF9oMzYwMC5jCj4gKysr IGIvZHJpdmVycy9wY21jaWEvc2ExMTAwX2gzNjAwLmMKPiBAQCAtMTEsNyArMTEsNyBAQAo+ICAj aW5jbHVkZSA8bGludXgvaW50ZXJydXB0Lmg+Cj4gICNpbmNsdWRlIDxsaW51eC9pbml0Lmg+Cj4g ICNpbmNsdWRlIDxsaW51eC9kZWxheS5oPgo+IC0jaW5jbHVkZSA8bGludXgvZ3Bpby5oPgo+ICsj aW5jbHVkZSA8bGludXgvZ3Bpby9sZWdhY3kuaD4KCltTZXZlcml0eTogSGlnaF0KVGhpcyBpc24n dCBhIGJ1ZyBpbnRyb2R1Y2VkIGJ5IHRoaXMgcGF0Y2gsIGJ1dCBJIG5vdGljZWQgYSBwcmUtZXhp c3RpbmcKaXNzdWUgd2hpbGUgcmV2aWV3aW5nIHRoZSBHUElPIGluY2x1ZGUgY2hhbmdlcy4KCkRv ZXMgdGhlIGVycm9yIHBhdGggaW4gaDM2MDBfcGNtY2lhX2h3X2luaXQoKSBjYXVzZSBhIGRvdWJs ZS1mcmVlIG9mIGEKZGV2cmVzLW1hbmFnZWQgR1BJTyBkZXNjcmlwdG9yPwoKSWYgZ3Bpb19yZXF1 ZXN0KEgzWFhYX0VHUElPX09QVF9OVlJBTV9PTikgb3Igc3Vic2VxdWVudCBsZWdhY3kgR1BJTyBy ZXF1ZXN0cwpmYWlsLCB0aGUgY29kZSBqdW1wcyB0byBvciBmYWxscyB0aHJvdWdoIHRvIHRoZSBl cnIwMSBsYWJlbDoKCmRyaXZlcnMvcGNtY2lhL3NhMTEwMF9oMzYwMC5jOmgzNjAwX3BjbWNpYV9o d19pbml0KCkgewogICAgLi4uCmVycjA2OiAgZ3Bpb19mcmVlKEgzWFhYX0VHUElPX0NBUkRfUkVT RVQpOwplcnIwNTogIGdwaW9fZnJlZShIM1hYWF9FR1BJT19PUFRfUkVTRVQpOwplcnIwNDogIGdw aW9fZnJlZShIM1hYWF9FR1BJT19PUFRfT04pOwplcnIwMzogIGdwaW9fZnJlZShIM1hYWF9FR1BJ T19PUFRfTlZSQU1fT04pOwplcnIwMTogIGdwaW9fZnJlZShIM1hYWF9HUElPX1BDTUNJQV9JUlEw KTsKICAgICAgICByZXR1cm4gZXJyOwp9CgpUaGUgZXJyMDEgbGFiZWwgaW5jb3JyZWN0bHkgZnJl ZXMgSDNYWFhfR1BJT19QQ01DSUFfSVJRMC4gVGhpcyBHUElPIGlzCm1hbmFnZWQgYnkgZGV2cmVz IGFuZCB3YXMgbm90IGV4cGxpY2l0bHkgcmVxdWVzdGVkIHVzaW5nIGdwaW9fcmVxdWVzdCgpIGlu CnRoaXMgZnVuY3Rpb24uIAoKV2hlbiBkZXZyZXMgY2xlYW5zIHVwIHRoZSBmYWlsZWQgcHJvYmUs IGl0IHdpbGwgYXR0ZW1wdCB0byBmcmVlIHRoZSBHUElPCmFnYWluLiBUaGlzIGNvdWxkIGxlYWQg dG8gYSBkb3VibGUtZnJlZSwgZ3Bpb2xpYiBzdGF0ZSBjb3JydXB0aW9uLCBrZXJuZWwKd2Fybmlu Z3MsIG9yIGFjY2lkZW50YWxseSBmcmVlaW5nIGEgR1BJTyBhY3F1aXJlZCBieSBhIGNvbmN1cnJl bnQgZHJpdmVyLgoKLS0gClNhc2hpa28gQUkgcmV2aWV3IMK3IGh0dHBzOi8vc2FzaGlrby5kZXYv Iy9wYXRjaHNldC8yMDI2MDYyOTEzMjYzMy4xMzAwMDA5LTEtYXJuZEBrZXJuZWwub3JnP3BhcnQ9 OAoKLS0gCmxpbnV4LXBoeSBtYWlsaW5nIGxpc3QKbGludXgtcGh5QGxpc3RzLmluZnJhZGVhZC5v cmcKaHR0cHM6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtcGh5 Cg==