From: Bin Meng <bin.meng@processmission.com>
To: QEMU <qemu-devel@nongnu.org>
Cc: "Alistair Francis" <alistair@alistair23.me>,
"Andrew Jeffery" <andrew@codeconstruct.com.au>,
"Cédric Le Goater" <clg@kaod.org>,
"Jamin Lin" <jamin_lin@aspeedtech.com>,
"Joel Stanley" <joel@jms.id.au>,
"Kane Chen" <kane_chen@aspeedtech.com>,
"Peter Maydell" <peter.maydell@linaro.org>,
"Steven Lee" <steven_lee@aspeedtech.com>,
"Troy Lee" <leetroy@gmail.com>,
qemu-arm@nongnu.org
Subject: [PATCH 08/10] Revert "aspeed/smc: Fix number of dummy cycles for FAST_READ_4 command"
Date: Tue, 30 Jun 2026 21:57:27 +0800 [thread overview]
Message-ID: <20260630135729.466264-9-bin.meng@processmission.com> (raw)
In-Reply-To: <20260630135729.466264-1-bin.meng@processmission.com>
This reverts commit 7faf6f1790dddf9f3acf6ddd95f7bbc1b4a755d0.
The incorrect implementation of dummy cycles in m25p80 model is now
corrected. Revert this commit.
Signed-off-by: Bin Meng <bin.meng@processmission.com>
---
hw/ssi/aspeed_smc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/ssi/aspeed_smc.c b/hw/ssi/aspeed_smc.c
index f5abc9fcc9..c2a732664b 100644
--- a/hw/ssi/aspeed_smc.c
+++ b/hw/ssi/aspeed_smc.c
@@ -568,11 +568,11 @@ static int aspeed_smc_num_dummies(uint8_t command)
case FAST_READ:
case DOR:
case QOR:
- case FAST_READ_4:
case DOR_4:
case QOR_4:
return 1;
case DIOR:
+ case FAST_READ_4:
case DIOR_4:
return 2;
case QIOR:
--
2.34.1
next prev parent reply other threads:[~2026-06-30 13:59 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-30 13:57 [PATCH 00/10] hw/{block,ssi}: Fix spi-nor flash dummy byte handling Bin Meng
2026-06-30 13:57 ` [PATCH 01/10] hw/block: m25p80: Fix dummy byte handling for Winbond flash Bin Meng
2026-07-06 7:48 ` Philippe Mathieu-Daudé
2026-07-06 16:54 ` Bin Meng
2026-06-30 13:57 ` [PATCH 02/10] hw/block: m25p80: Fix dummy byte handling for Numonyx/Micron flash Bin Meng
2026-06-30 13:57 ` [PATCH 03/10] hw/block: m25p80: Fix dummy byte handling for Macronix flash Bin Meng
2026-07-06 7:52 ` Philippe Mathieu-Daudé
2026-06-30 13:57 ` [PATCH 04/10] hw/block: m25p80: Fix dummy byte handling for Spansion flash Bin Meng
2026-06-30 13:57 ` [PATCH 05/10] hw/ssi: npcm7xx_fiu: Correct the dummy cycle emulation logic Bin Meng
2026-06-30 13:57 ` [PATCH 06/10] hw/ssi: xilinx_spips: Fix dummy phase handling Bin Meng
2026-07-06 8:10 ` Philippe Mathieu-Daudé
2026-07-06 17:27 ` Bin Meng
2026-06-30 13:57 ` [PATCH 07/10] hw/ssi: aspeed_smc: Fix direct-read dummy bytes Bin Meng
2026-06-30 14:45 ` Cédric Le Goater
2026-06-30 13:57 ` Bin Meng [this message]
2026-06-30 14:45 ` [PATCH 08/10] Revert "aspeed/smc: Fix number of dummy cycles for FAST_READ_4 command" Cédric Le Goater
2026-06-30 13:57 ` [PATCH 09/10] Revert "aspeed/smc: snoop SPI transfers to fake dummy cycles" Bin Meng
2026-06-30 14:46 ` Cédric Le Goater
2026-06-30 13:57 ` [PATCH 10/10] docs/devel: Document SSI dummy-cycle ownership Bin Meng
2026-07-06 8:13 ` Philippe Mathieu-Daudé
2026-06-30 14:45 ` [PATCH 00/10] hw/{block,ssi}: Fix spi-nor flash dummy byte handling Cédric Le Goater
2026-07-06 7:13 ` Cédric Le Goater
2026-07-06 8:19 ` Philippe Mathieu-Daudé
2026-07-06 8:40 ` Cédric Le Goater
2026-07-06 9:58 ` Philippe Mathieu-Daudé
2026-07-06 10:26 ` Cédric Le Goater
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260630135729.466264-9-bin.meng@processmission.com \
--to=bin.meng@processmission.com \
--cc=alistair@alistair23.me \
--cc=andrew@codeconstruct.com.au \
--cc=clg@kaod.org \
--cc=jamin_lin@aspeedtech.com \
--cc=joel@jms.id.au \
--cc=kane_chen@aspeedtech.com \
--cc=leetroy@gmail.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=steven_lee@aspeedtech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.