From: kernel test robot <lkp@intel.com>
To: Iker Pedrosa <ikerpedrosam@gmail.com>
Cc: oe-kbuild-all@lists.linux.dev, linux-kernel@vger.kernel.org,
Javier Martinez Canillas <javierm@redhat.com>,
Thomas Zimmermann <tzimmermann@suse.de>
Subject: drivers/gpu/drm/solomon/ssd130x.c:1011:5-8: Unneeded variable: "ret". Return "0" on line 1024
Date: Tue, 30 Jun 2026 14:35:14 +0800 [thread overview]
Message-ID: <202606301409.I0ctsf41-lkp@intel.com> (raw)
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: dc59e4fea9d83f03bad6bddf3fa2e52491777482
commit: 2258f03989afb66087538a5d6d56c18ef6532b07 drm/solomon: Move calls to drm_gem_fb_end_cpu*()
date: 9 months ago
config: parisc-randconfig-r063-20260630 (https://download.01.org/0day-ci/archive/20260630/202606301409.I0ctsf41-lkp@intel.com/config)
compiler: hppa-linux-gcc (GCC) 15.2.0
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Fixes: 2258f03989af ("drm/solomon: Move calls to drm_gem_fb_end_cpu*()")
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202606301409.I0ctsf41-lkp@intel.com/
cocci warnings: (new ones prefixed by >>)
>> drivers/gpu/drm/solomon/ssd130x.c:1011:5-8: Unneeded variable: "ret". Return "0" on line 1024
drivers/gpu/drm/solomon/ssd130x.c:1036:5-8: Unneeded variable: "ret". Return "0" on line 1050
vim +1011 drivers/gpu/drm/solomon/ssd130x.c
b4299c936d8fd6 Javier Martinez Canillas 2023-12-29 1001
d51f9fbd98b6d8 Javier Martinez Canillas 2023-09-13 1002 static int ssd130x_fb_blit_rect(struct drm_framebuffer *fb,
45b58669e532bc Javier Martinez Canillas 2023-07-26 1003 const struct iosys_map *vmap,
d51f9fbd98b6d8 Javier Martinez Canillas 2023-09-13 1004 struct drm_rect *rect,
4cd24d4b1a9548 Thomas Zimmermann 2023-10-09 1005 u8 *buf, u8 *data_array,
4cd24d4b1a9548 Thomas Zimmermann 2023-10-09 1006 struct drm_format_conv_state *fmtcnv_state)
a61732e808672c Javier Martinez Canillas 2022-02-14 1007 {
a61732e808672c Javier Martinez Canillas 2022-02-14 1008 struct ssd130x_device *ssd130x = drm_to_ssd130x(fb->dev);
b3aca563d69bcb Thomas Zimmermann 2022-08-08 1009 struct iosys_map dst;
4442ac1af10442 Geert Uytterhoeven 2022-03-17 1010 unsigned int dst_pitch;
a61732e808672c Javier Martinez Canillas 2022-02-14 @1011 int ret = 0;
a61732e808672c Javier Martinez Canillas 2022-02-14 1012
a97e753fd358e2 Geert Uytterhoeven 2022-03-17 1013 /* Align y to display page boundaries */
ec5dceb8180f0c Javier Martinez Canillas 2023-10-14 1014 rect->y1 = round_down(rect->y1, SSD130X_PAGE_HEIGHT);
ec5dceb8180f0c Javier Martinez Canillas 2023-10-14 1015 rect->y2 = min_t(unsigned int, round_up(rect->y2, SSD130X_PAGE_HEIGHT), ssd130x->height);
a97e753fd358e2 Geert Uytterhoeven 2022-03-17 1016
27564c61ab1dbd Geert Uytterhoeven 2023-07-13 1017 dst_pitch = DIV_ROUND_UP(drm_rect_width(rect), 8);
a61732e808672c Javier Martinez Canillas 2022-02-14 1018
b3aca563d69bcb Thomas Zimmermann 2022-08-08 1019 iosys_map_set_vaddr(&dst, buf);
4cd24d4b1a9548 Thomas Zimmermann 2023-10-09 1020 drm_fb_xrgb8888_to_mono(&dst, &dst_pitch, vmap, fb, rect, fmtcnv_state);
a61732e808672c Javier Martinez Canillas 2022-02-14 1021
d51f9fbd98b6d8 Javier Martinez Canillas 2023-09-13 1022 ssd130x_update_rect(ssd130x, rect, buf, data_array);
a61732e808672c Javier Martinez Canillas 2022-02-14 1023
a61732e808672c Javier Martinez Canillas 2022-02-14 @1024 return ret;
a61732e808672c Javier Martinez Canillas 2022-02-14 1025 }
a61732e808672c Javier Martinez Canillas 2022-02-14 1026
:::::: The code at line 1011 was first introduced by commit
:::::: a61732e808672cfa8c8c6028bcf9feacb953ef40 drm: Add driver for Solomon SSD130x OLED displays
:::::: TO: Javier Martinez Canillas <javierm@redhat.com>
:::::: CC: Javier Martinez Canillas <javierm@redhat.com>
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
reply other threads:[~2026-06-30 6:35 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202606301409.I0ctsf41-lkp@intel.com \
--to=lkp@intel.com \
--cc=ikerpedrosam@gmail.com \
--cc=javierm@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=oe-kbuild-all@lists.linux.dev \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.