From: sashiko-bot@kernel.org
To: "Julian Braha" <julianbraha@gmail.com>
Cc: linux-input@vger.kernel.org, dmitry.torokhov@gmail.com
Subject: Re: [PATCH v2] HID: cleanup help indentation in kconfig
Date: Tue, 30 Jun 2026 15:10:04 +0000 [thread overview]
Message-ID: <20260630151004.C32C41F000E9@smtp.kernel.org> (raw)
In-Reply-To: <20260630150134.514348-1-julianbraha@gmail.com>
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The help text for HID_VRC2 is incorrectly indented with 6 spaces instead of the standard Kconfig indentation.
--
commit 175ea4114d8a3fc5eba72e7a349e9cf65a9b45bd
Author: Julian Braha <julianbraha@gmail.com>
HID: cleanup help indentation in kconfig
This commit standardizes the indentation of help text across the HID Kconfig
file to use 2 spaces, resolving inconsistencies where some texts were not
indented at all.
> diff --git a/drivers/hid/Kconfig b/drivers/hid/Kconfig
> --- a/drivers/hid/Kconfig
> +++ b/drivers/hid/Kconfig
[ ... ]
> @@ -530,11 +530,11 @@ config HID_VRC2
> tristate "VRC-2 Car Controller"
> depends on HID
> help
> - Support for VRC-2 which is a 2-axis controller often used in
> - car simulators.
> + Support for VRC-2 which is a 2-axis controller often used in
> + car simulators.
[Severity: Low]
This isn't a bug, but did the indentation for HID_VRC2 accidentally get set
to 6 spaces here? The standard Kconfig convention expects 1 tab plus 2 spaces,
but this new text appears to be indented less than the help keyword itself,
which contrasts with the commit's stated goal of standardizing indentation.
>
> - To compile this driver as a module, choose M here: the
> - module will be called hid-vrc2.
> + To compile this driver as a module, choose M here: the
> + module will be called hid-vrc2.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260630150134.514348-1-julianbraha@gmail.com?part=1
prev parent reply other threads:[~2026-06-30 15:10 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-30 15:01 [PATCH v2] HID: cleanup help indentation in kconfig Julian Braha
2026-06-30 15:10 ` sashiko-bot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260630151004.C32C41F000E9@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=julianbraha@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.