Re: [PATCH] arm64: dts: ti: Rename DM firmware reserved memory nodes

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] Incomplete refactoring of DM firmware reserved memory nodes, missing k3-am654-base-board and the entire AM64x family.
--

commit 8c190c8bbecf4c9714e791b5c5c8d1f70710854f
Author: Paresh Bhagat <p-bhagat@ti.com>

arm64: dts: ti: Rename DM firmware reserved memory nodes

Rename DM reserved memory nodes for K3 devices.
This allows U-Boot to identify and resize these regions using
fdt_fixup_reserved_memory() as done for TFA and optee.
Also drop unnecessary bootph-pre-ram property from AM62D2.

> diff --git a/arch/arm64/boot/dts/ti/k3-am65-iot2050-common.dtsi b/arch/arm64/boot/dts/ti/k3-am65-iot2050-common.dtsi
> index f3ee73e64d69c..78b4e5d61dfc2 100644
> --- a/arch/arm64/boot/dts/ti/k3-am65-iot2050-common.dtsi
> +++ b/arch/arm64/boot/dts/ti/k3-am65-iot2050-common.dtsi
> @@ -53,7 +53,7 @@ mcu_r5fss0_core0_dma_memory_region: memory@a0000000 {
>  			no-map;
>  		};
>  
> -		mcu_r5fss0_core0_memory_region: memory@a0100000 {
> +		mcu_r5fss0_core0_memory_region: dm@a0100000 {
>  			compatible = "shared-dma-pool";
>  			reg = <0 0xa0100000 0 0xf00000>;
>  			no-map;

[Severity: Medium]
Were some K3 devices missed in this refactoring?

This patch renames DM reserved memory nodes so U-Boot can locate and resize
them, but it appears to miss k3-am654-base-board.dts, which still retains the
old naming convention:

arch/arm64/boot/dts/ti/k3-am654-base-board.dts:
        mcu_r5fss0_core0_memory_region: memory@a0100000 {
                compatible = "shared-dma-pool";
                reg = <0 0xa0100000 0 0xf00000>;
                no-map;
        };

Additionally, the AM64x family appears to be omitted entirely, as they use
main_r5fss0_core0 for DM instead of wkup or mcu. For example:

arch/arm64/boot/dts/ti/k3-am642-evm.dts:
        main_r5fss0_core0_memory_region: memory@a0100000 {
                compatible = "shared-dma-pool";
                reg = <0x00 0xa0100000 0x00 0xf00000>;
                no-map;
        };

Will U-Boot silently skip resizing the DM memory regions on these unpatched
boards, potentially leading to incorrectly sized regions during boot?

[ ... ]

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260630150919.457160-1-p-bhagat@ti.com?part=1