From: sashiko-bot@kernel.org
To: "Yuho Choi" <dbgh9129@gmail.com>
Cc: linux-pci@vger.kernel.org
Subject: Re: [PATCH v1] PCI: xgene: Drop unnecessary OF node reference
Date: Tue, 30 Jun 2026 20:00:36 +0000 [thread overview]
Message-ID: <20260630200036.E20A91F000E9@smtp.kernel.org> (raw)
In-Reply-To: <20260630195234.1871951-1-dbgh9129@gmail.com>
> xgene_pcie_probe() stores dev->of_node in port->node with
> of_node_get(), but the cached node is only used during probe by
> xgene_pcie_parse_map_dma_ranges(). The driver never releases the extra
> reference, so the node reference is leaked.
>
> There is no need for private OF node ownership here. Use the device's
> existing of_node directly in xgene_pcie_parse_map_dma_ranges() and remove
> the cached port->node pointer.
>
> Fixes: 5f6b6ccdbe1c ("PCI: xgene: Add APM X-Gene PCIe driver")
> Signed-off-by: Yuho Choi <dbgh9129@gmail.com>
Sashiko has reviewed this patch and found no issues. It looks great!
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260630195234.1871951-1-dbgh9129@gmail.com?part=1
prev parent reply other threads:[~2026-06-30 20:00 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-30 19:52 [PATCH v1] PCI: xgene: Drop unnecessary OF node reference Yuho Choi
2026-06-30 20:00 ` sashiko-bot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260630200036.E20A91F000E9@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=dbgh9129@gmail.com \
--cc=linux-pci@vger.kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.