All of lore.kernel.org
 help / color / mirror / Atom feed
From: Denys Dmytriyenko <denis@denix.org>
To: a-christidis@ti.com
Cc: reatmon@ti.com, denys@konsulko.com, afd@ti.com,
	meta-ti@lists.yoctoproject.org
Subject: Re: [meta-ti][master/wrynose][PATCH] libsdl2: Build tests with dynamically linked library support
Date: Tue, 30 Jun 2026 18:51:35 -0400	[thread overview]
Message-ID: <20260630225135.GH10186@denix.org> (raw)
In-Reply-To: <20260630174314.1561862-1-a-christidis@ti.com>

On Tue, Jun 30, 2026 at 12:43:14PM -0500, Antonios Christidis via lists.yoctoproject.org wrote:
> From: Antonios Christidis <a-christidis@ti.com>
> 
> Carry upstream-submitted patch that adds SDL_TESTS_SHARED_LIB option,
> enabling test executables to be built with dynamic linking against
> libsdl2.
> 
> Signed-off-by: Antonios Christidis <a-christidis@ti.com>
> ---
>  .../recipes-graphics/libsdl2/libsdl2-ti.inc   |  9 +++
>  ...TS_SHARED_LIB-option-for-dynamically.patch | 56 +++++++++++++++++++
>  2 files changed, 65 insertions(+)
>  create mode 100644 meta-ti-test/recipes-graphics/libsdl2/libsdl2/0001-test-New-SDL_TESTS_SHARED_LIB-option-for-dynamically.patch
> 
> diff --git a/meta-ti-test/recipes-graphics/libsdl2/libsdl2-ti.inc b/meta-ti-test/recipes-graphics/libsdl2/libsdl2-ti.inc
> index 33ff0632..959818a1 100644
> --- a/meta-ti-test/recipes-graphics/libsdl2/libsdl2-ti.inc
> +++ b/meta-ti-test/recipes-graphics/libsdl2/libsdl2-ti.inc
> @@ -1,5 +1,14 @@
> +FILESEXTRAPATHS:prepend := "${THISDIR}/libsdl2:"
> +
> +SRC_URI:append = " \
> +    file://0001-test-New-SDL_TESTS_SHARED_LIB-option-for-dynamically.patch \
> +"
> +
>  EXTRA_OECMAKE += "-DSDL_TESTS=ON \
>                    -DSDL_INSTALL_TESTS=ON \
> +                  -DSDL_TESTS_SHARED_LIB=ON \
>                   "
> +
>  PACKAGE_BEFORE_PN = "${PN}-tests"
>  FILES:${PN}-tests += "${libexecdir} ${datadir}/installed-tests/SDL2"
> +RDEPENDS:${PN}-tests += "${PN}"

Now that you are no longer linking statically, you should try w/o explicit 
RDEPENDS here, as bitbake is supposed to detect this dependency automatically. 
That's what Andrew was asking last week...


> diff --git a/meta-ti-test/recipes-graphics/libsdl2/libsdl2/0001-test-New-SDL_TESTS_SHARED_LIB-option-for-dynamically.patch b/meta-ti-test/recipes-graphics/libsdl2/libsdl2/0001-test-New-SDL_TESTS_SHARED_LIB-option-for-dynamically.patch
> new file mode 100644
> index 00000000..cc435b3a
> --- /dev/null
> +++ b/meta-ti-test/recipes-graphics/libsdl2/libsdl2/0001-test-New-SDL_TESTS_SHARED_LIB-option-for-dynamically.patch
> @@ -0,0 +1,56 @@
> +From 96512412805f34ac6328290221c7ad83cde342b3 Mon Sep 17 00:00:00 2001
> +From: Antonios Christidis <a-christidis@ti.com>
> +Date: Fri, 26 Jun 2026 13:28:24 -0500
> +Subject: [PATCH] test: New SDL_TESTS_SHARED_LIB option for dynamically linked
> + tests
> +
> +Introduce SDL_TESTS_SHARED_LIB to allow tests that expect dynamic linking
> +to be built.
> +
> +Upstream-Status: Submitted [https://github.com/libsdl-org/SDL/pull/15907]
> +
> +Signed-off-by: Antonios Christidis <a-christidis@ti.com>
> +---
> + test/CMakeLists.txt | 19 ++++++++++++++++---
> + 1 file changed, 16 insertions(+), 3 deletions(-)
> +
> +diff --git a/test/CMakeLists.txt b/test/CMakeLists.txt
> +index 288645d73..8e5bd68d3 100644
> +--- a/test/CMakeLists.txt
> ++++ b/test/CMakeLists.txt
> +@@ -87,8 +87,17 @@ macro(add_sdl_test_executable TARGET)
> +     endif()
> + endmacro()
> +
> +-if(NOT TARGET SDL2::SDL2-static)
> +-    find_package(SDL2 2.0.23 REQUIRED COMPONENTS SDL2-static SDL2test)
> ++option(SDL_TESTS_SHARED_LIB "Link test executables against the shared SDL2 library" OFF)
> ++
> ++if(SDL_TESTS_SHARED_LIB)
> ++    set(SDL_SHARED ON)
> ++    if(NOT TARGET SDL2::SDL2)
> ++        find_package(SDL2 ${SDL_VERSION} REQUIRED COMPONENTS SDL2 SDL2test)
> ++    endif()
> ++else()
> ++    if(NOT TARGET SDL2::SDL2-static)
> ++        find_package(SDL2 ${SDL_VERSION} REQUIRED COMPONENTS SDL2-static SDL2test)
> ++    endif()
> + endif()
> +
> + enable_testing()
> +@@ -247,7 +256,11 @@ elseif(PS2)
> + elseif(IOS OR TVOS)
> +     sdltest_link_librararies(SDL2::SDL2main SDL2::SDL2test SDL2::SDL2-static)
> + else()
> +-    sdltest_link_librararies(SDL2::SDL2test SDL2::SDL2-static)
> ++    if(SDL_TESTS_SHARED_LIB)
> ++        sdltest_link_librararies(SDL2::SDL2test SDL2::SDL2)
> ++    else()
> ++        sdltest_link_librararies(SDL2::SDL2test SDL2::SDL2-static)
> ++    endif()
> + endif()
> +
> + if(WINDOWS)
> +--
> +2.34.1
> +
> --
> 2.34.1


  parent reply	other threads:[~2026-06-30 22:51 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-30 17:43 [meta-ti][master/wrynose][PATCH] libsdl2: Build tests with dynamically linked library support a-christidis
2026-06-30 18:03 ` PRC Automation
2026-06-30 22:51 ` Denys Dmytriyenko [this message]
2026-07-01 18:28   ` Antonios Christidis

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260630225135.GH10186@denix.org \
    --to=denis@denix.org \
    --cc=a-christidis@ti.com \
    --cc=afd@ti.com \
    --cc=denys@konsulko.com \
    --cc=meta-ti@lists.yoctoproject.org \
    --cc=reatmon@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.