Re: [PATCH v2 0/3] iio: light: al3xxx: add missing REGMAP_I2C to Kconfig entries

[Jonathan Cameron <jic23@kernel.org>]

On Thu, 25 Jun 2026 21:38:07 +0200
Joshua Crofts <joshua.crofts1@gmail.com> wrote:

> This series adds REGMAP_I2C support to three AL3xxx ambient light
> sensors that were previously missing this dependency, causing build
> failures.
> 
> To reproduce the build failure, run `make allnoconfig` and `make menuconfig`
> in which you select IIO, I2C and any AL3xxx sensor and `make .` will
> fail with errors such as:
> 
> drivers/iio/light/al3010.c: In function ‘al3010_probe’:
> drivers/iio/light/al3010.c:185:24: error: implicit declaration of function ‘devm_regmap_init_i2c’ [-Wimplicit-function-declaration]
>   185 |         data->regmap = devm_regmap_init_i2c(client, &al3010_regmap_config);
>       |                        ^~~~~~~~~~~~~~~~~~~~
> drivers/iio/light/al3010.c:185:22: error: assignment to ‘struct regmap *’ from ‘int’ makes pointer from integer without a cast [-Wint-conversion]
>   185 |         data->regmap = devm_regmap_init_i2c(client, &al3010_regmap_config);
>       |                      ^
> drivers/iio/light/al3010.c: At top level:
> drivers/iio/light/al3010.c:48:35: error: storage size of ‘al3010_regmap_config’ isn’t known
>    48 | static const struct regmap_config al3010_regmap_config = {
>       |                                   ^~~~~~~~~~~~~~~~~~~~
> 
> I made a separate commit for each driver, to ensure a proper Fixes:
> tag is appended for easy backporting. Let me know if you prefer
> squashing!
> 
> Signed-off-by: Joshua Crofts <joshua.crofts1@gmail.com>
Applied to the fixes-togreg branch of iio.git and marked for stable.

thanks,

Jonathan

> ---
> Changes in v2:
> - Change select keyword in commit message to lowercase
> - Add example steps to reproduce build failure
> - Link to v1: https://lore.kernel.org/r/20260625-fix-al3xxx-kconfig-v1-0-d41cbc0c3cf4@gmail.com
> 
> ---
> Joshua Crofts (3):
>       iio: light: al3000a: add missing REGMAP_I2C to Kconfig
>       iio: light: al3010: add missing REGMAP_I2C to Kconfig
>       iio: light: al3320a: add missing REGMAP_I2C to Kconfig
> 
>  drivers/iio/light/Kconfig | 3 +++
>  1 file changed, 3 insertions(+)
> ---
> base-commit: 7667a80340e99fd45357d0c90ae05813b01bbfef
> change-id: 20260625-fix-al3xxx-kconfig-ddb1f00a2615
> 
> Best regards,