From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0AA021E1E12 for ; Wed, 1 Jul 2026 03:51:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782877897; cv=none; b=TYU/ok0QUiGxhosNGXRbZizCg05mlecdS4rKRr7NyHUSE9kPtFKybGHIJtdgMcojBweA3eJOtbqabfl/uBcdYWBhlhnPeRbn3tWtd03TCCeJ1f1DQKa33dOzOp3stYRUIov5iEEb+SSrVlltWqNegit+PTrS3yWD6YVAbyZFlbc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782877897; c=relaxed/simple; bh=R0ITmoCQM/vVws+zvVbVs+Y1Q4/bBKXuVIL3XNzl7g4=; h=Date:To:From:Subject:Message-Id; b=oxJioZ0kKqeMYKlCJqNI+wMmCVM7UHBlFiGlBMCTZxwdpi3tMyYAgvh7EXIugntSXb5qq1ONJM94D2QrmMs11slNNATgHsJTPzVsdLHQ7V47vXgqifF8nNJaYMCbWUbh5NApOihulm3uvzjoDyhQvk2bEmmK9Oc0GMKyHlpMcRM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux-foundation.org header.i=@linux-foundation.org header.b=NKUyT6bL; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux-foundation.org header.i=@linux-foundation.org header.b="NKUyT6bL" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 781D01F000E9; Wed, 1 Jul 2026 03:51:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux-foundation.org; s=korg; t=1782877895; bh=L32ny77IaAugnDWLEA8eubZpHvU9R5sb96wMWC+2npc=; h=Date:To:From:Subject; b=NKUyT6bL6i2zFRW1EzbzcfjVBsdQFmcbRd+TfYOT5T0WqvDqoKi+Huo8u72Rn0wke OMo30oKLKeW2d78T+bBElTK5uA8IXGW1P7yKu0ex0IarvoHTn86gh5j+YIxMS4bEc8 UUqglLT5XQQX8nd3fat3p3Tq8zNA7/fiFJo+cpSc= Date: Tue, 30 Jun 2026 20:51:35 -0700 To: mm-commits@vger.kernel.org,usama.arif@linux.dev,akpm@linux-foundation.org From: Andrew Morton Subject: [to-be-updated] mm-vmpressure-skip-tree=true-accounting-on-cgroup-v2.patch removed from -mm tree Message-Id: <20260701035135.781D01F000E9@smtp.kernel.org> Precedence: bulk X-Mailing-List: mm-commits@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: The quilt patch titled Subject: mm/vmpressure: skip tree=true accounting on cgroup v2 has been removed from the -mm tree. Its filename was mm-vmpressure-skip-tree=true-accounting-on-cgroup-v2.patch This patch was dropped because an updated version will be issued ------------------------------------------------------ From: Usama Arif Subject: mm/vmpressure: skip tree=true accounting on cgroup v2 Date: Mon, 29 Jun 2026 05:59:36 -0700 Patch series "mm/vmpressure: reduce CPU, memory and code overhead on cgroup v2", v2. The vmpressure subsystem has two distinct consumers, gated by the @tree argument: tree=false : in-kernel socket pressure, consumed by TCP/SCTP. This is cgroup v2 only; v1 sockets read memcg->tcpmem_pressure instead. tree=true : cgroup v1 userspace eventfd notifications via the memory.pressure_level / cgroup.event_control interface. v2 has no equivalent (userspace gets reclaim signals through memory.pressure / PSI, which doesn't touch vmpressure). So of the four (hierarchy, tree) combinations, only two carry data that anyone reads. The existing early return in vmpressure() covered v1 + tree=false; the symmetric v2 + tree=true case was falling through and doing the full lock / accumulate / schedule_work / parent-walk dance, even though the events list it eventually iterates is empty on cgroup v2 (vmpressure_register_event() is wired up only through the v1 cftype "memory.pressure_level" and can't be reached from a v2 memcg). Patch 1 extends the existing early return to also skip v2 + tree=true. On a v2-only host this eliminates a contended path where reclaimers can serialize on a single global sr_lock. bpftrace on a 176-core production host (cgroup v2, 285 memcgs, sustained reclaim) showed ~16,200 such calls per minute with tree = true. Patch 2 follows up with a cleanup: it splits the v1 userspace eventfd interface (struct vmpressure_event, the events list and its mutex, the work_struct and its handler, the parent walk, vmpressure_register_event / unregister_event, and vmpressure_prio) into a new mm/vmpressure-v1.c built only when CONFIG_MEMCG_V1=y, behind small no-op stubs in the header. mm/vmpressure.c keeps the shared bits and the tree=false socket-pressure path. The size of vmpressure.c goes down to half and the code is much more simpler. The only #ifdef CONFIG_MEMCG_V1 remaining in source is around the v1-only fields inside struct vmpressure itself. Memory savings on CONFIG_MEMCG_V1=n: struct vmpressure : 112B -> 24B struct mem_cgroup : 1664B -> 1536B This split is the first step toward eventually making vmpressure CONFIG_MEMCG_V1 only. The v2 in-kernel socket pressure path (tree=false) cannot be removed today immediately: PSI is not an exact replacement for vmpressure, and switching networking socket-buffer back-off to PSI may regress networking performance or increase memory pressure in workloads that today rely on vmpressure's hysteresis. The medium-term plan is to introduce a PSI-based socket-pressure path, keep vmpressure available for v2 behind a defconfig as an opt-out for several releases, and only then drop the tree=false path entirely, at which point everything that remains in mm/vmpressure-v1.c is the whole subsystem. This patch (of 2): vmpressure() has two outputs gated by the @tree argument: @tree=false drives in-kernel socket pressure (mem_cgroup_set_ socket_pressure), consumed by TCP/SCTP. This only applies on cgroup v2; on v1 socket memory is charged separately via tcpmem and the consumer reads memcg->tcpmem_pressure instead. @tree=true drives userspace eventfd notifications via the v1 memory.pressure_level / cgroup.event_control interface. v2 has no equivalent: userspace gets reclaim signals through memory.pressure (PSI), which does not touch vmpressure. The existing early return covered v1 + @tree=false. The symmetric v2 + @tree=true case was falling through and doing the full lock / accumulate / schedule_work / parent-walk dance for an events list that can never be populated. bpftrace on a 176-core production host (cgroup v2, CONFIG_MEMCG_V1=n, 285 memcgs, sustained reclaim) showed ~16,200 @tree=true vmpressure() calls per minute. Add an early return that skips cgroup v2 + tree = true which avoids us doing all this work. On a v2-only host this also eliminates a lock contention path that can serialise reclaimers on a single global sr_lock. Link: https://lore.kernel.org/20260629130042.2649505-1-usama.arif@linux.dev Link: https://lore.kernel.org/20260629130042.2649505-2-usama.arif@linux.dev Signed-off-by: Usama Arif Acked-by: Shakeel Butt Acked-by: Johannes Weiner Cc: David Hildenbrand Cc: Liam R. Howlett Cc: Lorenzo Stoakes Cc: Michal Hocko Cc: Michal Koutný Cc: Mike Rapoport Cc: Roman Gushchin Cc: Suren Baghdasaryan Cc: Tejun Heo Cc: Vlastimil Babka Signed-off-by: Andrew Morton --- mm/vmpressure.c | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) --- a/mm/vmpressure.c~mm-vmpressure-skip-tree=true-accounting-on-cgroup-v2 +++ a/mm/vmpressure.c @@ -246,11 +246,13 @@ void vmpressure(gfp_t gfp, int order, st return; /* - * The in-kernel users only care about the reclaim efficiency - * for this @memcg rather than the whole subtree, and there - * isn't and won't be any in-kernel user in a legacy cgroup. + * Only two combinations have a consumer: + * cgroup v2 + tree=false -> in-kernel socket pressure + * cgroup v1 + tree=true -> userspace eventfds (memory.pressure_level) + * Skip the other two: nothing consumes the result. */ - if (!cgroup_subsys_on_dfl(memory_cgrp_subsys) && !tree) + if ((!cgroup_subsys_on_dfl(memory_cgrp_subsys) && !tree) || + (cgroup_subsys_on_dfl(memory_cgrp_subsys) && tree)) return; vmpr = memcg_to_vmpressure(memcg); _ Patches currently in -mm which might be from usama.arif@linux.dev are mm-swap_state-remove-unnecessary-lru_add_drain-from-readahead.patch mm-vmpressure-split-v1-userspace-eventfd-code-into-vmpressure-v1c.patch mm-add-softleaf_to_pmd-and-convert-existing-callers.patch mm-extract-mm_prepare_for_swap_entries-helper.patch fs-proc-use-softleaf_has_pfn-in-pagemap-pmd-walker.patch mm-huge_memory-move-softleaf_to_folio-inside-migration-branch.patch mm-migrate_device-move-softleaf_to_folio-inside-device-private-branch.patch mm-rename-arch_enable_thp_migration-to-arch_supports_pmd_softleaf.patch