From: Eric Auger <eric.auger@redhat.com>
To: eric.auger.pro@gmail.com, eric.auger@redhat.com,
qemu-devel@nongnu.org, qemu-arm@nongnu.org,
peter.maydell@linaro.org, berrange@redhat.com,
skolothumtho@nvidia.com, nicolinc@nvidia.com, nathanc@nvidia.com
Subject: [PATCH v2 2/5] hw/arm/smmuv3: Sanitize SMMU_S_STRTAB_BASE_CFG.SPLIT
Date: Wed, 1 Jul 2026 11:11:39 +0200 [thread overview]
Message-ID: <20260701091209.2860306-3-eric.auger@redhat.com> (raw)
In-Reply-To: <20260701091209.2860306-1-eric.auger@redhat.com>
Currently the guest value for the SPLIT field is not checked.
Also the spec says that values different from 6, 8, 10, respectively
meaning 4KB, 16kB and 64kB leaf tables are reserved and behave as 6.
Resolves: https://gitlab.com/qemu-project/qemu/-/work_items/3632
Signed-off-by: Eric Auger <eric.auger@redhat.com>
Reviewed-by: Shameer Kolothum <skolothumtho@nvidia.com>
---
hw/arm/smmuv3.c | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/hw/arm/smmuv3.c b/hw/arm/smmuv3.c
index 38aba9c0af9..285e6164a07 100644
--- a/hw/arm/smmuv3.c
+++ b/hw/arm/smmuv3.c
@@ -1688,6 +1688,13 @@ static MemTxResult smmu_writel(SMMUv3State *s, hwaddr offset,
s->strtab_base_cfg = data;
if (FIELD_EX32(data, STRTAB_BASE_CFG, FMT) == 1) {
s->sid_split = FIELD_EX32(data, STRTAB_BASE_CFG, SPLIT);
+ if (s->sid_split != 6 && s->sid_split != 8 && s->sid_split != 10) {
+ /* Other values are reserved, behave as 6 */
+ qemu_log_mask(LOG_GUEST_ERROR,
+ "Invalid STRTAB_BASE_CFG.SPLIT=%u, use 6 instead\n",
+ s->sid_split);
+ s->sid_split = 6;
+ }
s->features |= SMMU_FEATURE_2LVL_STE;
}
break;
--
2.53.0
next prev parent reply other threads:[~2026-07-01 9:16 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-01 9:11 [PATCH v2 0/5] SMMUV3: STE lookup fixes Eric Auger
2026-07-01 9:11 ` [PATCH v2 1/5] hw/arm/smmuv3: Fix off-by-one bug in alignment strtab mask Eric Auger
2026-07-03 9:09 ` Shameer Kolothum Thodi
2026-07-03 9:20 ` Philippe Mathieu-Daudé
2026-07-01 9:11 ` Eric Auger [this message]
2026-07-01 9:11 ` [PATCH v2 3/5] hw/arm/smmuv3: Sanitize SMMU_S_STRTAB_BASE_CFG.LOG2SIZE Eric Auger
2026-07-03 9:22 ` Shameer Kolothum Thodi
2026-07-03 12:54 ` Peter Maydell
2026-07-01 9:11 ` [PATCH v2 4/5] hw/arm/smmuv3: Check L1STD.SPAN Eric Auger
2026-07-03 9:35 ` Shameer Kolothum Thodi
2026-07-01 9:11 ` [PATCH v2 5/5] hw/arm/smmuv3: Enforce alignment of L2Ptr according to the span Eric Auger
2026-07-03 9:37 ` Shameer Kolothum Thodi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260701091209.2860306-3-eric.auger@redhat.com \
--to=eric.auger@redhat.com \
--cc=berrange@redhat.com \
--cc=eric.auger.pro@gmail.com \
--cc=nathanc@nvidia.com \
--cc=nicolinc@nvidia.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=skolothumtho@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.