From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.sourceforge.net (lists.sourceforge.net [216.105.38.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 14665C43458 for ; Wed, 1 Jul 2026 09:29:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.sourceforge.net; s=beta; h=Content-Transfer-Encoding:Content-Type:Cc: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: Subject:MIME-Version:References:In-Reply-To:Message-ID:Date:To:From:Sender: Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender :Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=cJHW/9o1LDWLU6djta60MHufyj38OPImAPh2dWqUKUY=; b=CzWkCZ76g0Mt7QQUWw6noFaJTi ibdzEb1C9JFnYsQ2y/d8NaFjq/2GIniIBJ/E0hZjoo3tlRX06y9IdLmTMTbmSFV7ZIfrpWzpIvId3 AgUdyzulkyJUH7S/NjzN2pECq1P342Txo0vwz+nUuHa3Ly1P6HwPcYchAe0/034JD4i8=; Received: from [127.0.0.1] (helo=sfs-ml-2.v29.lw.sourceforge.com) by sfs-ml-2.v29.lw.sourceforge.com with esmtp (Exim 4.95) (envelope-from ) id 1werFw-0006ml-TV; Wed, 01 Jul 2026 09:29:21 +0000 Received: from [172.30.29.66] (helo=mx.sourceforge.net) by sfs-ml-2.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1werFv-0006mY-Ee for linux-f2fs-devel@lists.sourceforge.net; Wed, 01 Jul 2026 09:29:20 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Transfer-Encoding:MIME-Version:References: In-Reply-To:Message-ID:Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=lp5O9+O+7QDEDntjCsZ4esXm+S8DPpjPpF8P+QT8tmE=; b=M7V9KuaIEQxC8bASqwjgx+BweR whoLkPUEpNybpSHp+0dFLvSeOpxA+cAe+kwiaXuTV3Yz76P+RFNxRaV7Ix4dr4Ri6GX18fja9i5yb cUSXcK1pCRBJdz3CSWFYbN34B/VAKE0L3K/PFn2JOu3tYWp3QStZfMtjguRBtRonRB6Y=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Transfer-Encoding:MIME-Version:References:In-Reply-To:Message-ID: Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=lp5O9+O+7QDEDntjCsZ4esXm+S8DPpjPpF8P+QT8tmE=; b=mBDdmQ64IE4rXlwZfDeRJaTEc1 S5ZbpXFhtcjcWBZX/MO8nJAMy1tdsBUe7o1YEDD0bRgoR8e9+/+NjTDQ6ggbCCBZimdv7AUGx2zxL 2QDjpwqzl9otve5eiMVskz6H+dEUz+V6Pzv1nmOQTkpgrqFD3yxlOWj6X4a+itevkrr4=; Received: from mail-pf1-f175.google.com ([209.85.210.175]) by sfi-mx-2.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES128-GCM-SHA256:128) (Exim 4.95) id 1werFr-0006Yg-QP for linux-f2fs-devel@lists.sourceforge.net; Wed, 01 Jul 2026 09:29:20 +0000 Received: by mail-pf1-f175.google.com with SMTP id d2e1a72fcca58-84783bce476so387841b3a.0 for ; Wed, 01 Jul 2026 02:29:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1782898145; x=1783502945; darn=lists.sourceforge.net; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=lp5O9+O+7QDEDntjCsZ4esXm+S8DPpjPpF8P+QT8tmE=; b=ZOXiksTIPSt18UdaHSGp0QhOl86GbUFBmdZBaF1TZLHwdJ594DpSwGyrp0IyJuKc00 UyiggjooSCQ2XQSu2snGmhiDMERMX6WjyIQXxU1H5qvpS8Pbl1ooBnHuhpYujPVfrhTk t2tpNovg4ssAOaMw0vllnDHWM4Q9KiKxsq2XGKqILWvk1iRv669ZD0k4sM1eeX8vHvnP hSG4hUdyzcwRv0vROuyIIXEmEcoqo5qg8PL5GNNbSEl0v7hhRz0LkCl9mZHPsbKcep+c kstpEvx5iWRo5B+07qtEyAypERp3H4HR3aZhHcRCFtlxmRSmXsPObRuYbahQYJzBRR3d I/Fg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782898146; x=1783502946; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=lp5O9+O+7QDEDntjCsZ4esXm+S8DPpjPpF8P+QT8tmE=; b=PikABV0N4PIqXxJlJjjWIbyu8AfUTdje4hvBAy1++6xLkTTdZDJPycqn2y0R4h41ok jIMvonm6J7ljLXvDZ1GuC1BhUnvarVIjffzpZlJmgrlBk5/DJto7xDHFaOeCNToEjXYR 0BWHdDjaX8sM9Lk59HgZ9djaM7TfO/f/IeTG2ncBmGqBnkFX68QwaQGIljTy4SpOqY8f QGYSe+fLcVz9WAgqWC+bkzdtF3AIP+k4YIU0KD2rZsYb9Z9QsRXyCuWdGwf7CdxYIZbB epzA8WRbGjAmKIE4VMzUQiTNro/pgNaDyNM/eeaD3o35G11kQsBE4qf/QcPx5pt2Hspu P9sQ== X-Gm-Message-State: AOJu0YzI44YJ/KFd0jjYsMN0qUXaOgAxRhe/0OnW3mBIVTXnZ9xxgs5j j2f+X2exmW+pMYTCSsUfYNMtSYS68rnjd40v0c0ULmhRzDG01C2BoZ+F X-Gm-Gg: AfdE7clugxZvJ0T2WSMs+CCv/LM2d0onvNwMni5j5RaLSh2mWffwpqPjleganV0ulV/ 8Q+4aKlQFdu3ISS84vm7RyJ9tg1ZP217Z4YfKhrEr/ffHLPDPYXVqhDhiXpDtuX7fwk3FAEOkCI L/RA1MFNLYZiouiyKJw4c9EUQYGWgnNylH/N1z9iaNazvXmtKvG5PNpRsZxoRJfX+sifHSane8P rEcf4KaJ+TQKNqXPKRUbZ2LM4Be6T9WABL/ReoGbql7Rz87nd+yVNW9o/SnSYR9/Q0W9gvIKgXx GAaraVKOrojOCJKsKnFDeHsQaTfHoYzT3YpRnfMchAEPmx2xdYUB89kSIVu81q49SSUgssW/D2k 6XsTAtN/uxQIolGJBqLcd0oPLzuX/spzI8+mSZVIigHq2kQzi3wP/HeqlDYM/Cznn4QcPQ9/59Z gAp7FkguSWPT5mkdiVP7vLdbpWuIxRcj0YpcyLXlpx/w== X-Received: by 2002:a05:6a00:2a0e:b0:845:d286:1fab with SMTP id d2e1a72fcca58-847c0ab02famr709333b3a.58.1782898145584; Wed, 01 Jul 2026 02:29:05 -0700 (PDT) Received: from zyy-OptiPlex-7080.mioffice.cn ([2408:8607:1b00:8:e680:ef51:fd6d:24b9]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-847a0329c22sm3624832b3a.40.2026.07.01.02.29.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 01 Jul 2026 02:29:05 -0700 (PDT) From: Yangyang Zang X-Google-Original-From: Yangyang Zang To: jaegeuk@kernel.org, chao@kernel.org Date: Wed, 1 Jul 2026 17:28:50 +0800 Message-ID: <20260701092850.1247010-2-zangyangyang1@xiaomi.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260701092850.1247010-1-zangyangyang1@xiaomi.com> References: <20260701092850.1247010-1-zangyangyang1@xiaomi.com> MIME-Version: 1.0 X-Headers-End: 1werFr-0006Yg-QP Subject: [f2fs-dev] [PATCH 2/2] fsck.f2fs: read each sit block only once in build_sit_entries X-BeenThere: linux-f2fs-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Yangyang Zang , linux-f2fs-devel@lists.sourceforge.net Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net build_sit_entries() calls get_current_sit_page() for every entry while scanning consecutive sit entries. Since each sit block contains multiple consecutive sit entries, this causes the same sit block to be read and copied repeatedly. Read the sit block only when entering a new sit block, and reuse the cached block for the remaining sit entries in that block. Signed-off-by: Yangyang Zang --- fsck/mount.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/fsck/mount.c b/fsck/mount.c index ea171a4c97c5..4c63c2d185ba 100644 --- a/fsck/mount.c +++ b/fsck/mount.c @@ -2676,7 +2676,8 @@ static int build_sit_entries(struct f2fs_sb_info *sbi) for (; segno < end && segno < MAIN_SEGS(sbi); segno++) { se = &sit_i->sentries[segno]; - get_current_sit_page(sbi, segno, sit_blk); + if (SIT_ENTRY_OFFSET(sit_i, segno) == 0) + get_current_sit_page(sbi, segno, sit_blk); sit = sit_blk->entries[SIT_ENTRY_OFFSET(sit_i, segno)]; check_block_count(sbi, segno, &sit); -- 2.43.0 _______________________________________________ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel