From: sashiko-bot@kernel.org
To: "Kishore Batta" <kishore.batta@oss.qualcomm.com>
Cc: dri-devel@lists.freedesktop.org
Subject: Re: [PATCH v6 1/7] Add documentation for Sahara protocol
Date: Wed, 01 Jul 2026 10:42:34 +0000 [thread overview]
Message-ID: <20260701104234.74D171F000E9@smtp.kernel.org> (raw)
In-Reply-To: <20260701-sahara_protocol_new_v2-v6-1-3a78362c4741@oss.qualcomm.com>
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Multiple typographical errors, misspelled constant names, and a copy-paste error exist in the newly added Sahara protocol documentation.
--
Note: The format of this report has been altered to provide a free-form summary of the findings rather than inline code quotes, due to strict content recitation restrictions.
commit ea565b1ec139594103ddde3b826aade3f2071329
Author: Kishore Batta <kishore.batta@oss.qualcomm.com>
Add documentation for Sahara protocol
This commit introduces documentation for the Qualcomm Sahara protocol. It details operational modes such as image transfer, memory debug, and command mode, explaining their functions and respective packet flows.
[Severity: Low]
This isn't a bug, but there is a typo in the mode constant name defined around line 206 in Documentation/mhi/sahara_protocol.rst. It is written as SAHARA_MODE_MEMORY_DBEUG instead of SAHARA_MODE_MEMORY_DEBUG. Could this typo mislead developers who are referencing the protocol definitions in their code?
[Severity: Low]
In the "Packet flow for memory debug" section around line 814, the text introduces the sequence with "The packet flow sequence for image transfer is as follows:". Is this a copy-paste error from the previous section? Should it refer to "memory debug" instead of "image transfer" here?
[Severity: Low]
There are several typographical errors scattered throughout the new documentation file that might be worth correcting for overall clarity and professionalism. These include:
- "sate" instead of "state" (e.g., in "Reset Sahara sate machine packet")
- "Sahar" instead of "Sahara" (e.g., "The Sahar client interprets")
- "pcket" instead of "packet" (e.g., "content from the data pcket is written")
- "targert" instead of "target" (e.g., "transferring the image header to the targert")
- "successgul" instead of "successful" (e.g., "receives a successgul end of image")
- "firgure" instead of "figure" (e.g., "The below firgure shows")
Would it be possible to fix these minor typos in a subsequent revision?
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260701-sahara_protocol_new_v2-v6-0-3a78362c4741@oss.qualcomm.com?part=1
next prev parent reply other threads:[~2026-07-01 10:42 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-01 10:37 [PATCH v6 0/7] Qualcomm Sahara protocol enhancements Kishore Batta
2026-07-01 10:37 ` [PATCH v6 1/7] Add documentation for Sahara protocol Kishore Batta
2026-07-01 10:42 ` sashiko-bot [this message]
2026-07-08 4:46 ` Randy Dunlap
2026-07-13 7:20 ` Kishore Batta
2026-07-01 10:37 ` [PATCH v6 2/7] bus: mhi: Move Sahara protocol driver under MHI host client drivers Kishore Batta
2026-07-01 10:50 ` sashiko-bot
2026-07-01 10:37 ` [PATCH v6 3/7] bus: mhi: Centralize Sahara firmware image table selection at probe time Kishore Batta
2026-07-01 10:47 ` sashiko-bot
2026-07-01 10:37 ` [PATCH v6 4/7] bus: mhi: Add QDU100 Sahara variant and firmware fallback Kishore Batta
2026-07-01 10:53 ` sashiko-bot
2026-07-09 6:19 ` Manivannan Sadhasivam
2026-07-13 7:25 ` Kishore Batta
2026-07-13 17:11 ` Manivannan Sadhasivam
2026-07-13 14:16 ` Kishore Batta
2026-07-13 16:19 ` Manivannan Sadhasivam
2026-07-01 10:37 ` [PATCH v6 5/7] bus: mhi: Load DDR training data using device serial number Kishore Batta
2026-07-01 10:57 ` sashiko-bot
2026-07-09 6:21 ` Manivannan Sadhasivam
2026-07-13 7:27 ` Kishore Batta
2026-07-01 10:37 ` [PATCH v6 6/7] bus: mhi: Capture DDR training data via command mode Kishore Batta
2026-07-01 10:51 ` sashiko-bot
2026-07-01 10:37 ` [PATCH v6 7/7] bus: mhi: Expose DDR training data via controller sysfs Kishore Batta
2026-07-01 10:52 ` sashiko-bot
2026-07-09 6:57 ` Manivannan Sadhasivam
2026-07-13 7:30 ` Kishore Batta
2026-07-13 17:08 ` Manivannan Sadhasivam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260701104234.74D171F000E9@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=kishore.batta@oss.qualcomm.com \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.