From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f174.google.com (mail-pl1-f174.google.com [209.85.214.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6E870480DF8 for ; Wed, 1 Jul 2026 12:23:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.174 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782908595; cv=none; b=KQm6AbUvA6R1FisHQxiZoNi4larHmBYbzSaY9eHZMtCNcyO+Om2ow79qv2zL7qwAYU/KiT0YgJNdrDqYSiP8URC1tBX2iEk14S1hop6M+a6sQa5+0ghGLqU3Zr+oYgA1/Mvw18+a/OMOS/sULUFa1lD1rZk3npW6IjfxG3BXE9Q= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782908595; c=relaxed/simple; bh=yhC1e0ZzliyRdtlVUueoO1bJdMQisEQkE6746sabsHw=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=pSyBBIych8zSpAIrBM7VMMB5of59FA0gbp7wmfDkHudANvGYcPylonuL0LESNwPDv4bedDSVmqnrNHyof3o9XpDtWHODQOUUIO62xz//u8nU736g2YCuKyASRKaa6xfr8ho5PwyiSeVLEs4gZfGcS0PCF4lDM/pfHBC6kenhXzw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=eaB84vdI; arc=none smtp.client-ip=209.85.214.174 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="eaB84vdI" Received: by mail-pl1-f174.google.com with SMTP id d9443c01a7336-2c9b19bbaefso3588025ad.0 for ; Wed, 01 Jul 2026 05:23:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1782908594; x=1783513394; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=7kp62ieRMyjOkk6mXBcyHmXcTSjtToMp+qoAu3klnJQ=; b=eaB84vdIsGgOO3pXysISsZd0EtpY/EOtRg35/iG0grwgplPwSBAkB38H/m7fqHmgXN 8fcOPB4Q65PWnL+9X3ekoxNF0HfFXMoEktVAbRdkSz0LE0bkZWhb16MBjYKIz0S7g+y7 5/w1F/6l5aTYz95c8u545ufpjcPrpIGYgGou9/2lRqSZ/FjitktrU5RMO+cedpslX44f hCq7gJO7uw7ZdpzKu6inUrFXTDzM8jmstZh99PaLbnhU7w81BjGn7kN5VHf67cf47DRG e4ufYglWN9BE7ejfG23v6J6oRiotLJQxl0E2cXHFv7BFw3yaSuWK9kHexMvPj7sd2PDn /vdg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782908594; x=1783513394; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=7kp62ieRMyjOkk6mXBcyHmXcTSjtToMp+qoAu3klnJQ=; b=ozof85GLkBkuWDK+GnC/bBcfbqzh0b3qolRZJg24DnqYRIzZuMhc9QxzULNzf27yrf 0ms4UkNtS/YxOVYk7PGi91tY+dBdoOfvhhTyRRFmQb7+obzeax2cbnDuSO3QeNa/HiO3 cJh5nt8y2PLUnRoRrjKIku5DevZ8cn09Rg/CqEQxhyqo3Ti+vClLHYEFkosuSTMJckRA Y394/fUiaUPk+DrtfiEF23lLLvLaAOy5IkNUOqRTxc1IbWvCgzpZM2xqIjqWJGMjOG8m J5QYxRFhwyUExDnhCwuI7j4RY1l12+RwvgF7Ew65uRKhUAZ8ob2VZcJBt9PTf5EC24w8 F0XA== X-Forwarded-Encrypted: i=1; AHgh+Rom2E6i1+LGPMdzqK4NKVRylI1v/cuX7F0vn3r98yQ2MVyLUbBoMF4mpMp/j65QczA65Dl/byWI3A91Ywo=@vger.kernel.org X-Gm-Message-State: AOJu0Yz5GskGRDDRzPFmzHuCmP0IKNvVz7o0gLn3/g4UiRuMhHsRBdNM 9UbBO+VwpLPDBYi06apEJ0ghzDaF4gxwJoC6UYquQl7IK/q9eJsmrIg= X-Gm-Gg: AfdE7clPo6KMRkohviF5Q0H3TdTg6WssOM3SGJUZP/2k1AJMWY5TFF3NYkZFj2XAhk3 g7qFbGI5K7fMY5ysG70saKzTAkgOcY5xxahWjaJnbYQAJHa4bAx/dUE3/xqCGvx4eRENIgymeKs YupVFnf9HcZwAqKgXNlaWG8BQgazYf5uT9CpckVQSOCdLFBM+odmX4LW+HEPjfMPTBiC4M7j/LS vby6tHVELG3pCRhRl8GIdDPHhK0Nom86T4/+N8n5c3fwTQdAF2qIY7vfordPcD06KkGAkXRyKuw qUZyDskoYRcmGy8+bpF850z+6vC9QYoid8Pri1oVyfZWDH8VEmedcETeDhV/ccngeYWL48ZhZHV l2qszSAFALbNmEpksLZ7DK3BSWziycHzwnX83bPtQ0CvaAPGCG5PPVp/VRELtkQ2DXGQulwvc16 Ykzs1m/XMk3/q0RD5oiWPQ3kJ+YXh0mnrOrQ0ggYogkQAcEQKfZ8hqltP6xKzoTN9Lo090mMi2C VcXH54wXz39z4WgDkjuI/q0P9u56bWOBijGaFWMjxu6MhWPGw== X-Received: by 2002:a17:902:ebc4:b0:2ca:35d:1148 with SMTP id d9443c01a7336-2ca7e8dbff8mr15486835ad.29.1782908593440; Wed, 01 Jul 2026 05:23:13 -0700 (PDT) Received: from localhost.localdomain ([14.5.152.27]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2ca3828c8e8sm31219095ad.42.2026.07.01.05.23.10 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Wed, 01 Jul 2026 05:23:12 -0700 (PDT) From: Myeonghun Pak To: Greg Kroah-Hartman Cc: Oliver Neukum , Alex Henrie , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org, Myeonghun Pak , Ijae Kim Subject: [PATCH] USB: misc: uss720: unregister parport on probe failure Date: Wed, 1 Jul 2026 21:22:46 +0900 Message-Id: <20260701122246.2451-1-mhun512@gmail.com> X-Mailer: git-send-email 2.39.5 (Apple Git-154) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit uss720_probe() registers a parport before reading the 1284 register used to detect unsupported Belkin F5U002 adapters. If get_1284_register() fails, the error path drops the driver private data and the USB device reference, but leaves the parport device registered. Undo the pre-announce registration with parport_del_port(). Clear priv->pp before unregistering the port, matching the disconnect path and avoiding leaving a stale pointer in the private data. This issue was identified during our ongoing static-analysis research while reviewing kernel code. Fixes: 3295f1b866bf ("usb: misc: uss720: check for incompatible versions of the Belkin F5U002") Cc: stable@vger.kernel.org Co-developed-by: Ijae Kim Signed-off-by: Ijae Kim Signed-off-by: Myeonghun Pak --- drivers/usb/misc/uss720.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/usb/misc/uss720.c b/drivers/usb/misc/uss720.c index a8af7615b1..8a5ffb19a5 100644 --- a/drivers/usb/misc/uss720.c +++ b/drivers/usb/misc/uss720.c @@ -749,6 +749,10 @@ static int uss720_probe(struct usb_interface *intf, return 0; probe_abort: + if (pp) { + priv->pp = NULL; + parport_del_port(pp); + } kill_all_async_requests_priv(priv); kref_put(&priv->ref_count, destroy_priv); return -ENODEV; -- 2.47.1