From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.11]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 47BA9481FB9 for ; Wed, 1 Jul 2026 12:23:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.11 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782908603; cv=none; b=g5BPfp7i6WyfddeHLOUmFqjIntTYsScuKRxeTr3XWF00dFanT+nV5YZqf5RtDjg7OXLNyk0FqdQuiiC8SpU7QtAMolxuKi501WTrobG/6f6KneBYNlClXa3yHS0hFwCGLmUmMjn6jjnkmGqV8Pxd7EjVGM+Q8XWdXFpvOhQSbmk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782908603; c=relaxed/simple; bh=bV2cFbfqPfLEkoD/cic9a+wB1zY5Nk4VV/7SIJOzS5c=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Qr06Zzqh18ZWrgMglaZUrmdor+62YXPY+eX+7NuEhLqdr48yNwqdD5sfpOuCqfoen+Aa1orraeCjiAXlO1kI35YC8bZt9p1I7o4U4Gz63KxiYyLY6gYZeNvIHAgjyaYCLxaL+i2Jq35vGVaxTNqMV9dyNtz9wKpDzE8lgx/AGhw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=pass smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=FwLZFMio; arc=none smtp.client-ip=192.198.163.11 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="FwLZFMio" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1782908602; x=1814444602; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=bV2cFbfqPfLEkoD/cic9a+wB1zY5Nk4VV/7SIJOzS5c=; b=FwLZFMio0RYCnAG3RUBDE/UzrNNM09UMEjCAMxQw8SAEQoqJ/VUvBdqT zE7CKLGl+g2dqtfUO7wrvrC6PDUlgenVBSWJj7x/XfQ8pMZ0Q3UXJdoc2 /JcLZ8i4aeJldlr3MPHzLuFv4xs+42pykx0vqd0hVJeyUDzb0Eajz9UYQ FMAaX0j0BIedOJwZc4+IzmgNCW2G5Um15vrqc5iS+EdEHuN0S36NTRtkE ieV01Lvei+m0Xf1xIwdtFh2dGOZBLIE2fPfCo3lKriIaZFb8asg7Lyosv nnOks/zKX1+65lH46YjymEo7tutSzrOqXfypHSKot3aRRcgGrs/Sc3RDj Q==; X-CSE-ConnectionGUID: BkgvOHaSTQus2ZN27cvc+g== X-CSE-MsgGUID: 5q4VRa2MRiOyWDeJKwpiGw== X-IronPort-AV: E=McAfee;i="6800,10657,11833"; a="94239109" X-IronPort-AV: E=Sophos;i="6.25,141,1779174000"; d="scan'208";a="94239109" Received: from fmviesa003.fm.intel.com ([10.60.135.143]) by fmvoesa105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Jul 2026 05:23:21 -0700 X-CSE-ConnectionGUID: /dqe1WrcSRq3yDj8uyhBYQ== X-CSE-MsgGUID: 9yClszWYTb6RyOZAj9D8IQ== X-ExtLoop1: 1 Received: from pgcooper-mobl3.ger.corp.intel.com (HELO kekkonen.fi.intel.com) ([10.245.244.62]) by fmviesa003-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Jul 2026 05:23:14 -0700 Received: from punajuuri.localdomain (unknown [192.168.240.130]) by kekkonen.fi.intel.com (Postfix) with ESMTP id E7A3F121C43; Wed, 01 Jul 2026 15:23:04 +0300 (EEST) Received: from sailus by punajuuri.localdomain with local (Exim 4.98.2) (envelope-from ) id 1weu1S-00000007Fkt-2qPO; Wed, 01 Jul 2026 15:26:34 +0300 Organization: Intel Finland Oy - BIC 0357606-4 - c/o Alberga Business Park, 6 krs, Bertel Jungin Aukio 5, 02600 Espoo From: Sakari Ailus To: linux-media@vger.kernel.org Cc: hans@jjverkuil.nl, laurent.pinchart@ideasonboard.com, Prabhakar , Kate Hsuan , Dave Stevenson , Tommaso Merciai , Benjamin Mugnier , Sylvain Petinot , Christophe JAILLET , Julien Massot , Naushir Patuck , "Yan, Dongcheng" , Stefan Klug , Mirela Rabulea , =?UTF-8?q?Andr=C3=A9=20Apitzsch?= , Heimir Thor Sverrisson , Kieran Bingham , Mehdi Djait , Ricardo Ribalda Delgado , Hans de Goede , Jacopo Mondi , Tomi Valkeinen , David Plowman , "Yu, Ong Hock" , "Ng, Khai Wen" , Jai Luthra , Rishikesh Donadkar Subject: [PATCH v6 09/16] media: v4l2-subdev: Always call get_fmt() if set_fmt() is unavailable Date: Wed, 1 Jul 2026 15:26:26 +0300 Message-ID: <20260701122634.1728782-9-sakari.ailus@linux.intel.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260607215356.842932-1-sakari.ailus@linux.intel.com> References: <20260607215356.842932-1-sakari.ailus@linux.intel.com> Precedence: bulk X-Mailing-List: linux-media@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Many drivers implement set_fmt() pad op that simply returns the format just as get_fmt() would do, usually because the driver only supports a single one. As a driver should always implement set_fmt() either on its own or via get_fmt(), call get_fmt() in case set_fmt() isn't implemented by the driver. This allows removing a fair amount of boilerplate code as well as ensures that set_fmt() works whenever get_fmt() does. Signed-off-by: Sakari Ailus --- drivers/media/v4l2-core/v4l2-subdev.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/media/v4l2-core/v4l2-subdev.c b/drivers/media/v4l2-core/v4l2-subdev.c index 86be4d51c9a5..c2be59e4c4a7 100644 --- a/drivers/media/v4l2-core/v4l2-subdev.c +++ b/drivers/media/v4l2-core/v4l2-subdev.c @@ -260,8 +260,11 @@ static int call_set_fmt(struct v4l2_subdev *sd, struct v4l2_subdev_state *state, struct v4l2_subdev_format *format) { - return do_subdev_call(sd, check_format(sd, state, format), pad, set_fmt, - state, format); + return check_format(sd, state, format) ? : + sd->ops->pad->set_fmt ? + sd->ops->pad->set_fmt(sd, state, format) : + sd->ops->pad->get_fmt ? + sd->ops->pad->get_fmt(sd, state, format) : -ENOIOCTLCMD; } static int call_enum_mbus_code(struct v4l2_subdev *sd, -- 2.47.3