From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6F3F1481665 for ; Wed, 1 Jul 2026 12:30:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782909005; cv=none; b=jJUExUsyC2+3P0EBd9AgkA5LfDakI3iZM1mQLP9bWCxhL/Zuv8GPu+vmjvQuCqAqkeQdKe1uOZz4mb9v7/bZKc/zJ3wiZDs2dpbCxbIdMpo2YRTRm5Ls1LFKghMZ/3gyfevph0JvWUzfmWKMpAaPNQm5BdWH2F/ieJj7YO3bWek= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782909005; c=relaxed/simple; bh=qC2R9B5pwevwtmupxdX8wEkzy5I3qPUw7O/avmV0ZAw=; h=From:Subject:To:Cc:In-Reply-To:References:Content-Type:Date: Message-Id; b=ikvpJTEnYcKbuYEU6eZ266+gwP2kBR5recNrEjyP1KYU/+x3Dv/x4DSxqU/ch3d5VI1Dli2R7fAhhn1aXKDjTp2SJJ/K6I/6v1mK9AK1p90Pxl4PhJYaBlbaW1euAnB+bOwnTdi2fGpdmAJKrLOzU299Hxn0vff24ODfh9v519k= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=fHwzDOgx; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="fHwzDOgx" Received: by smtp.kernel.org (Postfix) with ESMTPSA id B65211F000E9; Wed, 1 Jul 2026 12:30:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1782909004; bh=p/Ltph7WWF2KDaFV2op4D3gJpqRALqGdOM9Gv3W8WeQ=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=fHwzDOgxbOKw/V1SMc/+aZnecLypCRVbcTaY3+V03yNMZd90Zk6V7xzEXVo5YIpdV y4FfwpeCKFvhFz8+HreE8DMw+CF+fVr9MJB6mqYvVYG0tgIxiVu0ca24S+9LY5hF+x 1rXYXogTKejG8oVVzugfhAyFz087KSrhGKBWLJRyrk5OPxfiBMGshRADyeIdEVmLlF 2c59A7XUigU7yYeAm/FTGgCf2fMLQxePzMvMpqovSwckqH+4iMgprZprNNR3GoiYhb 8N1eErELMv9vr2RVGIbEVmhXM2WkITzhYibFQRum6LxvzRMF3op862J2K9eYcdEjjq njzk20pc1Zdgg== From: sashiko-bot@kernel.org Subject: Re: [PATCH 03/12] phy: phy-mtk-dp: Allow probing with devicetree match Reply-To: sashiko-reviews@lists.linux.dev To: "AngeloGioacchino Del Regno" Cc: neil.armstrong@linaro.org, vkoul@kernel.org, linux-phy@lists.infradead.org, devicetree@vger.kernel.org, olteanv@gmail.com, robh@kernel.org, conor+dt@kernel.org, dri-devel@lists.freedesktop.org In-Reply-To: <20260701122008.19509-4-angelogioacchino.delregno@collabora.com> References: <20260701122008.19509-1-angelogioacchino.delregno@collabora.com> <20260701122008.19509-4-angelogioacchino.delregno@collabora.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Wed, 01 Jul 2026 12:30:03 +0000 Message-Id: <20260701123003.B65211F000E9@smtp.kernel.org> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Thank you for your contribution! Sashiko AI review found 4 potential issue(= s) to consider: New issues: - [High] The return value of `pm_runtime_get_sync()` is ignored, which can = lead to hardware register accesses on an unpowered device. - [Medium] Missing `.remove` callback leaves PM runtime enabled and usage c= ounter unbalanced on driver unbind. Pre-existing issues: - [High] Missing `phy_remove_lookup()` causes a memory leak and a dangling = pointer in the global PHY lookup list. - [High] Unconditional dereference of `dev->platform_data` before validatin= g it. -- commit e3a3844cc6f977665174375e23735f789c04a772 Author: AngeloGioacchino Del Regno phy: phy-mtk-dp: Allow probing with devicetree match This commit introduces a devicetree match table to decouple the DP PHY driv= er from the DP IP driver. It adds an OF PHY provider and MMIO regmap registrat= ion for the devicetree case, while maintaining a legacy probe path for older devicetrees without a separate PHY node. > diff --git a/drivers/phy/mediatek/phy-mtk-dp.c b/drivers/phy/mediatek/phy= -mtk-dp.c > index bf7b3a95e72d2..98e05fe05ce3b 100644 > --- a/drivers/phy/mediatek/phy-mtk-dp.c > +++ b/drivers/phy/mediatek/phy-mtk-dp.c [ ... ] > @@ -160,43 +161,92 @@ static const struct phy_ops mtk_dp_phy_dev_ops =3D { > .owner =3D THIS_MODULE, > }; > =20 > +static int mtk_dp_phy_legacy_probe(struct platform_device *pdev, struct = mtk_dp_phy *dp_phy) > +{ > + struct device *dev =3D &pdev->dev; > + struct phy *phy; > + > + dp_phy->regmap =3D *(struct regmap **)dev->platform_data; [Severity: High] This is a pre-existing issue, but does this code unconditionally dereference dev->platform_data before verifying it is not NULL? If the platform device is instantiated without platform data, would this dereference cause a kernel panic before the subsequent check for !dp_phy->regmap can execute? > + if (!dp_phy->regmap) > + return dev_err_probe(dev, -EINVAL, "No platform data available\n"); > + > + phy =3D devm_phy_create(dev, NULL, &mtk_dp_phy_dev_ops); > + if (IS_ERR(phy)) > + return dev_err_probe(dev, PTR_ERR(phy), > + "Failed to create DP PHY\n"); > + > + phy_set_drvdata(phy, dp_phy); > + phy_create_lookup(phy, "dp", dev_name(dev)); [Severity: High] This isn't a bug introduced by this patch, but does this leak the lookup entry and create a dangling pointer? phy_create_lookup() dynamically allocates a phy_lookup structure and links = it into the global phys list. Since there is no driver .remove callback calling phy_remove_lookup(), when the driver unbinds, the devres-managed phy is fre= ed while still in the global list, which could cause a use-after-free when oth= er drivers call phy_find(). > + > + return 0; > +} > + [ ... ] > static int mtk_dp_phy_probe(struct platform_device *pdev) > { [ ... ] > + provider =3D devm_of_phy_provider_register(dev, of_phy_simple_xlate); > + if (IS_ERR(provider)) > + return PTR_ERR(provider); > + > + pm_runtime_enable(dev); > + pm_runtime_get_sync(dev); [Severity: High] Is it safe to ignore the return value of pm_runtime_get_sync() here? If the generic power domain or clock fails to enable, pm_runtime_get_sync() will return a negative error code. Without checking this, the PHY provider = is registered even if the hardware is off, which could lead to a synchronous external abort when attempting to write to the MMIO registers later. > =20 > return 0; > } > =20 > +static const struct of_device_id mtk_dp_phy_of_match[] =3D { > + { .compatible =3D "mediatek,mt8195-dp-phy" }, > + { /* sentinel */ } > +}; > +MODULE_DEVICE_TABLE(of, mtk_dp_phy_of_match); > + > static struct platform_driver mtk_dp_phy_driver =3D { > .probe =3D mtk_dp_phy_probe, > .driver =3D { > .name =3D "mediatek-dp-phy", > + .of_match_table =3D mtk_dp_phy_of_match, > }, > }; [Severity: Medium] Does this driver need a .remove callback to clean up the PM runtime state? Since pm_runtime_enable() and pm_runtime_get_sync() are called in probe without devm_ handlers or registered teardown actions, unbinding the driver appears to leak the usage counter and leave PM runtime permanently enabled. > module_platform_driver(mtk_dp_phy_driver); > --=20 Sashiko AI review =C2=B7 https://sashiko.dev/#/patchset/20260701122008.1950= 9-1-angelogioacchino.delregno@collabora.com?part=3D3 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B3A46C43458 for ; Wed, 1 Jul 2026 12:30:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Reply-To:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:Message-Id:Date: References:In-Reply-To:Cc:To:Subject:From:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=dAGxYY5O/YW2WhFY9i5jMvCO2IX6QnoaCE1USbVXD70=; b=CNfli4VXvZkH+b q2nk2SH3kOfOnNGe00Pgp9Ltm7x3MPGSlNXhxiPr896YNwiJkdpPdusCwS55mj/0lnHUjtBnwPqsm wsrPyNz4E8ckleH0TzORSS+Y5JbRPsTcfs0R0GkvrcuH3o3MrurufJukWyg6UkDI5eZM5OL/eOZ4G IxNxG+yo6kATkFLY9WH+nxwptpDLGg6OUvjZudwCehoce9nE2eFnN4VwMK62OtYJLboZSrMoq9via 6Zpz5ai1yZsHwj+Jn/3wLLdPghOQzI3geMZdHNCt/RrpFQth/a3jkGfQkjmMissLTDOZdlrbKMby2 X0Qgd3wZNpNIoThhQTlA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1weu4s-00000001zmq-1PQt; Wed, 01 Jul 2026 12:30:06 +0000 Received: from sea.source.kernel.org ([2600:3c0a:e001:78e:0:1991:8:25]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1weu4q-00000001zmV-2I86 for linux-phy@lists.infradead.org; Wed, 01 Jul 2026 12:30:04 +0000 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by sea.source.kernel.org (Postfix) with ESMTP id 4E875413B8; Wed, 1 Jul 2026 12:30:04 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id B65211F000E9; Wed, 1 Jul 2026 12:30:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1782909004; bh=p/Ltph7WWF2KDaFV2op4D3gJpqRALqGdOM9Gv3W8WeQ=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=fHwzDOgxbOKw/V1SMc/+aZnecLypCRVbcTaY3+V03yNMZd90Zk6V7xzEXVo5YIpdV y4FfwpeCKFvhFz8+HreE8DMw+CF+fVr9MJB6mqYvVYG0tgIxiVu0ca24S+9LY5hF+x 1rXYXogTKejG8oVVzugfhAyFz087KSrhGKBWLJRyrk5OPxfiBMGshRADyeIdEVmLlF 2c59A7XUigU7yYeAm/FTGgCf2fMLQxePzMvMpqovSwckqH+4iMgprZprNNR3GoiYhb 8N1eErELMv9vr2RVGIbEVmhXM2WkITzhYibFQRum6LxvzRMF3op862J2K9eYcdEjjq njzk20pc1Zdgg== From: sashiko-bot@kernel.org Subject: Re: [PATCH 03/12] phy: phy-mtk-dp: Allow probing with devicetree match To: "AngeloGioacchino Del Regno" Cc: neil.armstrong@linaro.org, vkoul@kernel.org, linux-phy@lists.infradead.org, devicetree@vger.kernel.org, olteanv@gmail.com, robh@kernel.org, conor+dt@kernel.org, dri-devel@lists.freedesktop.org In-Reply-To: <20260701122008.19509-4-angelogioacchino.delregno@collabora.com> References: <20260701122008.19509-1-angelogioacchino.delregno@collabora.com> <20260701122008.19509-4-angelogioacchino.delregno@collabora.com> Date: Wed, 01 Jul 2026 12:30:03 +0000 Message-Id: <20260701123003.B65211F000E9@smtp.kernel.org> X-BeenThere: linux-phy@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux Phy Mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: sashiko-reviews@lists.linux.dev MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-phy" Errors-To: linux-phy-bounces+linux-phy=archiver.kernel.org@lists.infradead.org VGhhbmsgeW91IGZvciB5b3VyIGNvbnRyaWJ1dGlvbiEgU2FzaGlrbyBBSSByZXZpZXcgZm91bmQg NCBwb3RlbnRpYWwgaXNzdWUocykgdG8gY29uc2lkZXI6CgpOZXcgaXNzdWVzOgotIFtIaWdoXSBU aGUgcmV0dXJuIHZhbHVlIG9mIGBwbV9ydW50aW1lX2dldF9zeW5jKClgIGlzIGlnbm9yZWQsIHdo aWNoIGNhbiBsZWFkIHRvIGhhcmR3YXJlIHJlZ2lzdGVyIGFjY2Vzc2VzIG9uIGFuIHVucG93ZXJl ZCBkZXZpY2UuCi0gW01lZGl1bV0gTWlzc2luZyBgLnJlbW92ZWAgY2FsbGJhY2sgbGVhdmVzIFBN IHJ1bnRpbWUgZW5hYmxlZCBhbmQgdXNhZ2UgY291bnRlciB1bmJhbGFuY2VkIG9uIGRyaXZlciB1 bmJpbmQuCgpQcmUtZXhpc3RpbmcgaXNzdWVzOgotIFtIaWdoXSBNaXNzaW5nIGBwaHlfcmVtb3Zl X2xvb2t1cCgpYCBjYXVzZXMgYSBtZW1vcnkgbGVhayBhbmQgYSBkYW5nbGluZyBwb2ludGVyIGlu IHRoZSBnbG9iYWwgUEhZIGxvb2t1cCBsaXN0LgotIFtIaWdoXSBVbmNvbmRpdGlvbmFsIGRlcmVm ZXJlbmNlIG9mIGBkZXYtPnBsYXRmb3JtX2RhdGFgIGJlZm9yZSB2YWxpZGF0aW5nIGl0LgotLQoK Y29tbWl0IGUzYTM4NDRjYzZmOTc3NjY1MTc0Mzc1ZTIzNzM1Zjc4OWMwNGE3NzIKQXV0aG9yOiBB bmdlbG9HaW9hY2NoaW5vIERlbCBSZWdubyA8YW5nZWxvZ2lvYWNjaGluby5kZWxyZWdub0Bjb2xs YWJvcmEuY29tPgoKcGh5OiBwaHktbXRrLWRwOiBBbGxvdyBwcm9iaW5nIHdpdGggZGV2aWNldHJl ZSBtYXRjaAoKVGhpcyBjb21taXQgaW50cm9kdWNlcyBhIGRldmljZXRyZWUgbWF0Y2ggdGFibGUg dG8gZGVjb3VwbGUgdGhlIERQIFBIWSBkcml2ZXIKZnJvbSB0aGUgRFAgSVAgZHJpdmVyLiBJdCBh ZGRzIGFuIE9GIFBIWSBwcm92aWRlciBhbmQgTU1JTyByZWdtYXAgcmVnaXN0cmF0aW9uCmZvciB0 aGUgZGV2aWNldHJlZSBjYXNlLCB3aGlsZSBtYWludGFpbmluZyBhIGxlZ2FjeSBwcm9iZSBwYXRo IGZvciBvbGRlcgpkZXZpY2V0cmVlcyB3aXRob3V0IGEgc2VwYXJhdGUgUEhZIG5vZGUuCgo+IGRp ZmYgLS1naXQgYS9kcml2ZXJzL3BoeS9tZWRpYXRlay9waHktbXRrLWRwLmMgYi9kcml2ZXJzL3Bo eS9tZWRpYXRlay9waHktbXRrLWRwLmMKPiBpbmRleCBiZjdiM2E5NWU3MmQyLi45OGUwNWZlMDVj ZTNiIDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvcGh5L21lZGlhdGVrL3BoeS1tdGstZHAuYwo+ICsr KyBiL2RyaXZlcnMvcGh5L21lZGlhdGVrL3BoeS1tdGstZHAuYwoKWyAuLi4gXQoKPiBAQCAtMTYw LDQzICsxNjEsOTIgQEAgc3RhdGljIGNvbnN0IHN0cnVjdCBwaHlfb3BzIG10a19kcF9waHlfZGV2 X29wcyA9IHsKPiAgCS5vd25lciA9IFRISVNfTU9EVUxFLAo+ICB9Owo+ICAKPiArc3RhdGljIGlu dCBtdGtfZHBfcGh5X2xlZ2FjeV9wcm9iZShzdHJ1Y3QgcGxhdGZvcm1fZGV2aWNlICpwZGV2LCBz dHJ1Y3QgbXRrX2RwX3BoeSAqZHBfcGh5KQo+ICt7Cj4gKwlzdHJ1Y3QgZGV2aWNlICpkZXYgPSAm cGRldi0+ZGV2Owo+ICsJc3RydWN0IHBoeSAqcGh5Owo+ICsKPiArCWRwX3BoeS0+cmVnbWFwID0g KihzdHJ1Y3QgcmVnbWFwICoqKWRldi0+cGxhdGZvcm1fZGF0YTsKCltTZXZlcml0eTogSGlnaF0K VGhpcyBpcyBhIHByZS1leGlzdGluZyBpc3N1ZSwgYnV0IGRvZXMgdGhpcyBjb2RlIHVuY29uZGl0 aW9uYWxseSBkZXJlZmVyZW5jZQpkZXYtPnBsYXRmb3JtX2RhdGEgYmVmb3JlIHZlcmlmeWluZyBp dCBpcyBub3QgTlVMTD8KCklmIHRoZSBwbGF0Zm9ybSBkZXZpY2UgaXMgaW5zdGFudGlhdGVkIHdp dGhvdXQgcGxhdGZvcm0gZGF0YSwgd291bGQgdGhpcwpkZXJlZmVyZW5jZSBjYXVzZSBhIGtlcm5l bCBwYW5pYyBiZWZvcmUgdGhlIHN1YnNlcXVlbnQgY2hlY2sgZm9yCiFkcF9waHktPnJlZ21hcCBj YW4gZXhlY3V0ZT8KCj4gKwlpZiAoIWRwX3BoeS0+cmVnbWFwKQo+ICsJCXJldHVybiBkZXZfZXJy X3Byb2JlKGRldiwgLUVJTlZBTCwgIk5vIHBsYXRmb3JtIGRhdGEgYXZhaWxhYmxlXG4iKTsKPiAr Cj4gKwlwaHkgPSBkZXZtX3BoeV9jcmVhdGUoZGV2LCBOVUxMLCAmbXRrX2RwX3BoeV9kZXZfb3Bz KTsKPiArCWlmIChJU19FUlIocGh5KSkKPiArCQlyZXR1cm4gZGV2X2Vycl9wcm9iZShkZXYsIFBU Ul9FUlIocGh5KSwKPiArCQkJCSAgICAgIkZhaWxlZCB0byBjcmVhdGUgRFAgUEhZXG4iKTsKPiAr Cj4gKwlwaHlfc2V0X2RydmRhdGEocGh5LCBkcF9waHkpOwo+ICsJcGh5X2NyZWF0ZV9sb29rdXAo cGh5LCAiZHAiLCBkZXZfbmFtZShkZXYpKTsKCltTZXZlcml0eTogSGlnaF0KVGhpcyBpc24ndCBh IGJ1ZyBpbnRyb2R1Y2VkIGJ5IHRoaXMgcGF0Y2gsIGJ1dCBkb2VzIHRoaXMgbGVhayB0aGUgbG9v a3VwCmVudHJ5IGFuZCBjcmVhdGUgYSBkYW5nbGluZyBwb2ludGVyPwoKcGh5X2NyZWF0ZV9sb29r dXAoKSBkeW5hbWljYWxseSBhbGxvY2F0ZXMgYSBwaHlfbG9va3VwIHN0cnVjdHVyZSBhbmQgbGlu a3MgaXQKaW50byB0aGUgZ2xvYmFsIHBoeXMgbGlzdC4gU2luY2UgdGhlcmUgaXMgbm8gZHJpdmVy IC5yZW1vdmUgY2FsbGJhY2sgY2FsbGluZwpwaHlfcmVtb3ZlX2xvb2t1cCgpLCB3aGVuIHRoZSBk cml2ZXIgdW5iaW5kcywgdGhlIGRldnJlcy1tYW5hZ2VkIHBoeSBpcyBmcmVlZAp3aGlsZSBzdGls bCBpbiB0aGUgZ2xvYmFsIGxpc3QsIHdoaWNoIGNvdWxkIGNhdXNlIGEgdXNlLWFmdGVyLWZyZWUg d2hlbiBvdGhlcgpkcml2ZXJzIGNhbGwgcGh5X2ZpbmQoKS4KCj4gKwo+ICsJcmV0dXJuIDA7Cj4g K30KPiArCgpbIC4uLiBdCgo+ICBzdGF0aWMgaW50IG10a19kcF9waHlfcHJvYmUoc3RydWN0IHBs YXRmb3JtX2RldmljZSAqcGRldikKPiAgewoKWyAuLi4gXQoKPiArCXByb3ZpZGVyID0gZGV2bV9v Zl9waHlfcHJvdmlkZXJfcmVnaXN0ZXIoZGV2LCBvZl9waHlfc2ltcGxlX3hsYXRlKTsKPiArCWlm IChJU19FUlIocHJvdmlkZXIpKQo+ICsJCXJldHVybiBQVFJfRVJSKHByb3ZpZGVyKTsKPiArCj4g KwlwbV9ydW50aW1lX2VuYWJsZShkZXYpOwo+ICsJcG1fcnVudGltZV9nZXRfc3luYyhkZXYpOwoK W1NldmVyaXR5OiBIaWdoXQpJcyBpdCBzYWZlIHRvIGlnbm9yZSB0aGUgcmV0dXJuIHZhbHVlIG9m IHBtX3J1bnRpbWVfZ2V0X3N5bmMoKSBoZXJlPwoKSWYgdGhlIGdlbmVyaWMgcG93ZXIgZG9tYWlu IG9yIGNsb2NrIGZhaWxzIHRvIGVuYWJsZSwgcG1fcnVudGltZV9nZXRfc3luYygpCndpbGwgcmV0 dXJuIGEgbmVnYXRpdmUgZXJyb3IgY29kZS4gV2l0aG91dCBjaGVja2luZyB0aGlzLCB0aGUgUEhZ IHByb3ZpZGVyIGlzCnJlZ2lzdGVyZWQgZXZlbiBpZiB0aGUgaGFyZHdhcmUgaXMgb2ZmLCB3aGlj aCBjb3VsZCBsZWFkIHRvIGEgc3luY2hyb25vdXMKZXh0ZXJuYWwgYWJvcnQgd2hlbiBhdHRlbXB0 aW5nIHRvIHdyaXRlIHRvIHRoZSBNTUlPIHJlZ2lzdGVycyBsYXRlci4KCj4gIAo+ICAJcmV0dXJu IDA7Cj4gIH0KPiAgCj4gK3N0YXRpYyBjb25zdCBzdHJ1Y3Qgb2ZfZGV2aWNlX2lkIG10a19kcF9w aHlfb2ZfbWF0Y2hbXSA9IHsKPiArCXsgLmNvbXBhdGlibGUgPSAibWVkaWF0ZWssbXQ4MTk1LWRw LXBoeSIgfSwKPiArCXsgLyogc2VudGluZWwgKi8gfQo+ICt9Owo+ICtNT0RVTEVfREVWSUNFX1RB QkxFKG9mLCBtdGtfZHBfcGh5X29mX21hdGNoKTsKPiArCj4gIHN0YXRpYyBzdHJ1Y3QgcGxhdGZv cm1fZHJpdmVyIG10a19kcF9waHlfZHJpdmVyID0gewo+ICAJLnByb2JlID0gbXRrX2RwX3BoeV9w cm9iZSwKPiAgCS5kcml2ZXIgPSB7Cj4gIAkJLm5hbWUgPSAibWVkaWF0ZWstZHAtcGh5IiwKPiAr CQkub2ZfbWF0Y2hfdGFibGUgPSBtdGtfZHBfcGh5X29mX21hdGNoLAo+ICAJfSwKPiAgfTsKCltT ZXZlcml0eTogTWVkaXVtXQpEb2VzIHRoaXMgZHJpdmVyIG5lZWQgYSAucmVtb3ZlIGNhbGxiYWNr IHRvIGNsZWFuIHVwIHRoZSBQTSBydW50aW1lIHN0YXRlPwoKU2luY2UgcG1fcnVudGltZV9lbmFi bGUoKSBhbmQgcG1fcnVudGltZV9nZXRfc3luYygpIGFyZSBjYWxsZWQgaW4gcHJvYmUKd2l0aG91 dCBkZXZtXyBoYW5kbGVycyBvciByZWdpc3RlcmVkIHRlYXJkb3duIGFjdGlvbnMsIHVuYmluZGlu ZyB0aGUgZHJpdmVyCmFwcGVhcnMgdG8gbGVhayB0aGUgdXNhZ2UgY291bnRlciBhbmQgbGVhdmUg UE0gcnVudGltZSBwZXJtYW5lbnRseSBlbmFibGVkLgoKPiAgbW9kdWxlX3BsYXRmb3JtX2RyaXZl cihtdGtfZHBfcGh5X2RyaXZlcik7Cj4KCi0tIApTYXNoaWtvIEFJIHJldmlldyDCtyBodHRwczov L3Nhc2hpa28uZGV2LyMvcGF0Y2hzZXQvMjAyNjA3MDExMjIwMDguMTk1MDktMS1hbmdlbG9naW9h Y2NoaW5vLmRlbHJlZ25vQGNvbGxhYm9yYS5jb20/cGFydD0zCgotLSAKbGludXgtcGh5IG1haWxp bmcgbGlzdApsaW51eC1waHlAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwczovL2xpc3RzLmluZnJh ZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1waHkK