From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9E8BFC44500 for ; Wed, 1 Jul 2026 13:02:26 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 047D710F017; Wed, 1 Jul 2026 13:02:26 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.b="Lz1gDrWu"; dkim-atps=neutral Received: from sea.source.kernel.org (sea.source.kernel.org [172.234.252.31]) by gabe.freedesktop.org (Postfix) with ESMTPS id AD78810F017 for ; Wed, 1 Jul 2026 13:02:24 +0000 (UTC) Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by sea.source.kernel.org (Postfix) with ESMTP id 7130140850; Wed, 1 Jul 2026 13:02:24 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id CF9691F000E9; Wed, 1 Jul 2026 13:02:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1782910944; bh=MwYg1YAoI39wRvoAcBgzLbmYQlvcrl66/3NbKVGwuEs=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=Lz1gDrWuY7UOVKIkxILFqALu51y6JTcV/9buRhmroPW4pGCAPcUE+f9aYm+YPm92q 1GKDQQEG7H+O8j43TGoh9XBtaEawZII+CCPYw1gWCCpMALUfyCgObNrPmpxcQg2xpB YKPhQIbnByUWEmtlHLU3w8zkc1jSC5/JEh/WSXC3Kzsj6uDsjGPmC4/iKGv1E1j/yb YDx+P2Mbz2HuOQQHv1zgeeUqdtfMtHUCo7VaWDhkvwPzTB9SMtfIze9d8f9aATEq6P 4ITVzYEud6ZUwVppjR15Ed0WMkGZLI613ljY8AYG78XUi9vCJXm2Wbh3HhkHOn7jZ9 DhxWy/FXAOjNQ== From: sashiko-bot@kernel.org Subject: Re: [PATCH 10/12] phy: phy-mtk-dp: Add bitrate register val definitions to SoC data To: "AngeloGioacchino Del Regno" Cc: devicetree@vger.kernel.org, robh@kernel.org, vkoul@kernel.org, conor+dt@kernel.org, linux-phy@lists.infradead.org, olteanv@gmail.com, neil.armstrong@linaro.org, dri-devel@lists.freedesktop.org In-Reply-To: <20260701122008.19509-11-angelogioacchino.delregno@collabora.com> References: <20260701122008.19509-1-angelogioacchino.delregno@collabora.com> <20260701122008.19509-11-angelogioacchino.delregno@collabora.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Wed, 01 Jul 2026 13:02:23 +0000 Message-Id: <20260701130223.CF9691F000E9@smtp.kernel.org> X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: sashiko-reviews@lists.linux.dev Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Thank you for your contribution! Sashiko AI review found 1 potential issue(= s) to consider: - [High] mtk_dp_phy_disable_all_lanes loop executes undefined behavior when= val is 0, and incorrectly clears lane bits using the lane index instead of= a bitmask. -- commit 25cdd51bd1ac4d69a49e77d93a6b1374ba46dd3c Author: AngeloGioacchino Del Regno phy: phy-mtk-dp: Support set_lanes in configure and properly cleanup Add support for enabling a specifically requested number of lanes in the configure callback, and disable all lanes in power off and reset callbacks for proper hardware cleanup. > diff --git a/drivers/phy/mediatek/phy-mtk-dp.c b/drivers/phy/mediatek/phy= -mtk-dp.c > index 586e727956332..a2cd22b9da066 100644 > --- a/drivers/phy/mediatek/phy-mtk-dp.c > +++ b/drivers/phy/mediatek/phy-mtk-dp.c [ ... ] > @@ -261,6 +267,35 @@ static int mtk_dp_phy_power_on(struct phy *phy) > return 0; > } > =20 > +static int mtk_dp_phy_disable_all_lanes(struct mtk_dp_phy *dp_phy) > +{ > + const struct mtk_dp_phy_pdata *pdata =3D dp_phy->pdata; > + const u8 *regs =3D pdata->regs_dig_glb; > + int ret; > + u32 val; > + > + ret =3D regmap_read(dp_phy->regmap, pdata->off_dig_glb + regs[DP_PHYD_T= X_CTL_0], &val); > + if (ret) > + return ret; > + > + /* Get mask of currently enabled lane */ > + val =3D FIELD_GET(PHYD_TX_LN_EN, val); > + > + /* Disable all lanes (needs to be done one by one, from last to first) = */ > + do { > + u32 lane_num =3D fls(val) - 1; [Severity: High] If no lanes are currently enabled, val will be 0. Does this cause fls(0) - 1 to underflow, leading to undefined behavior when computing BIT(lane_num)? > + val &=3D ~BIT(lane_num); > + > + ret =3D regmap_clear_bits(dp_phy->regmap, > + pdata->off_dig_glb + regs[DP_PHYD_TX_CTL_0], > + FIELD_PREP(PHYD_TX_LN_EN, lane_num)); [Severity: High] Does this incorrectly clear bits using the lane index instead of a bitmask? For example, if lane 3 is being disabled (lane_num =3D=3D 3), this passes 3= to FIELD_PREP instead of BIT(3). This would clear lanes 0 and 1 (3 << 4) while leaving lane 3 enabled. Should this use BIT(lane_num) instead? > + if (ret) > + return ret; > + } while (val); > + > + return 0; > +} [ ... ] --=20 Sashiko AI review =C2=B7 https://sashiko.dev/#/patchset/20260701122008.1950= 9-1-angelogioacchino.delregno@collabora.com?part=3D10 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C21F6C43327 for ; Wed, 1 Jul 2026 13:02:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Reply-To:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:Message-Id:Date: References:In-Reply-To:Cc:To:Subject:From:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=BDczBOB8yev1VPB/uJYzXR1kpwcu2Z71i1IYeRYOudI=; b=vTSJMx4Bm7dRqQ QKRtGpw56fayUWYvULBiTZF3SCAuMflkz8iR/d9Xxuhko/7RvdlWmM7n46eHP2Un8wHWM3jWmi3BB D5547v1Gae1MKdZRTBIjOhDsDGARq/jjvnIKPGoGCguhjJHL7mhpELPIArn5e7w4UtWZTRMTSc3z8 GlGqKHopxzjY3PfV9VW1t9xnNVZ36efZ3Vs0Aoy2zmFDes+cknqP3dJOU3GVgWF89zCC68yPrcwZj F+XSPmeX3D3kuQ+ciQmPlat2EkIO7tBrcuVpt5Ux5n0oggUzzLf9YUcX/7LTn/ssWTCnMtRe2OhPh 9Pv/uVcXChMSEhJiY+rg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1weua9-000000026jo-2K2R; Wed, 01 Jul 2026 13:02:25 +0000 Received: from sea.source.kernel.org ([172.234.252.31]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1weua9-000000026jQ-07E6 for linux-phy@lists.infradead.org; Wed, 01 Jul 2026 13:02:25 +0000 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by sea.source.kernel.org (Postfix) with ESMTP id 7130140850; Wed, 1 Jul 2026 13:02:24 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id CF9691F000E9; Wed, 1 Jul 2026 13:02:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1782910944; bh=MwYg1YAoI39wRvoAcBgzLbmYQlvcrl66/3NbKVGwuEs=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=Lz1gDrWuY7UOVKIkxILFqALu51y6JTcV/9buRhmroPW4pGCAPcUE+f9aYm+YPm92q 1GKDQQEG7H+O8j43TGoh9XBtaEawZII+CCPYw1gWCCpMALUfyCgObNrPmpxcQg2xpB YKPhQIbnByUWEmtlHLU3w8zkc1jSC5/JEh/WSXC3Kzsj6uDsjGPmC4/iKGv1E1j/yb YDx+P2Mbz2HuOQQHv1zgeeUqdtfMtHUCo7VaWDhkvwPzTB9SMtfIze9d8f9aATEq6P 4ITVzYEud6ZUwVppjR15Ed0WMkGZLI613ljY8AYG78XUi9vCJXm2Wbh3HhkHOn7jZ9 DhxWy/FXAOjNQ== From: sashiko-bot@kernel.org Subject: Re: [PATCH 10/12] phy: phy-mtk-dp: Add bitrate register val definitions to SoC data To: "AngeloGioacchino Del Regno" Cc: devicetree@vger.kernel.org, robh@kernel.org, vkoul@kernel.org, conor+dt@kernel.org, linux-phy@lists.infradead.org, olteanv@gmail.com, neil.armstrong@linaro.org, dri-devel@lists.freedesktop.org In-Reply-To: <20260701122008.19509-11-angelogioacchino.delregno@collabora.com> References: <20260701122008.19509-1-angelogioacchino.delregno@collabora.com> <20260701122008.19509-11-angelogioacchino.delregno@collabora.com> Date: Wed, 01 Jul 2026 13:02:23 +0000 Message-Id: <20260701130223.CF9691F000E9@smtp.kernel.org> X-BeenThere: linux-phy@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux Phy Mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: sashiko-reviews@lists.linux.dev MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-phy" Errors-To: linux-phy-bounces+linux-phy=archiver.kernel.org@lists.infradead.org VGhhbmsgeW91IGZvciB5b3VyIGNvbnRyaWJ1dGlvbiEgU2FzaGlrbyBBSSByZXZpZXcgZm91bmQg MSBwb3RlbnRpYWwgaXNzdWUocykgdG8gY29uc2lkZXI6Ci0gW0hpZ2hdIG10a19kcF9waHlfZGlz YWJsZV9hbGxfbGFuZXMgbG9vcCBleGVjdXRlcyB1bmRlZmluZWQgYmVoYXZpb3Igd2hlbiB2YWwg aXMgMCwgYW5kIGluY29ycmVjdGx5IGNsZWFycyBsYW5lIGJpdHMgdXNpbmcgdGhlIGxhbmUgaW5k ZXggaW5zdGVhZCBvZiBhIGJpdG1hc2suCi0tCgpjb21taXQgMjVjZGQ1MWJkMWFjNGQ2OWE0OWU3 N2Q5M2E2YjEzNzRiYTQ2ZGQzYwpBdXRob3I6IEFuZ2Vsb0dpb2FjY2hpbm8gRGVsIFJlZ25vIDxh bmdlbG9naW9hY2NoaW5vLmRlbHJlZ25vQGNvbGxhYm9yYS5jb20+CgpwaHk6IHBoeS1tdGstZHA6 IFN1cHBvcnQgc2V0X2xhbmVzIGluIGNvbmZpZ3VyZSBhbmQgcHJvcGVybHkgY2xlYW51cAoKQWRk IHN1cHBvcnQgZm9yIGVuYWJsaW5nIGEgc3BlY2lmaWNhbGx5IHJlcXVlc3RlZCBudW1iZXIgb2Yg bGFuZXMgaW4gdGhlCmNvbmZpZ3VyZSBjYWxsYmFjaywgYW5kIGRpc2FibGUgYWxsIGxhbmVzIGlu IHBvd2VyIG9mZiBhbmQgcmVzZXQKY2FsbGJhY2tzIGZvciBwcm9wZXIgaGFyZHdhcmUgY2xlYW51 cC4KCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvcGh5L21lZGlhdGVrL3BoeS1tdGstZHAuYyBiL2Ry aXZlcnMvcGh5L21lZGlhdGVrL3BoeS1tdGstZHAuYwo+IGluZGV4IDU4NmU3Mjc5NTYzMzIuLmEy Y2QyMmI5ZGEwNjYgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9waHkvbWVkaWF0ZWsvcGh5LW10ay1k cC5jCj4gKysrIGIvZHJpdmVycy9waHkvbWVkaWF0ZWsvcGh5LW10ay1kcC5jClsgLi4uIF0KPiBA QCAtMjYxLDYgKzI2NywzNSBAQCBzdGF0aWMgaW50IG10a19kcF9waHlfcG93ZXJfb24oc3RydWN0 IHBoeSAqcGh5KQo+ICAJcmV0dXJuIDA7Cj4gIH0KPiAgCj4gK3N0YXRpYyBpbnQgbXRrX2RwX3Bo eV9kaXNhYmxlX2FsbF9sYW5lcyhzdHJ1Y3QgbXRrX2RwX3BoeSAqZHBfcGh5KQo+ICt7Cj4gKwlj b25zdCBzdHJ1Y3QgbXRrX2RwX3BoeV9wZGF0YSAqcGRhdGEgPSBkcF9waHktPnBkYXRhOwo+ICsJ Y29uc3QgdTggKnJlZ3MgPSBwZGF0YS0+cmVnc19kaWdfZ2xiOwo+ICsJaW50IHJldDsKPiArCXUz MiB2YWw7Cj4gKwo+ICsJcmV0ID0gcmVnbWFwX3JlYWQoZHBfcGh5LT5yZWdtYXAsIHBkYXRhLT5v ZmZfZGlnX2dsYiArIHJlZ3NbRFBfUEhZRF9UWF9DVExfMF0sICZ2YWwpOwo+ICsJaWYgKHJldCkK PiArCQlyZXR1cm4gcmV0Owo+ICsKPiArCS8qIEdldCBtYXNrIG9mIGN1cnJlbnRseSBlbmFibGVk IGxhbmUgKi8KPiArCXZhbCA9IEZJRUxEX0dFVChQSFlEX1RYX0xOX0VOLCB2YWwpOwo+ICsKPiAr CS8qIERpc2FibGUgYWxsIGxhbmVzIChuZWVkcyB0byBiZSBkb25lIG9uZSBieSBvbmUsIGZyb20g bGFzdCB0byBmaXJzdCkgKi8KPiArCWRvIHsKPiArCQl1MzIgbGFuZV9udW0gPSBmbHModmFsKSAt IDE7CgpbU2V2ZXJpdHk6IEhpZ2hdCklmIG5vIGxhbmVzIGFyZSBjdXJyZW50bHkgZW5hYmxlZCwg dmFsIHdpbGwgYmUgMC4gRG9lcyB0aGlzIGNhdXNlIGZscygwKSAtIDEKdG8gdW5kZXJmbG93LCBs ZWFkaW5nIHRvIHVuZGVmaW5lZCBiZWhhdmlvciB3aGVuIGNvbXB1dGluZyBCSVQobGFuZV9udW0p PwoKPiArCQl2YWwgJj0gfkJJVChsYW5lX251bSk7Cj4gKwo+ICsJCXJldCA9IHJlZ21hcF9jbGVh cl9iaXRzKGRwX3BoeS0+cmVnbWFwLAo+ICsJCQkJCXBkYXRhLT5vZmZfZGlnX2dsYiArIHJlZ3Nb RFBfUEhZRF9UWF9DVExfMF0sCj4gKwkJCQkJRklFTERfUFJFUChQSFlEX1RYX0xOX0VOLCBsYW5l X251bSkpOwoKW1NldmVyaXR5OiBIaWdoXQpEb2VzIHRoaXMgaW5jb3JyZWN0bHkgY2xlYXIgYml0 cyB1c2luZyB0aGUgbGFuZSBpbmRleCBpbnN0ZWFkIG9mIGEgYml0bWFzaz8KCkZvciBleGFtcGxl LCBpZiBsYW5lIDMgaXMgYmVpbmcgZGlzYWJsZWQgKGxhbmVfbnVtID09IDMpLCB0aGlzIHBhc3Nl cyAzIHRvCkZJRUxEX1BSRVAgaW5zdGVhZCBvZiBCSVQoMykuIFRoaXMgd291bGQgY2xlYXIgbGFu ZXMgMCBhbmQgMSAoMyA8PCA0KSB3aGlsZQpsZWF2aW5nIGxhbmUgMyBlbmFibGVkLiBTaG91bGQg dGhpcyB1c2UgQklUKGxhbmVfbnVtKSBpbnN0ZWFkPwoKPiArCQlpZiAocmV0KQo+ICsJCQlyZXR1 cm4gcmV0Owo+ICsJfSB3aGlsZSAodmFsKTsKPiArCj4gKwlyZXR1cm4gMDsKPiArfQpbIC4uLiBd CgotLSAKU2FzaGlrbyBBSSByZXZpZXcgwrcgaHR0cHM6Ly9zYXNoaWtvLmRldi8jL3BhdGNoc2V0 LzIwMjYwNzAxMTIyMDA4LjE5NTA5LTEtYW5nZWxvZ2lvYWNjaGluby5kZWxyZWdub0Bjb2xsYWJv cmEuY29tP3BhcnQ9MTAKCi0tIApsaW51eC1waHkgbWFpbGluZyBsaXN0CmxpbnV4LXBoeUBsaXN0 cy5pbmZyYWRlYWQub3JnCmh0dHBzOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3Rp bmZvL2xpbnV4LXBoeQo=