All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stephen Hemminger <stephen@networkplumber.org>
To: "WanRenyong" <wanry@yunsilicon.com>
Cc: <dev@dpdk.org>, <thomas@monjalon.net>
Subject: Re: [PATCH] devtool: fix falsely reporting from checkpatch
Date: Wed, 1 Jul 2026 13:46:23 -0700	[thread overview]
Message-ID: <20260701134623.54491400@phoenix.local> (raw)
In-Reply-To: <20250120112654.1049456-1-wanry@yunsilicon.com>

On Mon, 20 Jan 2025 19:26:54 +0800
"WanRenyong" <wanry@yunsilicon.com> wrote:

> diff --git a/devtools/checkpatches.sh b/devtools/checkpatches.sh
> index 003bb49e04..2e228b7f92 100755
> --- a/devtools/checkpatches.sh
> +++ b/devtools/checkpatches.sh
> @@ -384,8 +384,8 @@ check_packed_attributes() { # <patch>
>  		res=1
>  	fi
>  
> -	begin_count=$(grep '__rte_packed_begin' "$1" | wc -l)
> -	end_count=$(grep '__rte_packed_end' "$1" | wc -l)
> +	begin_count=$(grep -E '^\+.*__rte_packed_begin' "$1" | wc -l)
> +	end_count=$(grep -E '^\+.*__rte_packed_end' "$1" | wc -l)

Using wc to count lines is unnecessary, grep already has a count option '-c'

      parent reply	other threads:[~2026-07-01 20:46 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-01-20 11:26 [PATCH] devtool: fix falsely reporting from checkpatch WanRenyong
2025-01-28 15:02 ` David Marchand
2025-01-28 15:55   ` Andre Muezerie
2026-07-01 20:46 ` Stephen Hemminger [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260701134623.54491400@phoenix.local \
    --to=stephen@networkplumber.org \
    --cc=dev@dpdk.org \
    --cc=thomas@monjalon.net \
    --cc=wanry@yunsilicon.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.