From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f43.google.com (mail-wm1-f43.google.com [209.85.128.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1280525B09B for ; Wed, 1 Jul 2026 14:02:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.43 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782914560; cv=none; b=hqq2G/eQEakRMKHixGElV6YxLMnSh9N254f2DX1XdzmAMxmM1C9aW3wtBxdS9F72bUPiGwwr2fz0gK/UbiDJe9fFqZlEA4ZU0U9Fyox/M45Az/av8MtKaRdSmPzFGOzsZUIcIvjSO9Inbw+yWXowpLgjretQRxb3HzZ97rTew1s= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782914560; c=relaxed/simple; bh=b87QwzvJSe0F2yHr23QZcSdKxJvHN4AUenNq2ATH7gk=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=YQZaCK7s9dKFOOo+7e1daWcXrXjFJmyOyGMvw7gMdN1e1jfaW4vcbGH/TDy0oGLmqLNcaTGT67sL5zCbUmHWDOXZvr/nOJRILwv43G5p+0eHs+GVu7pdBAkHQQu+0z1OWcDoUAOHTHNZF6YTeGYwezJ3dkVKLxjgKb6GiiEhOg4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=QFnBNt1E; arc=none smtp.client-ip=209.85.128.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="QFnBNt1E" Received: by mail-wm1-f43.google.com with SMTP id 5b1f17b1804b1-4925a778491so381615e9.0 for ; Wed, 01 Jul 2026 07:02:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1782914557; x=1783519357; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=smlUF8PDysGUPRBW5n55dDuKs8Qygu7ujB0Z7MC5VhQ=; b=QFnBNt1E7VtbH5E0Frx7D/7CpoIoKNMNWAa6dT5XIaEPiNF9WWctMWEgNAFkK1VIAw Mc7SupMbhkq5ga0g3TujuG/37g7Vd2ilFPhuaCe4CacbkmcPpa5Hn6iYfMDspaWNF9cJ ybBeuaGSmMx/ky13JbjEB3HJbrBMLPs/ZutYqLV5vIDPPPIvC+/MCcFaZ+PpDS8uuLau 2NiRM9U9JPE76fQ34r2pjwCNg6QDgQb7sKvVsrT9Yw6BNNPWDolEJVKEUHhADGoJf1gs huzJSHqvXeCBUQogIrYRQWaOmQUhnQVrKQjlVHR4byNtyoE2SuPM9g7gypqETBnG4wN/ KBxg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782914557; x=1783519357; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=smlUF8PDysGUPRBW5n55dDuKs8Qygu7ujB0Z7MC5VhQ=; b=nCNC77OhINuj7DRcQvzkSraxFoVavqIb35vJiIKnb82C8hCmK2waEChkG/YANlrZNW PBrp19pUi3Gnz/exmM9KOM5GKZucRXoZMUFd0E1xOisrO3RdtxT3GRx5hB0ejSEoC3cR TvhM65FL55v9i5W1YjKoIMaYelr3ogcXjQuBWr/4MEfcmTeIpPoeRMWMsRE2hd23C4vn Z9LciJ3C1X4qJykDQXIablefj62fP6lEmHM3ngzI1Pj/A2oTNIjSw8AOz19FEczEnOmZ U6scktJyEiLk5LRUpRFWuPEt9foN4qu+cb1YAYORWG6sFoIU/7Dri+Sj7kUTlUFN1RLE mDIw== X-Forwarded-Encrypted: i=1; AFNElJ+TZpV49J3mKTrVb5h2o0AUNBL1NnSFV16xq/HdMDsArEf8ChT5Z7nXCnJDtXLYr+C/+xe7ITG3mU/lcYM=@vger.kernel.org X-Gm-Message-State: AOJu0YzRUQAM0UmgCXh8zbiYCmt4u+VIsHe8UJKqNKKn1SzsZvPZgz1/ fv7AdNI418JYZBtJ+lpEB/bDY8tYWI60zorZQCgUR0UNMpc5Na3kVkRGbXp5EA== X-Gm-Gg: AfdE7clsdX4DCGDtRqdnfBBWoRDNCuv+JjoDRmPd1Jc0uk3LIgUnltQoHcMukXqmtac 3GLqiZOhJ0C9EFGIRb8i69j+0aKsgbggOle+fPNGgJPwLG+b4HKE00VzgHQlyx20w2wff8REKnZ L98L3ADQKhbZis3Fn9iAh8guAgPxYqEVfnKfZc2WSLGYJw4m0B+gSXTL3KU1sdkGnWnWrEqDJhY 6van0QR1q3HMRXLP7z9tXYK1+X+H/UL1QmbcwkRd7QUrIGovgj3MXHKdnnHCnaPgvBE6U2nIP+Z KnBaso+vAGEtGthoLqktS1JofVm58+LruOUFzTktQimyD5fehBAkbKM+n6TPEwIk71HBfQKmon4 WnoyUPhWOTYhNKSsA/t5XHsldssLg20kfKrpZ9D70Z1/QVeN0h7cyx4gduM3cQxnB0tEyftPrWd ar16UBddGZec04AB8LBf3L0lq9zYbUTQw+DYjDOZXQZx/vgAhT/+BIWio2w1emcllcWThP7ZXy1 8Pk7D+8/Q== X-Received: by 2002:a05:600c:5493:b0:493:c26e:d5e6 with SMTP id 5b1f17b1804b1-493c2b906damr16598955e9.5.1782914557070; Wed, 01 Jul 2026 07:02:37 -0700 (PDT) Received: from thomas-precision3591.paris.inria.fr (wifi-pro-82-131.paris.inria.fr. [128.93.82.131]) by smtp.googlemail.com with ESMTPSA id ffacd0b85a97d-477dde1a4fdsm85f8f.26.2026.07.01.07.02.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 01 Jul 2026 07:02:36 -0700 (PDT) From: Thomas Fourier To: Cc: Thomas Fourier , =?UTF-8?q?Toke=20H=C3=B8iland-J=C3=B8rgensen?= , Kalle Valo , Tetsuo Handa , linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] wifi: mt76: Fix missing barrier after initialization check in ath9k_wmi_event_tasklet() Date: Wed, 1 Jul 2026 15:57:44 +0200 Message-ID: <20260701135745.43208-2-fourier.thomas@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The write memory barrier in ath9k_htc_probe_device() before writing to priv->initialized, so it seems like one is also needed after reading it, but seems like there is none after reading priv->initialized. Add a read barrier after reading the priv->initialized flag to prevent reordering of reads. Fixes: 8b3046abc99e ("ath9k_htc: fix NULL pointer dereference at ath9k_htc_tx_get_packet()") Signed-off-by: Thomas Fourier --- drivers/net/wireless/ath/ath9k/wmi.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/drivers/net/wireless/ath/ath9k/wmi.c b/drivers/net/wireless/ath/ath9k/wmi.c index 284e8c13b043..1e28599a6146 100644 --- a/drivers/net/wireless/ath/ath9k/wmi.c +++ b/drivers/net/wireless/ath/ath9k/wmi.c @@ -160,6 +160,11 @@ void ath9k_wmi_event_tasklet(struct tasklet_struct *t) kfree_skb(skb); continue; } + /* + * Make sure ath9k_htc_probe_device() initialization is + * committed to memory before processing skb. + */ + smp_rmb(); hdr = (struct wmi_cmd_hdr *) skb->data; cmd_id = be16_to_cpu(hdr->command_id); -- 2.43.0