From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1BD31C44500 for ; Wed, 1 Jul 2026 16:17:41 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id A12DF10EECD; Wed, 1 Jul 2026 16:17:40 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="Xb96jpZE"; dkim-atps=neutral Received: from mail-wm1-f47.google.com (mail-wm1-f47.google.com [209.85.128.47]) by gabe.freedesktop.org (Postfix) with ESMTPS id DE75A10EECD for ; Wed, 1 Jul 2026 16:17:39 +0000 (UTC) Received: by mail-wm1-f47.google.com with SMTP id 5b1f17b1804b1-493c1950518so4662285e9.1 for ; Wed, 01 Jul 2026 09:17:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1782922658; x=1783527458; darn=lists.freedesktop.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=p/Vq/KrrHT2PIV2udEWzP9xO+YQv9/+rn4f2pkOy2ow=; b=Xb96jpZEiNZ+hH2wjTL2QLppEtdXPxVoTkjDsXkDWyjI9eGI8ulBKYAHK9t2J/I5ZH yXoJ40jRzMOn3RApL3PPLerfu87Tb3fdQL+WLdkWiPtYeHwM3DIQzLUElB37ojM0eeo+ D3M3WJWgS4Pa7XMvYXtyqrS2zvqaQUSTeEO66oEg6bSzwDwxx6/CvAinrscz1Q1PhY06 gUXAlDNyFyWCVq85Zim7AgYqdEDUsgQ4fa3WQNQPy0RhEAvyQa+bh3RkQr3VuSwTPJaJ pFYHwMEzgjpXrsd4lOatnZ5riUHoYUlTQ0g1Zf8AbFJ1lUgf3UfbRZTdZtmVbU67I2+s T2cA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782922658; x=1783527458; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=p/Vq/KrrHT2PIV2udEWzP9xO+YQv9/+rn4f2pkOy2ow=; b=jiCW2BypZwhR/ZzP9l4B1yUgsBymsYRvF1kvYNTke31H0PsvUY+BA0nTz6YAbe2vrd 41MCwRULYsHbqJVj9q0eZeb6qji24Bj5pQPQJAx2OOIjKRlUnfbfe6noKj862xzWw6i0 0nkHCsXEXvs91S2v6bXQQx733MsTjtYID3ZPXjzglxJF9X7rjTHFWbnh2CT2lGTpvWYE BINO4eZ3fEGKxZLzwAMayOPPi03kpM7/HXh/RGCopqdvwHdRqzE/1dzeyiQERsq3unrc Is+nNLvyp7rDTGYpTSoJPe5XOBuqa+5QtRDfM9EJH+mNxIRstQ2Cdss5ntGWb8K3TEJ9 Nz4A== X-Gm-Message-State: AOJu0YxlvemxP3U4P24u93Pp7hGa8sNvZjcYd4MmkjHg9/jGQzb+R1AU K9eaDFNQK3kE1d4LGrKzFKry4+ncmuC+mm6qDTRU5qeRHGJSlGZpe5eS/CiQGb75 X-Gm-Gg: AfdE7cnf8+miCDY7z7qV7RmIvkFZo5gUnxc9GyTujFC5/rZtnJHY6wd1Abu7KJyMCrl zMC5DtAMgFTe7Tzd8lDulCP9iE9EMBwfFv/qC1UBQEyGhLQJqiLYMWG69tjiII8BnJazhG0zlIx KNgah7/s5ErUkmS0pg8ht6FCBtHWO6qPVzrS6djUzxQJ6RKjulRqgt8LDCS+TkjIL97h4QAKyP+ /x0Mi+OgnDtwtBBtUbz1o/GzNbEWno/7HabfyTyFV2z0EzswMjVMzoNWchQVb56azBRexFqMmyR 23OBMaMWHLujV/gBQ6OHi1IbXiN3HHvBNTOgEtNYuaFg3xz6nE4zE3W2fMNAuZyOSE+8uKbBRCI br3H7mmwFwA0KQcTXajdvQ9hwwcRyiEhZxy90Gv0DG9et3a1CXfrU/Sl2XM+I96QHQEOVeNDKdp XAOAvFlI63mp41JK/F X-Received: by 2002:a05:600d:8488:10b0:492:3fb5:3a17 with SMTP id 5b1f17b1804b1-493c4cf158fmr983035e9.2.1782922658219; Wed, 01 Jul 2026 09:17:38 -0700 (PDT) Received: from Timur-Max ([212.108.193.106]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-493be81df2asm168812255e9.12.2026.07.01.09.17.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 01 Jul 2026 09:17:37 -0700 (PDT) From: =?UTF-8?q?Timur=20Krist=C3=B3f?= To: amd-gfx@lists.freedesktop.org, Alexander.Deucher@amd.com, =?UTF-8?q?Christian=20K=C3=B6nig?= , Natalie Vock , Amir Shetaia , =?UTF-8?q?Marek=20Ol=C5=A1=C3=A1k?= , Mario Limonciello , Tvrtko Ursulin , Felix Kuehling , Lijo Lazar , Siwei He , Philip Yang , Mukul Joshi Cc: =?UTF-8?q?Timur=20Krist=C3=B3f?= , Tvrtko Ursulin Subject: [PATCH 05/14] drm/amdgpu/ih6.1: Use IH_SW_RING_SIZE for soft IH ring instead of PAGE_SIZE Date: Wed, 1 Jul 2026 18:17:12 +0200 Message-ID: <20260701161721.85681-6-timur.kristof@gmail.com> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260701161721.85681-1-timur.kristof@gmail.com> References: <20260701161721.85681-1-timur.kristof@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: amd-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussion list for AMD gfx List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: amd-gfx-bounces@lists.freedesktop.org Sender: "amd-gfx" When there are a lot of retry faults happening, the soft IH ring can fill up really quickly and possibly overflow. PAGE_SIZE was too small, use IH_SW_RING_SIZE to match what other GPU generations are doing. Signed-off-by: Timur Kristóf Reviewed-by: Tvrtko Ursulin --- drivers/gpu/drm/amd/amdgpu/ih_v6_1.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdgpu/ih_v6_1.c b/drivers/gpu/drm/amd/amdgpu/ih_v6_1.c index 9dbc20131410..f6fdb3a950e0 100644 --- a/drivers/gpu/drm/amd/amdgpu/ih_v6_1.c +++ b/drivers/gpu/drm/amd/amdgpu/ih_v6_1.c @@ -590,7 +590,7 @@ static int ih_v6_1_sw_init(struct amdgpu_ip_block *ip_block) /* initialize ih control register offset */ ih_v6_1_init_register_offset(adev); - r = amdgpu_ih_ring_init(adev, &adev->irq.ih_soft, PAGE_SIZE, true); + r = amdgpu_ih_ring_init(adev, &adev->irq.ih_soft, IH_SW_RING_SIZE, true); if (r) return r; -- 2.54.0