From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from galois.linutronix.de (Galois.linutronix.de [193.142.43.55]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1DD473815E3; Wed, 1 Jul 2026 19:58:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=193.142.43.55 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782935928; cv=none; b=kewiYcim5VFRf0U7B5o/HSxkZnT70GefgDS7aO0z94ShJ1aq6RYFiSwkyZGMNpLou+7AZQYFxvxRCfAr2rKgfcBlwP+xrHVLNieTsQONJfs0syrc53kW6CDS6etxfK7lKFPakO/uZQbmPU5Jax+G5AvV1tQ4+X0CYIVutH0xcUQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782935928; c=relaxed/simple; bh=cC3grrbtW7yIMNoaBOflGzRt/Nk2jP+A2DZ0a6yP4kc=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=fnlIikAwtOPjKkyySQo8pf0VS16O/268WLkM3edXRsNmlMry+xg8wreJHTQ+UkPc1axXn5+OiuKR5EPvy3K5E0RoPWvvdvB8d/1YrD1EajrBYGWvzBibPjNZQhYl59Cys84cJd6astFcraal6g6TSvkjESFkBD3Jz2IHn/02ZGs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linutronix.de; spf=pass smtp.mailfrom=linutronix.de; dkim=pass (2048-bit key) header.d=linutronix.de header.i=@linutronix.de header.b=RAJ3Efqo; dkim=permerror (0-bit key) header.d=linutronix.de header.i=@linutronix.de header.b=1SUZz5LD; arc=none smtp.client-ip=193.142.43.55 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linutronix.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linutronix.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linutronix.de header.i=@linutronix.de header.b="RAJ3Efqo"; dkim=permerror (0-bit key) header.d=linutronix.de header.i=@linutronix.de header.b="1SUZz5LD" Date: Wed, 1 Jul 2026 21:58:42 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1782935924; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=HGRGPG5nxs0MWmKVH1XE9+ETMnAwiphDMI53H6S+Wgo=; b=RAJ3EfqoP6AG9c1WaCNIITbaruiAfTva7N92jqjyzHz99/OruOfTsQ9TCd5norcqHnFuwa K9sh09kmJbujZbohmQiFhoRumZZlkBpyLFNp1xSsQHibl5CYF+m/TJNK1JhQMyAn4LmeYK vdaEeUVaGAU+fb3jPhlEJA3GzYYBti4GYIH1mbLCU4yq2vg0A1P6iRNphahOyuLvRiQCzs G1ZivJCtGVTCUncdkOK4rty08ys6o4EvaF5DGpYcDpyLTW6lNjZo45NVlQ3WiTzvV04wgl nuZ/G2Tc5emil0fKKVXCMNNGwnTOt8sLqOwW9B3eQ381vduezgRl0dPzG4QrFg== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1782935924; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=HGRGPG5nxs0MWmKVH1XE9+ETMnAwiphDMI53H6S+Wgo=; b=1SUZz5LD4PErOtj5qqBP0NkzivGmhqyBp9E8O8FyVIUjOEo15F26+TZGAU3SxaFSaSBgu/ gXmhX52PlPw+fiAA== From: Sebastian Andrzej Siewior To: K Prateek Nayak Cc: Arnd Bergmann , Thomas Gleixner , Ingo Molnar , Peter Zijlstra , Borislav Petkov , Dave Hansen , x86@kernel.org, Catalin Marinas , Will Deacon , Paul Walmsley , Palmer Dabbelt , Albert Ou , Heiko Carstens , Vasily Gorbik , Alexander Gordeev , Darren Hart , Davidlohr Bueso , =?utf-8?B?QW5kcsOp?= Almeida , linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org, Samuel Holland , Charlie Jenkins , linux-arm-kernel@lists.infradead.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, "H. Peter Anvin" , Thomas Huth , Sean Christopherson , Jisheng Zhang , Alexandre Ghiti , Christian Borntraeger , Sven Schnelle Subject: Re: [PATCH v5 8/8] futex: Use runtime constants for __futex_hash() hot path Message-ID: <20260701195842.GKzb73-i@linutronix.de> References: <20260630045531.3939-1-kprateek.nayak@amd.com> <20260630045531.3939-9-kprateek.nayak@amd.com> Precedence: bulk X-Mailing-List: linux-arch@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable In-Reply-To: <20260630045531.3939-9-kprateek.nayak@amd.com> On 2026-06-30 04:55:31 [+0000], K Prateek Nayak wrote: > --- a/kernel/futex/core.c > +++ b/kernel/futex/core.c > @@ -395,13 +391,13 @@ __futex_hash(union futex_key *key, struct futex_pri= vate_hash *fph, struct futex_ > * NOTE: this isn't perfectly uniform, but it is fast and > * handles sparse node masks. > */ > - node =3D (hash >> futex_hashshift) % nr_node_ids; > + node =3D runtime_const_shift_right_32(hash, __futex_shift) % nr_node_i= ds; > if (!node_possible(node)) { > node =3D find_next_bit_wrap(node_possible_map.bits, nr_node_ids, node= ); > } I replaced this with: diff --git a/kernel/futex/core.c b/kernel/futex/core.c index 79e770d4d166..30d8622958d2 100644 --- a/kernel/futex/core.c +++ b/kernel/futex/core.c @@ -382,6 +382,7 @@ __futex_hash(union futex_key *key, struct futex_private= _hash *fph, struct futex_ key->both.offset); =20 if (node =3D=3D FUTEX_NO_NODE) { + u32 node_limit =3D nr_node_ids; /* * In case of !FLAGS_NUMA, use some unused hash bits to pick a * node -- this ensures regular futexes are interleaved across @@ -391,9 +392,9 @@ __futex_hash(union futex_key *key, struct futex_private= _hash *fph, struct futex_ * NOTE: this isn't perfectly uniform, but it is fast and * handles sparse node masks. */ - node =3D runtime_const_shift_right_32(hash, __futex_shift) % nr_node_ids; - if (!node_possible(node)) { - node =3D find_next_bit_wrap(node_possible_map.bits, nr_node_ids, node); + node =3D reciprocal_scale(hash, node_limit); + if (!node_possible(node)) { + node =3D find_next_bit_wrap(node_possible_map.bits, node_limit, node); } } =20 I don't think it is worse, I hardly see a change perf wise. Sometimes op/s is reported almost unchanged, sometimes it improves a bit. What it does it reads nr_node_ids only once (which has no effect here because I have no sparse node) and it replaces the shift + divl with imulq + shift. perf was pointing me to the divl but now it points to the imulq. =C2=AF\_(=E3=83=84)_/=C2=AF But having that div gone, can't be bad, can it? Sebastian From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 07550C43602 for ; Wed, 1 Jul 2026 19:59:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=NKkvZmfeM6IOLNb4E1hru+n+WBZGW93gsw6ono+QgHk=; b=AjRh5uhTVsyzm2 7yZgdpIMUJbBvmz9qb/RsjmyHgEzxek/EToSKiR3vpx7hZfnHZ6tGAF98VNY/s+2nsC3nUnIgwBiJ DhZqVlu0/WvKxvONCPYTWjww1iaDa0cIFaqG5u4WFyIvd+/oSSWXxvqJ6MfgUaG/yDC+21RSyDDO6 sh7AZnJu/T+Me4MNbOSOhVt4rJyf7ZV8SlVfk2z33g9fAFWIPVGg5P2+3vfiFz68w+xHl4khOlXva UroMq7ATpHydKP1sHhjLJZdv93cM93lD4cxSM2LFzI2RVoYjIYE/2r8abMmaTZRf0JanFwzYVMfRu 8wa4gdHmiSDq9e2Nr4/g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1wf158-00000002vji-3BZQ; Wed, 01 Jul 2026 19:58:50 +0000 Received: from galois.linutronix.de ([2a0a:51c0:0:12e:550::1]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1wf156-00000002vii-0KUx; Wed, 01 Jul 2026 19:58:49 +0000 Date: Wed, 1 Jul 2026 21:58:42 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1782935924; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=HGRGPG5nxs0MWmKVH1XE9+ETMnAwiphDMI53H6S+Wgo=; b=RAJ3EfqoP6AG9c1WaCNIITbaruiAfTva7N92jqjyzHz99/OruOfTsQ9TCd5norcqHnFuwa K9sh09kmJbujZbohmQiFhoRumZZlkBpyLFNp1xSsQHibl5CYF+m/TJNK1JhQMyAn4LmeYK vdaEeUVaGAU+fb3jPhlEJA3GzYYBti4GYIH1mbLCU4yq2vg0A1P6iRNphahOyuLvRiQCzs G1ZivJCtGVTCUncdkOK4rty08ys6o4EvaF5DGpYcDpyLTW6lNjZo45NVlQ3WiTzvV04wgl nuZ/G2Tc5emil0fKKVXCMNNGwnTOt8sLqOwW9B3eQ381vduezgRl0dPzG4QrFg== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1782935924; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=HGRGPG5nxs0MWmKVH1XE9+ETMnAwiphDMI53H6S+Wgo=; b=1SUZz5LD4PErOtj5qqBP0NkzivGmhqyBp9E8O8FyVIUjOEo15F26+TZGAU3SxaFSaSBgu/ gXmhX52PlPw+fiAA== From: Sebastian Andrzej Siewior To: K Prateek Nayak Cc: Arnd Bergmann , Thomas Gleixner , Ingo Molnar , Peter Zijlstra , Borislav Petkov , Dave Hansen , x86@kernel.org, Catalin Marinas , Will Deacon , Paul Walmsley , Palmer Dabbelt , Albert Ou , Heiko Carstens , Vasily Gorbik , Alexander Gordeev , Darren Hart , Davidlohr Bueso , =?utf-8?B?QW5kcsOp?= Almeida , linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org, Samuel Holland , Charlie Jenkins , linux-arm-kernel@lists.infradead.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, "H. Peter Anvin" , Thomas Huth , Sean Christopherson , Jisheng Zhang , Alexandre Ghiti , Christian Borntraeger , Sven Schnelle Subject: Re: [PATCH v5 8/8] futex: Use runtime constants for __futex_hash() hot path Message-ID: <20260701195842.GKzb73-i@linutronix.de> References: <20260630045531.3939-1-kprateek.nayak@amd.com> <20260630045531.3939-9-kprateek.nayak@amd.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20260630045531.3939-9-kprateek.nayak@amd.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260701_125848_256349_8217AA26 X-CRM114-Status: GOOD ( 13.62 ) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org T24gMjAyNi0wNi0zMCAwNDo1NTozMSBbKzAwMDBdLCBLIFByYXRlZWsgTmF5YWsgd3JvdGU6Cj4g LS0tIGEva2VybmVsL2Z1dGV4L2NvcmUuYwo+ICsrKyBiL2tlcm5lbC9mdXRleC9jb3JlLmMKPiBA QCAtMzk1LDEzICszOTEsMTMgQEAgX19mdXRleF9oYXNoKHVuaW9uIGZ1dGV4X2tleSAqa2V5LCBz dHJ1Y3QgZnV0ZXhfcHJpdmF0ZV9oYXNoICpmcGgsIHN0cnVjdCBmdXRleF8KPiAgCQkgKiBOT1RF OiB0aGlzIGlzbid0IHBlcmZlY3RseSB1bmlmb3JtLCBidXQgaXQgaXMgZmFzdCBhbmQKPiAgCQkg KiBoYW5kbGVzIHNwYXJzZSBub2RlIG1hc2tzLgo+ICAJCSAqLwo+IC0JCW5vZGUgPSAoaGFzaCA+ PiBmdXRleF9oYXNoc2hpZnQpICUgbnJfbm9kZV9pZHM7Cj4gKwkJbm9kZSA9IHJ1bnRpbWVfY29u c3Rfc2hpZnRfcmlnaHRfMzIoaGFzaCwgX19mdXRleF9zaGlmdCkgJSBucl9ub2RlX2lkczsKPiAg CQlpZiAoIW5vZGVfcG9zc2libGUobm9kZSkpIHsKPiAgCQkJbm9kZSA9IGZpbmRfbmV4dF9iaXRf d3JhcChub2RlX3Bvc3NpYmxlX21hcC5iaXRzLCBucl9ub2RlX2lkcywgbm9kZSk7Cj4gIAkJfQoK SSByZXBsYWNlZCB0aGlzIHdpdGg6CgpkaWZmIC0tZ2l0IGEva2VybmVsL2Z1dGV4L2NvcmUuYyBi L2tlcm5lbC9mdXRleC9jb3JlLmMKaW5kZXggNzllNzcwZDRkMTY2Li4zMGQ4NjIyOTU4ZDIgMTAw NjQ0Ci0tLSBhL2tlcm5lbC9mdXRleC9jb3JlLmMKKysrIGIva2VybmVsL2Z1dGV4L2NvcmUuYwpA QCAtMzgyLDYgKzM4Miw3IEBAIF9fZnV0ZXhfaGFzaCh1bmlvbiBmdXRleF9rZXkgKmtleSwgc3Ry dWN0IGZ1dGV4X3ByaXZhdGVfaGFzaCAqZnBoLCBzdHJ1Y3QgZnV0ZXhfCiAJCSAgICAgIGtleS0+ Ym90aC5vZmZzZXQpOwogCiAJaWYgKG5vZGUgPT0gRlVURVhfTk9fTk9ERSkgeworCQl1MzIgbm9k ZV9saW1pdCA9IG5yX25vZGVfaWRzOwogCQkvKgogCQkgKiBJbiBjYXNlIG9mICFGTEFHU19OVU1B LCB1c2Ugc29tZSB1bnVzZWQgaGFzaCBiaXRzIHRvIHBpY2sgYQogCQkgKiBub2RlIC0tIHRoaXMg ZW5zdXJlcyByZWd1bGFyIGZ1dGV4ZXMgYXJlIGludGVybGVhdmVkIGFjcm9zcwpAQCAtMzkxLDkg KzM5Miw5IEBAIF9fZnV0ZXhfaGFzaCh1bmlvbiBmdXRleF9rZXkgKmtleSwgc3RydWN0IGZ1dGV4 X3ByaXZhdGVfaGFzaCAqZnBoLCBzdHJ1Y3QgZnV0ZXhfCiAJCSAqIE5PVEU6IHRoaXMgaXNuJ3Qg cGVyZmVjdGx5IHVuaWZvcm0sIGJ1dCBpdCBpcyBmYXN0IGFuZAogCQkgKiBoYW5kbGVzIHNwYXJz ZSBub2RlIG1hc2tzLgogCQkgKi8KLQkJbm9kZSA9IHJ1bnRpbWVfY29uc3Rfc2hpZnRfcmlnaHRf MzIoaGFzaCwgX19mdXRleF9zaGlmdCkgJSBucl9ub2RlX2lkczsKLQkJaWYgKCFub2RlX3Bvc3Np YmxlKG5vZGUpKSB7Ci0JCQlub2RlID0gZmluZF9uZXh0X2JpdF93cmFwKG5vZGVfcG9zc2libGVf bWFwLmJpdHMsIG5yX25vZGVfaWRzLCBub2RlKTsKKwkJbm9kZSA9IHJlY2lwcm9jYWxfc2NhbGUo aGFzaCwgbm9kZV9saW1pdCk7CisJCWlmICghbm9kZV9wb3NzaWJsZShub2RlKSkgeworCQkJbm9k ZSA9IGZpbmRfbmV4dF9iaXRfd3JhcChub2RlX3Bvc3NpYmxlX21hcC5iaXRzLCBub2RlX2xpbWl0 LCBub2RlKTsKIAkJfQogCX0KIApJIGRvbid0IHRoaW5rIGl0IGlzIHdvcnNlLCBJIGhhcmRseSBz ZWUgYSBjaGFuZ2UgcGVyZiB3aXNlLiBTb21ldGltZXMKb3AvcyBpcyByZXBvcnRlZCBhbG1vc3Qg dW5jaGFuZ2VkLCBzb21ldGltZXMgaXQgaW1wcm92ZXMgYSBiaXQuCgpXaGF0IGl0IGRvZXMgaXQg cmVhZHMgbnJfbm9kZV9pZHMgb25seSBvbmNlICh3aGljaCBoYXMgbm8gZWZmZWN0IGhlcmUKYmVj YXVzZSBJIGhhdmUgbm8gc3BhcnNlIG5vZGUpIGFuZCBpdCByZXBsYWNlcyB0aGUgc2hpZnQgKyBk aXZsIHdpdGgKaW11bHEgKyBzaGlmdC4KCnBlcmYgd2FzIHBvaW50aW5nIG1lIHRvIHRoZSBkaXZs IGJ1dCBub3cgaXQgcG9pbnRzIHRvIHRoZSBpbXVscS4Kwq9cXyjjg4QpXy/CrwoKQnV0IGhhdmlu ZyB0aGF0IGRpdiBnb25lLCBjYW4ndCBiZSBiYWQsIGNhbiBpdD8KClNlYmFzdGlhbgoKX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KbGludXgtcmlzY3YgbWFp bGluZyBsaXN0CmxpbnV4LXJpc2N2QGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xpc3RzLmlu ZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1yaXNjdgo=