From: kernel test robot <lkp@intel.com>
To: cros-kernel-buildreports@googlegroups.com
Cc: oe-kbuild-all@lists.linux.dev
Subject: [android-common:android14-kiwi-6.1 163/163] drivers/clk/mediatek/clk-mtk.c:502:2-3: Unneeded semicolon
Date: Wed, 01 Jul 2026 20:25:15 +0800 [thread overview]
Message-ID: <202607012046.iGlugHTe-lkp@intel.com> (raw)
tree: https://android.googlesource.com/kernel/common android14-kiwi-6.1
head: 7ea8561424f829e489de39c2eb31a398cc827369
commit: c1d87d56af063c87961511ee25f6b07a5676d27d [163/163] clk: mediatek: clk-mtk: Extend mtk_clk_simple_probe()
config: arm64-randconfig-r061-20260701 (https://download.01.org/0day-ci/archive/20260701/202607012046.iGlugHTe-lkp@intel.com/config)
compiler: aarch64-linux-gcc (GCC) 14.3.0
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202607012046.iGlugHTe-lkp@intel.com/
cocci warnings: (new ones prefixed by >>)
>> drivers/clk/mediatek/clk-mtk.c:502:2-3: Unneeded semicolon
vim +502 drivers/clk/mediatek/clk-mtk.c
449
450 int mtk_clk_simple_probe(struct platform_device *pdev)
451 {
452 const struct mtk_clk_desc *mcd;
453 struct clk_hw_onecell_data *clk_data;
454 struct device_node *node = pdev->dev.of_node;
455 void __iomem *base;
456 int num_clks, r;
457
458 mcd = of_device_get_match_data(&pdev->dev);
459 if (!mcd)
460 return -EINVAL;
461
462 /* Composite clocks needs us to pass iomem pointer */
463 if (mcd->composite_clks) {
464 if (!mcd->shared_io)
465 base = devm_platform_ioremap_resource(pdev, 0);
466 else
467 base = of_iomap(node, 0);
468
469 if (IS_ERR_OR_NULL(base))
470 return IS_ERR(base) ? PTR_ERR(base) : -ENOMEM;
471 }
472
473 /* Calculate how many clk_hw_onecell_data entries to allocate */
474 num_clks = mcd->num_clks + mcd->num_composite_clks;
475 num_clks += mcd->num_fixed_clks + mcd->num_factor_clks;
476 num_clks += mcd->num_mux_clks;
477
478 clk_data = mtk_alloc_clk_data(num_clks);
479 if (!clk_data)
480 return -ENOMEM;
481
482 if (mcd->fixed_clks) {
483 r = mtk_clk_register_fixed_clks(mcd->fixed_clks,
484 mcd->num_fixed_clks, clk_data);
485 if (r)
486 goto free_data;
487 }
488
489 if (mcd->factor_clks) {
490 r = mtk_clk_register_factors(mcd->factor_clks,
491 mcd->num_factor_clks, clk_data);
492 if (r)
493 goto unregister_fixed_clks;
494 }
495
496 if (mcd->mux_clks) {
497 r = mtk_clk_register_muxes(&pdev->dev, mcd->mux_clks,
498 mcd->num_mux_clks, node,
499 mcd->clk_lock, clk_data);
500 if (r)
501 goto unregister_factors;
> 502 };
503
504 if (mcd->composite_clks) {
505 /* We don't check composite_lock because it's optional */
506 r = mtk_clk_register_composites(&pdev->dev,
507 mcd->composite_clks,
508 mcd->num_composite_clks,
509 base, mcd->clk_lock, clk_data);
510 if (r)
511 goto unregister_muxes;
512 }
513
514 if (mcd->clks) {
515 r = mtk_clk_register_gates(&pdev->dev, node, mcd->clks,
516 mcd->num_clks, clk_data);
517 if (r)
518 goto unregister_composites;
519 }
520
521 r = of_clk_add_hw_provider(node, of_clk_hw_onecell_get, clk_data);
522 if (r)
523 goto unregister_clks;
524
525 platform_set_drvdata(pdev, clk_data);
526
527 if (mcd->rst_desc) {
528 r = mtk_register_reset_controller_with_dev(&pdev->dev,
529 mcd->rst_desc);
530 if (r)
531 goto unregister_clks;
532 }
533
534 return r;
535
536 unregister_clks:
537 if (mcd->clks)
538 mtk_clk_unregister_gates(mcd->clks, mcd->num_clks, clk_data);
539 unregister_composites:
540 if (mcd->composite_clks)
541 mtk_clk_unregister_composites(mcd->composite_clks,
542 mcd->num_composite_clks, clk_data);
543 unregister_muxes:
544 if (mcd->mux_clks)
545 mtk_clk_unregister_muxes(mcd->mux_clks,
546 mcd->num_mux_clks, clk_data);
547 unregister_factors:
548 if (mcd->factor_clks)
549 mtk_clk_unregister_factors(mcd->factor_clks,
550 mcd->num_factor_clks, clk_data);
551 unregister_fixed_clks:
552 if (mcd->fixed_clks)
553 mtk_clk_unregister_fixed_clks(mcd->fixed_clks,
554 mcd->num_fixed_clks, clk_data);
555 free_data:
556 mtk_free_clk_data(clk_data);
557 if (mcd->shared_io && base)
558 iounmap(base);
559 return r;
560 }
561 EXPORT_SYMBOL_GPL(mtk_clk_simple_probe);
562
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
reply other threads:[~2026-07-01 12:26 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202607012046.iGlugHTe-lkp@intel.com \
--to=lkp@intel.com \
--cc=cros-kernel-buildreports@googlegroups.com \
--cc=oe-kbuild-all@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.