From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f171.google.com (mail-pl1-f171.google.com [209.85.214.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 73BE436F908 for ; Wed, 1 Jul 2026 20:59:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.171 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782939558; cv=none; b=Ta1XcfrCJRKpysWAHCaSTgAJ8u5MCTNXzflpZDDNKG8ONsAMnO7h53GK5fBhv7YlTPPfgehlK3XiBKCkVQzJ3BpvjiBw88JE3MXYL+xdjrxsO8KrmA883ue+7N8JuAean0GNIp069fnOMGURJr0I2EytKJ4yY2Tyj7YLOge6GX8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782939558; c=relaxed/simple; bh=yb4QIfSLDkL7L9KlQAQUDVQcfZD1rIH+T1Oim2w0ycM=; h=Date:From:To:Cc:Subject:Message-ID:MIME-Version:Content-Type: Content-Disposition; b=q4A1IAUrY0CT4IGnOETDWMBQ99DMJR2hmPDZckZah8Zo40jO72n//+mVTBHo8+XEWf48FuSluXWFhWvxQRr8E7coqbm8+6Rbg4yV8NeD3phZgx94xsTP0dkQgAllhU4Eec1UOcskUKQEpio29bUvuBCP3sB4p8K9w4xq24/cJQk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=G4n31r+k; arc=none smtp.client-ip=209.85.214.171 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="G4n31r+k" Received: by mail-pl1-f171.google.com with SMTP id d9443c01a7336-2c9bd2f8bf7so17811925ad.1 for ; Wed, 01 Jul 2026 13:59:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1782939557; x=1783544357; darn=vger.kernel.org; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :from:to:cc:subject:date:message-id:reply-to; bh=j/phQQwxkE2YFm7rrBK6bZyOrlBII3i1ZJWmJmnbNmo=; b=G4n31r+kKEIHHYA24W/xyejftlJnBCEBm6oB6YecKlNKXjImqJjBTPo5bVbZVhyGzB Ga4YJ58Ig8j6wyGuARwu7e1zR9FJAbp0g4MaBUVfUOCY65LdpA91cKqKv/KyhswjVGeY iQ/aLvVl8lKy/rRRDyXBMc4kZRkC76honDhSR4ZPF5bQ/JrqzyWq5Jt6GvZZATWAj3pn iW8mdKlLcBiH0Se/zRaEfNb5oYChGvLcEkb5ORg0gqaEW9JL9Q3KiucPZdZiW+el5D27 apUMcKt8H9UMYYu5wPVd6Peg4dCqEZ8OtCxTTOlOLR7hYUrVllSrMGjGj6hMyTob7Hri hOuA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782939557; x=1783544357; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=j/phQQwxkE2YFm7rrBK6bZyOrlBII3i1ZJWmJmnbNmo=; b=cyTL3BTdn/ZtJNMpA3ZnLBUgHkaIKsQOwo9RXJdojrp/E9i12iAUm0/g32wtnPlD0B 1kxkD2cqZiDDxW5f7vqM0aL5qxp9qubqf/oRGh0hDqAHtkkQX6FY8u3D9Ht4UMSJswXS xY2ElIHA+IoTZnxxCJG3dL0Tk1hi891I2Xsq3bb02KLL9znGhmmPddx4FEFl67CQyOoj PwBLK+k4eTJ+4aXSZYnF1C4II/21C4VdO33QxXSJ8AAZVWDzKoph/JqwjwHNqZj0xyyK DSk4/5yI1gcppMpI8p8eddVJe0WaFXLLLfu7uZRjXA2MSTPSDkkHy3EmXdeM6wB5jf7+ FvtQ== X-Forwarded-Encrypted: i=1; AHgh+RpCv8vI/bVzSesYC2OYrk7aEsQPgtBWa6NFSsYpqIaKVQ8JkXnjwL9uAueGlf+w2mTESr4ETWORwmeK4t0=@vger.kernel.org X-Gm-Message-State: AOJu0Yy6q7QPrWoVQxdCPf+0HaniijxoU8dGmKTwTJYeAuIE4hBhan88 1RlTsOrOtOhUvIVHZN2mkk/JnrXntKi6ekgg+Ob+tW265+Pcp93btIpB X-Gm-Gg: AfdE7cn6dn0F909ZCfaEs0MbNZNoVq1GASWii8NuS1uboQkE8LV1D79OSwwLpC135jB 5+Vo3if7zIaojrjbbmnUaWG48UHhi6eENDJh/qw7CMrFhaqqwS6HvqXvoZ3BbmUQeRrHaqyOxu8 YmD+DIWsIR0OiPiEhPkST3BhcXCGY3LyM7yoJBZXvnS0khnFVPOvRReyiGpPOVY7BysVOsw5aJf MeF4HvqKwq4hwFnntCgYgCPPIIkXD/59v8KsTLZv7we55ccxG23l8uYsT7MJVz9+53JDWLido4Z FkCuNNSefjDP4NSXsxi2s5CHBlJQT7yjokWRivA5L/iPLKlL+4qQJH4ZTROXO2uj5BDCqXOOCRp 8iizuiJvznfXzkdlGxS9YshG0C3TlzpGAa5yApgod37yTDVDhDMG4Qqx+dtn7OZ1EPeoKbM2rmC YvZb6MvqdOVtCwGQ== X-Received: by 2002:a17:903:26cb:b0:2bd:5ae4:26d1 with SMTP id d9443c01a7336-2ca44a05f3amr60752555ad.17.1782939556538; Wed, 01 Jul 2026 13:59:16 -0700 (PDT) Received: from syednwaris ([2401:4900:1c8a:a60b:b883:ad5c:cd79:859d]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-13b3c870effsm1314988c88.12.2026.07.01.13.59.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 01 Jul 2026 13:59:16 -0700 (PDT) Date: Thu, 2 Jul 2026 02:28:57 +0530 From: Syed Nayyar Waris To: wbg@kernel.org Cc: gregkh@linuxfoundation.org, rafael@kernel.org, dakr@kernel.org, driver-core@lists.linux.dev, linux-kernel@vger.kernel.org, syednwaris@gmail.com Subject: [PATCH v2] isa: refactor code to remove nested blocks Message-ID: <20260701205857.GA4113@syednwaris> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Remove nested blocks in isa_bus_init(). This will make the module easy-to-understand and make the code clearer. Previous discussion regarding this change can be found at below link: https://lore.kernel.org/all/20260504063518.515620-1-wbg@kernel.org/ Acked-by: William Breathitt Gray Suggested-by: William Breathitt Gray Signed-off-by: Syed Nayyar Waris --- Changes in v2: - Make the patch description more comprehensive and thorough in its explanation --- drivers/base/isa.c | 16 +++++++++------- 1 file changed, 9 insertions(+), 7 deletions(-) diff --git a/drivers/base/isa.c b/drivers/base/isa.c index 5887e4211f80..4e9f68080f39 100644 --- a/drivers/base/isa.c +++ b/drivers/base/isa.c @@ -166,14 +166,16 @@ static int __init isa_bus_init(void) int error; error = bus_register(&isa_bus_type); - if (!error) { - isa_bus = root_device_register("isa"); - if (IS_ERR(isa_bus)) { - error = PTR_ERR(isa_bus); - bus_unregister(&isa_bus_type); - } + if (error) + return error; + + isa_bus = root_device_register("isa"); + if (IS_ERR(isa_bus)) { + bus_unregister(&isa_bus_type); + return PTR_ERR(isa_bus); } - return error; + + return 0; } postcore_initcall(isa_bus_init); -- 2.25.1