From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D9E44C43458 for ; Thu, 2 Jul 2026 00:06:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Reply-To:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:Message-Id:Date: References:In-Reply-To:Cc:To:Subject:From:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=4dsDVBtWaEWJe0CVHxwmW4oroEy2TbQyj/V4UTkmEmU=; b=Z+zlevtUhL/EUj 2gHhlBgktnzPkU+SSkEqvXt258BtPhKiHF6a4tcxWzqezEtJLeNyMe3C1vJmaEppRVClx6ZRXVPWf 4AoSMBbM4qQd8n6ID+DJZ7sDjkzngUGGV2S/SE3wNUL1PM/KIa0MDFNaAARa9TrEPJSV2ZZPQfVKD yH35DmhXP/hSnA8qcSiXHBVOl5BowzGKosWz0d8dUqHi/QOTOUPzbt09V966wSSEQNfihrYf/lJ+c Es+O04e+j8JKRWSKIqs41Rp3N15VwgAGeg9YxKDMQltU16N6CBxCghgxtYcZdoKjs4Wk3VVe24h/J NGA+uA9Ip5mzi9WZvdmQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1wf4xE-00000003Gf4-2mp5; Thu, 02 Jul 2026 00:06:56 +0000 Received: from tor.source.kernel.org ([2600:3c04:e001:324:0:1991:8:25]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1wf4xC-00000003Gew-45dW for linux-phy@lists.infradead.org; Thu, 02 Jul 2026 00:06:55 +0000 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by tor.source.kernel.org (Postfix) with ESMTP id 25C976001D; Thu, 2 Jul 2026 00:06:54 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5B7D71F000E9; Thu, 2 Jul 2026 00:06:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1782950813; bh=BQwRPwZ8hEdTWdaM4RjwFdd6tjVYQo+WdFyfomYDeGg=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=ivnOIbTCX6RUa/TKl0ikH9xhA5qTigoAnFRII6dzRtN6b3HoMn8b4NlYgPChPkHAI 7HrD8jtp8uxOF1lWaERYlRKAkl09LfDKr9V1OiSLfQfcNylYrbw+f0t8ae41N+bhb0 8PnDcd9TCzETpPIPJTOIJ1J5f2ZbyIljCNUAFIbEHQ3BhXgFJacvg7RPqtZLwr2nC8 r9NJc4C3z4HPRH2IQUQC9hSLqIWYW6wIg73ZvaR2ScMPgcNb90efhfAewOAPAM3gCC H743HvipfpflAVkFB8YPbsKNjYmFbtZwLmtiXpEnmjb7rL4dg8RYk2t/Y0kOC5rhoa UIZ8lh60eKqxw== From: sashiko-bot@kernel.org Subject: Re: [PATCH v9 31/38] phy: core: add notifier infrastructure To: "Sebastian Reichel" Cc: linux-phy@lists.infradead.org, conor+dt@kernel.org, neil.armstrong@linaro.org, devicetree@vger.kernel.org, robh@kernel.org, olteanv@gmail.com, vkoul@kernel.org In-Reply-To: <20260702-rockchip-usbdp-cleanup-v9-31-e31efbb62d2e@collabora.com> References: <20260702-rockchip-usbdp-cleanup-v9-0-e31efbb62d2e@collabora.com> <20260702-rockchip-usbdp-cleanup-v9-31-e31efbb62d2e@collabora.com> Date: Thu, 02 Jul 2026 00:06:52 +0000 Message-Id: <20260702000653.5B7D71F000E9@smtp.kernel.org> X-BeenThere: linux-phy@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux Phy Mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: sashiko-reviews@lists.linux.dev MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-phy" Errors-To: linux-phy-bounces+linux-phy=archiver.kernel.org@lists.infradead.org VGhhbmsgeW91IGZvciB5b3VyIGNvbnRyaWJ1dGlvbiEgU2FzaGlrbyBBSSByZXZpZXcgZm91bmQg MSBwb3RlbnRpYWwgaXNzdWUocykgdG8gY29uc2lkZXI6Ci0gW01lZGl1bV0gYHBoeV9ub3RpZnlf cmVzZXRgIHJldHVybnMgdGhlIHJhdyBub3RpZmllciBjaGFpbiBzdGF0dXMgaW5zdGVhZCBvZiBh IHN0YW5kYXJkIG5lZ2F0aXZlIGVycm9yIGNvZGUsIHZpb2xhdGluZyBpdHMgZG9jdW1lbnRlZCBy ZXR1cm4gdmFsdWVzIGFuZCBicmVha2luZyBlcnJvciBjaGVja2luZyBmb3IgY2FsbGVycy4KLS0K CmNvbW1pdCA2ZDhjNjZhNjlmMGE4NGNkYzM0YjViMDU2YzQyZDNjYzM1Y2I3NzFlCkF1dGhvcjog U2ViYXN0aWFuIFJlaWNoZWwgPHNlYmFzdGlhbi5yZWljaGVsQGNvbGxhYm9yYS5jb20+CgpwaHk6 IGNvcmU6IGFkZCBub3RpZmllciBpbmZyYXN0cnVjdHVyZQoKVGhpcyBjb21taXQgYWRkcyBhIG5l dyBQSFkgbm90aWZpZXIgQVBJIHRvIGFsbG93IGNvbnN1bWVyIGRyaXZlcnMgdG8gaG9vawppbnRv IHJlc2V0IGV2ZW50cyBjb21pbmcgZnJvbSBhIFBIWSBkZXZpY2UuIFRoaXMgaGVscHMgZ3JhY2Vm dWxseSBoYW5kbGUKc2l0dWF0aW9ucyB3aGVyZSBQSFkgZGV2aWNlcyByZXF1aXJlIGEgcmVzZXQg ZHVlIHRvIGNvbmZpZ3VyYXRpb24gb3IgY2FibGUKb3JpZW50YXRpb24gY2hhbmdlcy4KCj4gZGlm ZiAtLWdpdCBhL2RyaXZlcnMvcGh5L3BoeS1jb3JlLmMgYi9kcml2ZXJzL3BoeS9waHktY29yZS5j Cj4gaW5kZXggMjFhYWYyZjc2ZTUzZS4uNTMzNDczZDk3NWQzNyAxMDA2NDQKPiAtLS0gYS9kcml2 ZXJzL3BoeS9waHktY29yZS5jCj4gKysrIGIvZHJpdmVycy9waHkvcGh5LWNvcmUuYwo+IEBAIC01 NDIsNiArNTQyLDYyIEBAIGludCBwaHlfbm90aWZ5X3N0YXRlKHN0cnVjdCBwaHkgKnBoeSwgdW5p b24gcGh5X25vdGlmeSBzdGF0ZSkKWyAuLi4gXQo+ICsvKioKPiArICogcGh5X25vdGlmeV9yZXNl dCgpIC0gbm90aWZ5IGNvbnN1bWVycyBvZiBhIFBIWSByZXNldCBldmVudAo+ICsgKiBAcGh5OiB0 aGUgcGh5IHRoYXQgaXMgYmVpbmcgcmVzZXQKPiArICogQGV2ZW50OiB0aGUgbm90aWZpY2F0aW9u IGV2ZW50IChQUkVfUkVTRVQgb3IgUE9TVF9SRVNFVCkKPiArICoKPiArICogQ2FsbGVkIGJ5IFBI WSBwcm92aWRlcnMgdG8gbm90aWZ5IGNvbnN1bWVycyB0aGF0IHRoZSBQSFkgaXMgYWJvdXQgdG8K PiArICogYmUgcmVzZXQgb3IgaGFzIGNvbXBsZXRlZCBhIHJlc2V0LiBUaGlzIGFsbG93cyBjb25z dW1lcnMgdG8gcXVpZXNjZQo+ICsgKiBoYXJkd2FyZSBiZWZvcmUgdGhlIFBIWSBiZWNvbWVzIHVu YXZhaWxhYmxlLgo+ICsgKgo+ICsgKiBSZXR1cm5zOiAlMCBpZiBzdWNjZXNzZnVsIG9yIG5vIG5v dGlmaWVycyByZWdpc3RlcmVkLCBhIG5lZ2F0aXZlIGVycm9yCj4gKyAqIGNvZGUgaWYgYSBub3Rp ZmllciByZXR1cm5zIGFuIGVycm9yIChmb3IgUFJFX1JFU0VUIG9ubHkpCj4gKyAqLwo+ICtpbnQg cGh5X25vdGlmeV9yZXNldChzdHJ1Y3QgcGh5ICpwaHksIGVudW0gcGh5X25vdGlmaWNhdGlvbiBl dmVudCkKPiArewo+ICsJaWYgKCFwaHkpCj4gKwkJcmV0dXJuIDA7Cj4gKwo+ICsJcmV0dXJuIGJs b2NraW5nX25vdGlmaWVyX2NhbGxfY2hhaW4oJnBoeS0+bm90aWZpZXIsIGV2ZW50LCBwaHkpOwoK W1NldmVyaXR5OiBNZWRpdW1dCkRvZXMgdGhpcyByZXR1cm4gdGhlIHJhdyBub3RpZmllciBjaGFp biBzdGF0dXMgKGxpa2UgTk9USUZZX09LIG9yIE5PVElGWV9CQUQpCmluc3RlYWQgb2YgdGhlIGRv Y3VtZW50ZWQgbmVnYXRpdmUgZXJyb3IgY29kZT8KCklmIGNhbGxlcnMgY2hlY2sgdGhlIHJldHVy biB2YWx1ZSB3aXRoIGBpZiAocmV0IDwgMClgLCB0aGV5IHdpbGwgZmFpbCB0bwpkZXRlY3QgZXJy b3JzIHNpbmNlIE5PVElGWV9CQUQgYW5kIG5vdGlmaWVyX2Zyb21fZXJybm8oKSByZXN1bHRzIGFy ZSBwb3NpdGl2ZQppbnRlZ2Vycy4gQWxzbywgY2hlY2tpbmcgYGlmIChyZXQpYCBtaWdodCBmYWxz ZWx5IGRldGVjdCBhbiBlcnJvciBvbiBzdWNjZXNzCmJlY2F1c2UgTk9USUZZX09LIGlzIDEuCgpT aG91bGQgdGhpcyB1c2Ugbm90aWZpZXJfdG9fZXJybm8oKSB0byBjb252ZXJ0IHRoZSByZXR1cm4g dmFsdWUgYmVmb3JlIHBhc3NpbmcKaXQgYmFjayB0byB0aGUgY2FsbGVyPwoKPiArfQo+ICtFWFBP UlRfU1lNQk9MX0dQTChwaHlfbm90aWZ5X3Jlc2V0KTsKCi0tIApTYXNoaWtvIEFJIHJldmlldyDC tyBodHRwczovL3Nhc2hpa28uZGV2LyMvcGF0Y2hzZXQvMjAyNjA3MDItcm9ja2NoaXAtdXNiZHAt Y2xlYW51cC12OS0wLWUzMWVmYmI2MmQyZUBjb2xsYWJvcmEuY29tP3BhcnQ9MzEKCi0tIApsaW51 eC1waHkgbWFpbGluZyBsaXN0CmxpbnV4LXBoeUBsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHBzOi8v bGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LXBoeQo= From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2ED42625 for ; Thu, 2 Jul 2026 00:06:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782950815; cv=none; b=EE52x4BTDwUbyaAJateQsrQJzIOowjthn1Q4hgxn98evdYUgaOUDc7+q6qo7e88GIabJYOE2Fv/iZFL3dKIPuP0BHmqgyQM2X1npAaOpdViXyL1NNvWFKtyfYv8pMzk7V9ncnWKWVY7iVTmVBtqcJNedOOLqBz4+Qhu7antVht4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782950815; c=relaxed/simple; bh=ovYDg50TRAX1f5BDzt5ralnvA4w73rSTHb5mV9p0+Z4=; h=From:Subject:To:Cc:In-Reply-To:References:Content-Type:Date: Message-Id; b=pMLipRVC4KttO8Q6LsehzxIqNuMbFscS7mQNSrp9tRL2LCGku6E5OaGlQ2jfmDsX4kcXiGsuh9BoJJs7elCT99PGWnVDAIgdQfN1WPaSrzoxgIAHgXZwsDc8D7nYzKUz2vcXJW+fZX5xPCd0dkt36KkiElOzR5t4vxF8pUoDH+I= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=ivnOIbTC; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="ivnOIbTC" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5B7D71F000E9; Thu, 2 Jul 2026 00:06:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1782950813; bh=BQwRPwZ8hEdTWdaM4RjwFdd6tjVYQo+WdFyfomYDeGg=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=ivnOIbTCX6RUa/TKl0ikH9xhA5qTigoAnFRII6dzRtN6b3HoMn8b4NlYgPChPkHAI 7HrD8jtp8uxOF1lWaERYlRKAkl09LfDKr9V1OiSLfQfcNylYrbw+f0t8ae41N+bhb0 8PnDcd9TCzETpPIPJTOIJ1J5f2ZbyIljCNUAFIbEHQ3BhXgFJacvg7RPqtZLwr2nC8 r9NJc4C3z4HPRH2IQUQC9hSLqIWYW6wIg73ZvaR2ScMPgcNb90efhfAewOAPAM3gCC H743HvipfpflAVkFB8YPbsKNjYmFbtZwLmtiXpEnmjb7rL4dg8RYk2t/Y0kOC5rhoa UIZ8lh60eKqxw== From: sashiko-bot@kernel.org Subject: Re: [PATCH v9 31/38] phy: core: add notifier infrastructure Reply-To: sashiko-reviews@lists.linux.dev To: "Sebastian Reichel" Cc: linux-phy@lists.infradead.org, conor+dt@kernel.org, neil.armstrong@linaro.org, devicetree@vger.kernel.org, robh@kernel.org, olteanv@gmail.com, vkoul@kernel.org In-Reply-To: <20260702-rockchip-usbdp-cleanup-v9-31-e31efbb62d2e@collabora.com> References: <20260702-rockchip-usbdp-cleanup-v9-0-e31efbb62d2e@collabora.com> <20260702-rockchip-usbdp-cleanup-v9-31-e31efbb62d2e@collabora.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Thu, 02 Jul 2026 00:06:52 +0000 Message-Id: <20260702000653.5B7D71F000E9@smtp.kernel.org> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Thank you for your contribution! Sashiko AI review found 1 potential issue(= s) to consider: - [Medium] `phy_notify_reset` returns the raw notifier chain status instead= of a standard negative error code, violating its documented return values = and breaking error checking for callers. -- commit 6d8c66a69f0a84cdc34b5b056c42d3cc35cb771e Author: Sebastian Reichel phy: core: add notifier infrastructure This commit adds a new PHY notifier API to allow consumer drivers to hook into reset events coming from a PHY device. This helps gracefully handle situations where PHY devices require a reset due to configuration or cable orientation changes. > diff --git a/drivers/phy/phy-core.c b/drivers/phy/phy-core.c > index 21aaf2f76e53e..533473d975d37 100644 > --- a/drivers/phy/phy-core.c > +++ b/drivers/phy/phy-core.c > @@ -542,6 +542,62 @@ int phy_notify_state(struct phy *phy, union phy_noti= fy state) [ ... ] > +/** > + * phy_notify_reset() - notify consumers of a PHY reset event > + * @phy: the phy that is being reset > + * @event: the notification event (PRE_RESET or POST_RESET) > + * > + * Called by PHY providers to notify consumers that the PHY is about to > + * be reset or has completed a reset. This allows consumers to quiesce > + * hardware before the PHY becomes unavailable. > + * > + * Returns: %0 if successful or no notifiers registered, a negative error > + * code if a notifier returns an error (for PRE_RESET only) > + */ > +int phy_notify_reset(struct phy *phy, enum phy_notification event) > +{ > + if (!phy) > + return 0; > + > + return blocking_notifier_call_chain(&phy->notifier, event, phy); [Severity: Medium] Does this return the raw notifier chain status (like NOTIFY_OK or NOTIFY_BA= D) instead of the documented negative error code? If callers check the return value with `if (ret < 0)`, they will fail to detect errors since NOTIFY_BAD and notifier_from_errno() results are positi= ve integers. Also, checking `if (ret)` might falsely detect an error on success because NOTIFY_OK is 1. Should this use notifier_to_errno() to convert the return value before pass= ing it back to the caller? > +} > +EXPORT_SYMBOL_GPL(phy_notify_reset); --=20 Sashiko AI review =C2=B7 https://sashiko.dev/#/patchset/20260702-rockchip-u= sbdp-cleanup-v9-0-e31efbb62d2e@collabora.com?part=3D31