From: phucduc.bui@gmail.com
To: Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>
Cc: cassiogabrielcontato@gmail.com,
Cezary Rojewski <cezary.rojewski@intel.com>,
Kees Cook <kees@kernel.org>, Ziqing Chen <chenziqing@xiaomi.com>,
HariKrishna Sagala <hariconscious@gmail.com>,
Dan Carpenter <error27@gmail.com>,
Cen Zhang <zzzccc427@gmail.com>, Len Bao <len.bao@gmx.us>,
HanQuan <eilaimemedsnaimel@gmail.com>,
Kyle Zeng <kylebot@openai.com>,
Dewei Meng <mengdewei@cqsoftware.com.cn>,
Maoyi Xie <maoyixie.tju@gmail.com>,
Mehul Rao <mehulrao@gmail.com>,
Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
Nathan Chancellor <nathan@kernel.org>,
linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org,
bui duc phuc <phucduc.bui@gmail.com>
Subject: [PATCH v2 5/7] ALSA: rawmidi: Drop redundant stream_open() return check
Date: Thu, 2 Jul 2026 15:44:42 +0700 [thread overview]
Message-ID: <20260702084445.519669-6-phucduc.bui@gmail.com> (raw)
In-Reply-To: <20260702084445.519669-1-phucduc.bui@gmail.com>
From: bui duc phuc <phucduc.bui@gmail.com>
The previous conversion from nonseekable_open() to stream_open() retained
the existing error check.
Since stream_open() always returns 0, remove the dead error handling path.
Signed-off-by: bui duc phuc <phucduc.bui@gmail.com>
---
sound/core/rawmidi.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/sound/core/rawmidi.c b/sound/core/rawmidi.c
index 4dfd9d53e6d3..789254a88e53 100644
--- a/sound/core/rawmidi.c
+++ b/sound/core/rawmidi.c
@@ -441,9 +441,7 @@ static int snd_rawmidi_open(struct inode *inode, struct file *file)
if ((file->f_flags & O_APPEND) && !(file->f_flags & O_NONBLOCK))
return -EINVAL; /* invalid combination */
- err = stream_open(inode, file);
- if (err < 0)
- return err;
+ stream_open(inode, file);
if (maj == snd_major) {
rmidi = snd_lookup_minor_data(iminor(inode),
--
2.43.0
next prev parent reply other threads:[~2026-07-02 8:45 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-02 8:44 [PATCH v2 0/7] ALSA: Remove redundant open helper return checks phucduc.bui
2026-07-02 8:44 ` [PATCH v2 1/7] ALSA: control: Drop redundant stream_open() return check phucduc.bui
2026-07-02 8:44 ` [PATCH v2 2/7] ALSA: mixer: oss: Drop redundant nonseekable_open() " phucduc.bui
2026-07-02 8:44 ` [PATCH v2 3/7] ALSA: pcm: " phucduc.bui
2026-07-02 8:44 ` [PATCH v2 4/7] ALSA: pcm: " phucduc.bui
2026-07-02 8:44 ` phucduc.bui [this message]
2026-07-02 8:44 ` [PATCH v2 6/7] ALSA: seq: Drop redundant stream_open() " phucduc.bui
2026-07-02 8:44 ` [PATCH v2 7/7] ALSA: timer: " phucduc.bui
2026-07-02 9:31 ` [PATCH v2 0/7] ALSA: Remove redundant open helper return checks Cezary Rojewski
2026-07-03 11:06 ` Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260702084445.519669-6-phucduc.bui@gmail.com \
--to=phucduc.bui@gmail.com \
--cc=bigeasy@linutronix.de \
--cc=cassiogabrielcontato@gmail.com \
--cc=cezary.rojewski@intel.com \
--cc=chenziqing@xiaomi.com \
--cc=eilaimemedsnaimel@gmail.com \
--cc=error27@gmail.com \
--cc=hariconscious@gmail.com \
--cc=kees@kernel.org \
--cc=kylebot@openai.com \
--cc=len.bao@gmx.us \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=maoyixie.tju@gmail.com \
--cc=mehulrao@gmail.com \
--cc=mengdewei@cqsoftware.com.cn \
--cc=nathan@kernel.org \
--cc=perex@perex.cz \
--cc=tiwai@suse.com \
--cc=zzzccc427@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.