Re: [PATCH v5 1/5] arm64: dts: qcom: pmk8550: add VADC node

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The devicetree header file `qcom-adc5-gen3.h` is missing from the patch and the repository, causing a fatal build failure.
--

commit f729ded8a3dc9a334b27b383ee9e5744b3564db8
Author: Neil Armstrong <neil.armstrong@linaro.org>

arm64: dts: qcom: pmk8550: add VADC node

This commit adds the VADC node and the initial pmk8550 adc channels.

> diff --git a/arch/arm64/boot/dts/qcom/pmk8550.dtsi b/arch/arm64/boot/dts/qcom/pmk8550.dtsi
> index 3049eb6b46d7a..3a9d9f7c37426 100644
> --- a/arch/arm64/boot/dts/qcom/pmk8550.dtsi
> +++ b/arch/arm64/boot/dts/qcom/pmk8550.dtsi
> @@ -7,6 +7,7 @@
>  #include <dt-bindings/input/linux-event-codes.h>
>  #include <dt-bindings/interrupt-controller/irq.h>
>  #include <dt-bindings/spmi/spmi.h>
> +#include "qcom-adc5-gen3.h"

[Severity: Low]
Is the qcom-adc5-gen3.h header missing from this patch series? It doesn't
appear to be present in the repository, which causes a build failure when
the device tree compiler preprocessor tries to include it.

[ ... ]

> +		pmk8550_vadc: adc@9000 {
> +			compatible = "qcom,spmi-adc5-gen3";

[ ... ]

> +			channel@0 {
> +				reg = <ADC5_GEN3_REF_GND(0)>;

[Severity: Low]
Are the ADC5_GEN3_REF_GND and related parameterized macros expected to be
defined in the missing qcom-adc5-gen3.h header? Without the header, these
channel definitions won't compile.

> +				label = "pmk8550_offset_ref";
> +				qcom,pre-scaling = <1 1>;
> +			};

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260702-topic-sm8x50-adc5-gen3-v5-0-8169953634ad@linaro.org?part=1